- 07 9月, 2017 5 次提交
-
-
-
由 Ryuta Kamizono 提交于
Because `table` is part of `reflection`, don't need to pass it explicitly. And also, naming `alias_name` to `table` is a little confusing. `aliased_table` is preferable than `alias_name`.
-
由 Ryuta Kamizono 提交于
`PolymorphicReflection` is an internal class that is used in `ThroughReflection`. But `RuntimeReflection` is used for the head of chain in `AssociationScope`. These are totally different things.
-
由 Ryuta Kamizono 提交于
The order of scope evaluation should be from through scope to the association's own scope. Otherwise the association's scope cannot affect to through scope. Fixes #13677. Closes #28449.
-
由 Ryuta Kamizono 提交于
[ci skip]
-
- 06 9月, 2017 3 次提交
-
-
由 Vipul A M 提交于
fix type fully qualified [ci skip]
-
由 Yauheni Dakuka 提交于
-
由 Aaron Patterson 提交于
Normalize/process Cache-Control headers consistently
-
- 05 9月, 2017 8 次提交
-
-
由 Ryuta Kamizono 提交于
Do not pass an instance variable to a private method
-
由 Matthew Draper 提交于
Run in-app rails commands via fork+load where possible
-
由 Ryuta Kamizono 提交于
Because `refl.scope` is the same meaning with `chain_head.scope`.
-
由 Kasper Timm Hansen 提交于
Explicitly require `test_unit/reporter`
-
由 Kasper Timm Hansen 提交于
Add Documentation For Duration Support & Expiry Meta Data Added to Signed / Encrypted Cookies
-
由 Ryuta Kamizono 提交于
Because `reflection_scope.values` will create extra new hash.
-
由 Ryuta Kamizono 提交于
If `reflection.scope` isn't given, `reflection_scope` is always `klass.unscoped`. it is unnecessary to merge it.
-
- 04 9月, 2017 8 次提交
-
-
由 Ryuta Kamizono 提交于
Otherwise using reserved words as composite primary key names will be failed as an invalid SQL. Fixes #30518.
-
由 Matthew Draper 提交于
While this avoids shell argument parsing, we still pass through everything in our stack.
-
由 Assain 提交于
* Documentation for Duration support added to signed/encrypted cookies * Changelog entries for the duration support and expiry metadata added to cookies [ci skip]
-
由 yuuji.yaginuma 提交于
If the user used the `bin/test` to execute the test, this file is automatically loaded, so require is unnecessary. https://github.com/rails/rails/blob/acea68de026ba657cb65c4dd0fc1f24ba67e1cf8/railties/lib/rails/plugin/test.rb#L4 However, when using `rake test`, an explicit require is required because the above file is not loaded. Fixes #30516
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
-
由 Ryuta Kamizono 提交于
Defined scope treats nil as `all`, but scope in associations isn't so. If the result of the scope is nil, most features on associations will be broken. It should treat nil as `all` like defined scope. Fixes #20823.
-
- 03 9月, 2017 2 次提交
-
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
This effectively reverts 200cf32e, restoring a variant of 5a0e0e72.
-
- 02 9月, 2017 14 次提交
-
-
由 Ryuta Kamizono 提交于
Because this is not a test case.
-
由 Ryuta Kamizono 提交于
Remove outdated comment [ci skip]
-
由 yuuji.yaginuma 提交于
We do not use double assign since 61f92f8b.
-
由 Matthew Draper 提交于
-
由 Ryuta Kamizono 提交于
If `reflection_scope.where_clause` is not empty, `through_scope` should be joined the source association. But if `values[:references]` in `reflection_scope` is empty, the source association will not be joined. It should use `source_reflection.table_name` in that case. Fixes #22535. Closes #28763.
-
由 Ryuta Kamizono 提交于
Fix `can't modify frozen String` error in AC::Rendering
-
由 Koichi ITO 提交于
-
由 Ryuta Kamizono 提交于
Replace unnecessary link with typewriter text [ci skip]
-
由 George Claghorn 提交于
-
由 Yoshiyuki Hirano 提交于
-
由 Ryuta Kamizono 提交于
If `reflection_scope.where_clause` is not empty, `through_scope` should be joined the source association. But if the through association doesn't have explicit `:source`, `options[:source]` will be nil and `scope.includes_values` will also be empty. It should use `source_reflection.name` rather than `options[:source]`. Fixed by a26cff3c. Fixes #11078. Fixes #26129. Closes #14312. Closes #29155. Closes #29841.
-
由 Ryuta Kamizono 提交于
Without this fix, preloading `:comments_with_include` will cause the following error: ``` % bundle exec ruby -w -Itest test/cases/associations/eager_test.rb -n test_eager_with_has_many_through_join_model_with_include Using sqlite3 Run options: -n test_eager_with_has_many_through_join_model_with_include --seed 1502 E Error: EagerAssociationTest#test_eager_with_has_many_through_join_model_with_include: ActiveRecord::AssociationNotFoundError: Association named 'post' was not found on Post; perhaps you misspelled it? ```
-
由 Ryuta Kamizono 提交于
If `reflection_scope.where_clause` is empty, `scope` isn't changed. So `scope.eager_loading?` is always false.
-
由 Ryuta Kamizono 提交于
Bump PostgreSQL version to the latest version 9.6 at Travis CI
-