1. 04 3月, 2017 11 次提交
    • Y
      Do not take screenshot if driver does not support screenshot · 2ee4058c
      yuuji.yaginuma 提交于
      `Capybara::RackTest::Driver` does not support taking screenshots. If call
      `#save_screenshot` on `Capybara::RackTest::Driver` will raise the error.
      
      ```ruby
      Error:
      UsersTest#test_visiting_the_index:
      Capybara::NotSupportedByDriverError: Capybara::Driver::Base#save_screenshot
      ```
      
      To prevent errors, if driver does not support screenshot, do not call it.
      2ee4058c
    • A
      Merge pull request #28272 from rails/add-iso8601-and-rfc3339-parsing · de17d9e2
      Andrew White 提交于
      Add iso8601 and rfc3339 parsing to timezones
      de17d9e2
    • A
      Add `rfc3339` aliases to `xmlschema` · f0aeecda
      Andrew White 提交于
      For naming consistency when using the RFC 3339 profile
      of ISO 8601 in applications.
      f0aeecda
    • A
      Add `Time.rfc3339` parsing method · 08e05d4a
      Andrew White 提交于
      The `Time.xmlschema` and consequently its alias `iso8601` accepts
      timestamps without a offset in contravention of the RFC 3339
      standard. This method enforces that constraint and raises an
      `ArgumentError` if it doesn't.
      08e05d4a
    • A
      Add `ActiveSupport::TimeZone.rfc3339` parsing method · f61062c7
      Andrew White 提交于
      Previously there was no way to get a RFC 3339 timestamp
      into a specific timezone without either using `parse` or
      chaining methods. The new method allows parsing directly
      into the timezone, e.g:
      
          >> Time.zone = "Hawaii"
          => "Hawaii"
          >> Time.zone.rfc3339("1999-12-31T14:00:00Z")
          => Fri, 31 Dec 1999 14:00:00 HST -10:00
      
      This new method has stricter semantics than the current
      `parse` method and will raise an `ArgumentError`
      instead of returning nil, e.g:
      
          >> Time.zone = "Hawaii"
          => "Hawaii"
          >> Time.zone.rfc3339("foobar")
          ArgumentError: invalid date
          >> Time.zone.parse("foobar")
          => nil
      
      It will also raise an `ArgumentError` when either the
      time or offset components are missing, e.g:
      
          >> Time.zone = "Hawaii"
          => "Hawaii"
          >> Time.zone.rfc3339("1999-12-31")
          ArgumentError: invalid date
          >> Time.zone.rfc3339("1999-12-31T14:00:00")
          ArgumentError: invalid date
      f61062c7
    • A
      Add `ActiveSupport::TimeZone.iso8601` parsing method · 4974b1a4
      Andrew White 提交于
      Previously there was no way to get a ISO 8601 timestamp into a specific
      timezone without either using `parse` or chaining methods. The new method
      allows parsing directly into the timezone, e.g:
      
          >> Time.zone = "Hawaii"
          => "Hawaii"
          >> Time.zone.iso8601("1999-12-31T14:00:00Z")
          => Fri, 31 Dec 1999 14:00:00 HST -10:00
      
      If the timestamp is a ISO 8601 date (YYYY-MM-DD) then the time is set
      to midnight, e.g:
      
          >> Time.zone = "Hawaii"
          => "Hawaii"
          >> Time.zone.iso8601("1999-12-31")
          => Fri, 31 Dec 1999 00:00:00 HST -10:00
      
      This new method has stricter semantics than the current `parse` method
      and will raise an `ArgumentError` instead of returning nil, e.g:
      
          >> Time.zone = "Hawaii"
          => "Hawaii"
          >> Time.zone.iso8601("foobar")
          ArgumentError: invalid date
          >> Time.zone.parse("foobar")
          => nil
      4974b1a4
    • R
      Merge pull request #28271 from dijonkitchen/patch-2 · 654afb28
      Robin Dupret 提交于
      Fix spelling in docs
      654afb28
    • J
      Fix spelling · 8efda4a9
      Jonathan Chen 提交于
      [ci skip]
      8efda4a9
    • E
      Remove unnecessary system test code · d3e7d910
      eileencodes 提交于
      It turns out that we don't need to require system tests in the railties
      test helper so we can remove it. If you're using system tests they will
      be loaded by inheriting from ActionDispatch::SystemTestCase and the
      routes will be loaded by ActionDispatch::IntegrationTest.
      d3e7d910
    • A
      Merge pull request #28267 from rails/rm-node-from-constraints · 76be78c5
      Aaron Patterson 提交于
      Remove `node` parameter to `join_constraints`
      76be78c5
    • A
      Remove `node` parameter to `join_constraints` · 6a962852
      Aaron Patterson 提交于
      I don't think we actually need this parameter anymore.  Nobody seems to
      be using it.
      6a962852
  2. 03 3月, 2017 13 次提交
  3. 02 3月, 2017 10 次提交
  4. 01 3月, 2017 6 次提交