- 01 7月, 2012 15 次提交
-
-
由 José Valim 提交于
Persist glob when replacing a path
-
由 Andrew White 提交于
Use Time.new to create times where the current offset is not zero or not in the local time zone - closes #4847 and #6651.
-
由 Andrew White 提交于
Time#at no longer raises an error for large values so we can remove the rescue clause from ActiveSupport::TimeZone#to_f.
-
由 Andrew White 提交于
Currently if the offset is not zero then to_time returns self which can lead to errors where a developer assumes that the value is a Time. To solve this we can use the native implementation of DateTime#to_time in Ruby 1.9.3 as it handles offsets properly and is faster than our override.
-
由 Andrew White 提交于
The native implementation of the seconds since the UNIX epoch in strftime is significantly faster than our method. Benchmark: ---------- require 'benchmark/ips' require 'date' require 'time' date = DateTime.civil(1253,7,6,20,4,0) Benchmark.ips do |x| x.report("strftime.to_i") { date.strftime('%s').to_i } x.report("ssue.to_i") { ((date - DateTime.civil(1970)) * 86400).to_i } x.report("strftime.to_f") { date.strftime('%s').to_f } x.report("ssue.to_f") { ((date - DateTime.civil(1970)) * 86400).to_f } end Output: ------- Calculating ------------------------------------- strftime.to_i 26480 i/100ms ssue.to_i 13818 i/100ms strftime.to_f 26561 i/100ms ssue.to_f 14479 i/100ms ------------------------------------------------- strftime.to_i 616937.3 (±2.4%) i/s - 3098160 in 5.024749s ssue.to_i 200108.8 (±6.9%) i/s - 994896 in 4.999278s strftime.to_f 553581.3 (±2.2%) i/s - 2788905 in 5.040397s ssue.to_f 204260.3 (±4.3%) i/s - 1028009 in 5.043072s
-
由 Nicholas Mulder 提交于
When Rails::Paths::Root's []= is used to replace a path it should persist the previous path's glob. Without passing the glob along we get gnarly bugs when trying to wire up things like engines. module FooEngine class Engine < ::Rails::Engine isolate_namespace FooEngine config.paths['config/initializers'] = "lib/foo_engine/initializers" end end ## Example of behaviour before this commit. # # Before the initializer override: >> FooEngine::Engine.config.paths["config/initializers"].glob => "**/*.rb" # After the initializer override: >> FooEngine::Engine.config.paths["config/initializers"].glob => nil ## Example of behaviour after this commit. # # Before the initializer override: >> FooEngine::Engine.config.paths["config/initializers"].glob => "**/*.rb" # After the initializer override: >> FooEngine::Engine.config.paths["config/initializers"].glob => "**/*.rb"
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
Remove Active Model dependency from Action Pack
-
由 Carlos Antonio da Silva 提交于
Add :default and :null options to column_exists? method Examples: column_exists?(:testings, :taggable_id, :integer, null: false) column_exists?(:testings, :taggable_type, :string, default: 'Photo')
-
由 Aleksey Magusev 提交于
Also fix failures in check options for nil
-
由 Vijay Dev 提交于
Conflicts: activemodel/lib/active_model/errors.rb
-
由 Carlos Antonio da Silva 提交于
-
由 José Valim 提交于
Av prepare2
-
由 Rafael Mendonça França 提交于
Extract collation tasks to database tasks.
-
由 Guillermo Iguaran 提交于
ActiveModel is used in ActionPack for ActiveModel::Naming for a few, mostly optional aspects of ActionPack related to automatically converting an ActiveModel compliant object into a key for params and routing. It uses only three methods of ActiveModel (ActiveModel::Naming.route_key, ActiveModel::Naming.singular_route_key and ActiveModel::Naming.param_key).
-
- 30 6月, 2012 7 次提交
-
-
由 kennyj 提交于
-
由 Jon Leighton 提交于
Remove ActiveRelation#inspect
-
由 Brian Cardarella 提交于
-
由 Xavier Noria 提交于
make sure the inflection rules are loaded when cherry-picking active_support/core_ext/string/inflections.rb [fixes #6884]
-
由 Carlos Antonio da Silva 提交于
Introduced in 1abe3167 The test was failing when running on isolation, because the extensions were not being loaded, thus 1.year.from_now was failing. Just use mktime instead, adding 1 year to Time.now.
-
由 Carlos Antonio da Silva 提交于
Related with 5e7d6bba
-
由 Rafael Mendonça França 提交于
Related with 5e7d6bba
-
- 29 6月, 2012 18 次提交
-
-
由 José Valim 提交于
Bug with FileUpdateChecker with wrong mtime
-
由 José Valim 提交于
This reverts commit 6acebb38. Usage of this feature did not reveal any improvement in existing apps. Conflicts: actionpack/lib/action_dispatch/routing/mapper.rb guides/source/routing.textile railties/lib/rails/engine.rb railties/lib/rails/paths.rb railties/test/paths_test.rb
-
由 abonec 提交于
-
由 José Valim 提交于
Since plugins were removed, we can clean up a few methods in engines. We also use this opportunity to move `load_console`, `load_tasks` and `load_runner` to Rails::Engine. This means that, if someone wants to improve script/rails for engines to support console or runner commands, part of the work is already done.
-
由 José Valim 提交于
-
由 José Valim 提交于
-
由 José Valim 提交于
-
由 Santiago Pastorino 提交于
Added a changelog entry about fda24312.
-
由 Nick Sutterer 提交于
-
由 kennyj 提交于
-
由 Nick Sutterer 提交于
remove AV.prepare and move all helper-related logic into the controller. this decouples the view since it no longer knows about routes internals. this is a result of an ongoing discussion at https://github.com/rails/rails/pull/6826.
-
由 Alex Nisnevich 提交于
Remove mention of `convert_key` now that it's been taken out in 1eecd948
-
由 Chris Adams 提交于
Instead of the standard Ruby logger
-
由 Francesco Rodriguez 提交于
-
由 Carlos Antonio da Silva 提交于
fix ActionMailer::Async docs and update to follow coding conventions
-
由 Francesco Rodriguez 提交于
-
由 Carlos Antonio da Silva 提交于
Require URI in ConnectionSpecification
-
由 Chris Bandy 提交于
-