- 28 3月, 2014 1 次提交
-
-
由 Henrik Nyh 提交于
It's unintuitive to call '#valid?' when you want to run validations but don't care about the return value. The alias in ActiveRecord isn't strictly necessary (the ActiveModel alias is still in effect), but it clarifies.
-
- 27 3月, 2014 19 次提交
-
-
由 Yves Senn 提交于
When the tests are executed in order, the dependency is loaded at the right time. However this makes it impossible to execute a single test later down the line. Let's require the dependecy at the beginning to get them working independent of the order. This resolves the following error: ``` $ ARCONN=postgresql ruby -Itest /Users/senny/Projects/rails/activerecord/test/cases/xml_serialization_test.rb -n test_to_xml Using postgresql Run options: -n test_to_xml --seed 51819 E Finished in 0.081320s, 12.2971 runs/s, 0.0000 assertions/s. 1) Error: DatabaseConnectedXmlSerializationTest#test_to_xml: NameError: uninitialized constant DatabaseConnectedXmlSerializationTest::REXML /Users/senny/Projects/rails/activerecord/test/cases/xml_serialization_test.rb:226:in `test_to_xml' ``` /cc @tgxworld fyi
-
由 Yves Senn 提交于
This will keep the test suite passing with older PG installations.
-
由 Rafael Mendonça França 提交于
Add a test case for save(validate: false) with invalid foreign key.
-
由 Lauro Caetano 提交于
It is supposed to raise ActiveRecord::InvalidForeignKey when the database has a fk constraint.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
This method is not being called anywhere in our code and a GitHub search show it is not being used in any project.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
* cache `o.name` value * Avoid extra `concat` call * Avoid extra `<<` call
-
由 Rafael Mendonça França 提交于
These comments will likely be outdated with time and doesn't include any information that can't be found in the adapters
-
由 Rafael Mendonça França 提交于
Also improve some of the code conventions
-
由 Rafael Mendonça França 提交于
Create indexes inline in CREATE TABLE for MySQL
-
由 Rafael Mendonça França 提交于
[ci skip] Fix Pull Request URL in 4.1 release note.
-
由 Juanito Fatas 提交于
-
- 26 3月, 2014 8 次提交
-
-
由 Yves Senn 提交于
-
由 Steve Rice 提交于
Also: - updates tests by stubbing table_exists? method - adds entry for creating indexes in CREATE TABLE to changelog
-
由 Cody Cutrer 提交于
This is important, because adding an index on a temporary table after it has been created would commit the transaction Conflicts: activerecord/CHANGELOG.md
-
由 Rafael Mendonça França 提交于
[ci skip]
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Still touch associations when theres no timestamp
-
由 Rafael Mendonça França 提交于
This reverts commit 6e3ab3e1, reversing changes made to 39e07b64. Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/autosave_association_test.rb
-
- 25 3月, 2014 12 次提交
-
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
Generating proper migration when ActiveRecord::Base.pluralize_table_names = false
-
由 Kuldeep Aggarwal 提交于
ActiveRecord::Base.pluralize_table_names = false. Previously, generation a migration like this: rails g migration add_column_name_to_user name would not generating the correct table name. Fixes #13426.
-
由 Rafael Mendonça França 提交于
Support the options methods in tests
-
由 Frederick Cheung 提交于
-
由 Yves Senn 提交于
Conflicts: actionpack/CHANGELOG.md activerecord/CHANGELOG.md activesupport/CHANGELOG.md railties/CHANGELOG.md
-
由 Aaron Patterson 提交于
arel methods are not supposed to be public API for ActiveRecord
-
由 Aaron Patterson 提交于
This abstracts us from the actual construction of the nodes
-
由 Rafael Mendonça França 提交于
Rename method and stop passing unused arguements.
-
由 Rafael Mendonça França 提交于
Fix date_select with_css_classes: true option overwriting other html classes
-
由 Izumi Wong-Horiuchi 提交于
with_css_classes: true option overwrites other html classes. Concatenate day month and year classes rather than overwriting.
-
由 Vipul A M 提交于
- Rename `increment_or_decrement` to an apt `set_cache_value` since it actually doesn't increment/decrement in localstore.
-