Follow up of 1683410c.
Signed-off-by: NJeremy Daer <jeremydaer@gmail.com>

`ActiveRecord::Migration` needn't know about migration version
compatibility lookup. Delegate it to the Compatibility module.
Signed-off-by: NJeremy Daer <jeremydaer@gmail.com>

This commit undoes 54243fec.

Reason: Further investigation has shown the benefit is not so clear
generally speaking.

There is a long discussion and several benchmarks in the PR #24658
if you are interested in the details.

Closes #24766, #24767
Signed-off-by: NJeremy Daer <jeremydaer@gmail.com>

Use the updated changelog from the first merge: 7254517f

References #22806, #24762.

[ci skip]

Update configuring.md with colons and periods

Some configuration options started with a capital letter indicating the beginning of a sentence, which didn't makes sense without the colons. Similarly, some were missing periods at the end of their descriptions. [ci skip]

Patch 1

Per discussion in #24786.

Document config.assets.gzip flag.

[ci skip]

Conflicts:
	guides/source/configuring.md

Active Job: Add note about ability to configure adapters on per job basis in CHANGELOG and release notes

[FIX] Change 1.week to create 1 week durations instead of 7 days durations.

Remove last uses of `@env[]` and `@env[]=`

Active Job: Add note about ability to configure adapters on per job basis in CHANGELOG and release notes.

[ci skip]

Last August (2015), @tenderlove worked to remove all `@env[]` and `@env[]=`, in
favor of using `set_header`, `get_header`, etc. (Here's an [example
commit](https://github.com/rails/rails/commit/f16a33b68efc3dc57cfafa27651b9a765e363fbf)).

This PR should remove the last uses of these methods, and fully convert
them to the newly standardized API.

schema_load triggers 2nd schema_load (via locking)

Currently, loading the schema (schema_load)
accesses the locking column (locking_column)
which defaults the value (reset_locking_column)
which invalidates the schema (reload_schema_from_cache)
which forces another schema load.

Good news:
The second schema_load does accesses locking_column,
but locking_column is set, so it does not reset_locking_column
and it does not trigger an infinite loop.

The solution is not invalidate the cache while default locking_column

Pass over debugging guide

Fix broken links to ryandaigle.com [ci skip]

[ci skip]

Review the `byebug` debugging guide [ci skip]

* Several formatting fixes.
* Updated command outputs to latest version.
* Minor rewordings.

[ci skip]

Merge pull request #24765 from ralinchimev/fix-inconsistencies-in-rails-documentation-generate-controller-examples

Fix inconsistent usage of a capital letter in rails generate examples [ci skip]

This is just to remove astonishment from getting `3600 seconds` from typing `1.hour`.

Update to the Rails 5 version of the book [ci skip]

Push action_view.collection_caching to be called towards the end

Push action_view.collection_caching to be called towards the end, since it depends on being called after action_controller.set_configs.
This causes, other AV initializers after it to be called after all of AC initializers, which get pulled in before since action_controller.set_configs gets called.
Hence, push initializer depending on after hook, to be called after all initializers for this railtie are done.

This addition of `--pre` fixes the issue we were seeing when installing
a local copy of a pre-release rails version.

We don't need no stinking `on_load` where we're going! Because
people far wiser than me (@rafaelfranca and @jeremy) know that
passing `:after` means the lib is already loaded.

Regression: adding minutes/hours to a time would change its time zone

This reverts commit 1bf9fe75.

Ensure action_controller.cache_store is set up before configuring the collection_cache