- 05 4月, 2018 2 次提交
-
-
由 Rafael França 提交于
Remove superfluous `ActionController::`
-
由 Francois Chagnon 提交于
-
- 04 4月, 2018 9 次提交
-
-
由 Eileen M. Uchitelle 提交于
Add missing dots at the end of comments in environment file templates
-
由 Eileen M. Uchitelle 提交于
[ci skip] Add :private option to delegate section in guide
-
由 Yoshiyuki Hirano 提交于
-
由 Ryuta Kamizono 提交于
It is wrongly appeared as instance public methods in the doc. http://api.rubyonrails.org/v5.1.6/classes/ActionCable/Channel/Callbacks.html http://api.rubyonrails.org/v5.1.6/classes/ActiveRecord/Timestamp.html
-
由 Yuji Yaginuma 提交于
Fix RenderingTest in railtie
-
由 Andrew White 提交于
Use `:default` option in order to set default value of `finalize_compiled_template_methods`
-
由 Yoshiyuki Hirano 提交于
Test class name is not `RoutingTest` but `RenderingTest`
-
由 Xavier Noria 提交于
Note that tab_yellow.gif exists, that is the one being used.
-
由 Xavier Noria 提交于
The credits page is gone after #32429, these images are now orphan.
-
- 03 4月, 2018 15 次提交
-
-
由 bogdanvlviv 提交于
Add dots in order to keep consistency between other comments in these files.
-
由 bogdanvlviv 提交于
Since we introduced default option for `class_attribute` and `mattr_accessor` family of methods and changed all occurrences of setting default values by using of `:default` option I think it would be fine to use `:default` option in order to set default value of `finalize_compiled_template_methods` since it expresses itself very well. Related to #29294, #32418
-
由 Andrew White 提交于
Cleanup credits related code as it is removed now in PR #32429
-
由 Prathamesh Sonpatki 提交于
-
由 Kasper Timm Hansen 提交于
Remove credits.html from Rails Guides
-
由 Ryuta Kamizono 提交于
Display db:drop description in ActiveRecord
-
由 Yoshiyuki Hirano 提交于
-
由 Ryuta Kamizono 提交于
Small doc fixes [ci skip]
-
由 Ryuta Kamizono 提交于
Doc fix added missing quote [ci skip]
-
由 Yoshiyuki Hirano 提交于
* refs #32420
-
由 Michael H 提交于
-
由 T.J. Schuck 提交于
[ci skip]
-
由 Rafael França 提交于
Disable ActionView::Template finalizers in test environment
-
由 Simon Coffey 提交于
ActionView::Template instances compile their source to methods on the ActionView::CompiledTemplates module. To prevent leaks in development mode, where templates can frequently change, a finalizer is added that undefines these methods[1] when the templates are garbage-collected. This is undesirable in the test environment, however, as templates don't change during the life of the test. Moreover, the cost of undefining a method is proportional to the number of descendants a class or module has, since the method cache must be cleared for all descendant classes. As ActionView::CompiledTemplates is mixed into every ActionView::TestCase (or in RSpec suites, every view spec example group), it can end up with a very large number of descendants, and undefining its methods can become very expensive. In large test suites, this results in a long delay at the end of the test suite as all template finalizers are run, only for the process to then exit. To avoid this unnecessary cost, this change adds a config option, `action_view.finalize_compiled_template_methods`, defaulting to true, and sets it to false in the test environment only. [1] https://github.com/rails/rails/blob/09b2348f7fc8d4e7191e70e06608c5909067e2aa/actionview/lib/action_view/template.rb#L118-L126
-
由 Aaron Patterson 提交于
Make mutating params#dig return value mutate underlying params
-
- 02 4月, 2018 11 次提交
-
-
由 Guillermo Iguaran 提交于
Extract the confirm call in its own, overridable method in rails_ujs
-
由 Guillermo Iguaran 提交于
Remove `ForeignKeys` module which was introduced at #32299
-
由 Rafael França 提交于
Not generate needless files in guides
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
Add AR::Base.base_class? predicate
-
由 Kasper Timm Hansen 提交于
Move SourceAnnotationExtractor under Rails module
-
由 Bogdan Gusiev 提交于
-
由 Yoshiyuki Hirano 提交于
Not generate needless files: * _license.html.erb, _welcome.html.erb are partial files. * layout.html.erb is the layout file.
-
由 Ryuta Kamizono 提交于
To solve the problem #32299, just enough to introduce `fk_ignore_pattern` option. I don't think there is a need to expose these constants.
-
由 Yuji Yaginuma 提交于
Fix typo in rails-ujs HTML content test
-
由 Raymond Zhou 提交于
`</ps>` is not a valid closing tag for `<p>`.
-
- 01 4月, 2018 3 次提交
-
-
由 Kasper Timm Hansen 提交于
Use consistent spacing in actionview helper docs
-
由 Olivier Lacan 提交于
The spacing in these comments is fairly inconsistent. Array argument contents are often separated with a space from the array literal brackets but in several cases the Hash literal curly braces are tangent to their contents which makes the documentation harder to read in some cases.
-
由 Kasper Timm Hansen 提交于
Pass HTML responses as plain-text in rails-ujs
-