- 04 12月, 2019 5 次提交
-
-
由 Patrick Rebsch 提交于
Applying `includes` and `joins` to a relation that selected additional database fields would cause those additional fields not to be included in the results even though they were queried from the database: posts = Post.select('1 as other').includes(:tbl).joins(:tbl) posts.to_sql.include?('1 as other') #=> true posts.first.attributes.include?('other') #=> false This commit includes these additionally selected fields in the instantiated results.
-
由 Eileen M. Uchitelle 提交于
Fix bug in configs_for
-
由 eileencodes 提交于
If a spec name was provided without an env name, config_for would return the first config that matched the spec, regardless of environment name. Now configs_for will return the database config that matches the default env and requested spec name. Additionally this commit has moved the default env call into a method because I'm tired of typing so many lines every single time. We considered either returning all configs that match that spec name or raising an error if only spec was passed, but this change has the least impact on current behavior and matches Active Record's assumptions: that if you ask for configs it will always consider the current environment. Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
-
由 Rafael França 提交于
Avoid allocating Binding instance in HWIA#convert_value
-
由 Jean Boussier 提交于
-
- 03 12月, 2019 9 次提交
-
-
由 Javan Makhmali 提交于
Fix ActiveStorage::Blob → ActionText::TrixAttachment conversion
-
由 Javan Makhmali 提交于
A regression introduced in 764803e0 caused blobs to appear as HTML content attachments instead of file / image attachments when editing rich text content. This change restores the original intended behavior. References: https://github.com/rails/rails/pull/35485, https://github.com/basecamp/trix/issues/706
-
由 Ryuta Kamizono 提交于
Correct default value of `unknown_asset_fallback` [ci skip]
-
由 Ryuta Kamizono 提交于
Fix random CI failure due to non-deterministic sorting order
-
由 Takayuki Nakata 提交于
`unknown_asset_fallback` defaults to `false`. Refere to 6813b480.
-
由 Andrew Haines 提交于
-
由 Gannon McGibbon 提交于
Deprecate `service_url` methods in favour of `url`
-
由 Peter Zhu 提交于
-
- 02 12月, 2019 3 次提交
-
-
由 Xavier Noria 提交于
-
由 Ryuta Kamizono 提交于
Fix `since` and `ago` with a duration which has empty parts
-
由 Ryuta Kamizono 提交于
Related #37839. Sometimes divisions of `ActiveSupport::Duration` makes the instance's parts attribute empty, but it has a value actually (e.g. `(1.minute / 60) # => @value=1 (second), but empty parts`). In that case we should respect `value` as the source of seconds.
-
- 01 12月, 2019 1 次提交
-
-
由 Austin Story 提交于
This change will allow subscribers to the notification to report on anything related to the request that they might need
-
- 30 11月, 2019 4 次提交
-
-
由 Ryuta Kamizono 提交于
The return value of `ActiveSupport::Duration#inspect` is wrong when its parts are empty
-
由 Ryuta Kamizono 提交于
Fix typo in "Options for render" section [ci skip]
-
由 Thais Kusuki 提交于
-
由 Tsukuru Tanimichi 提交于
```ruby (1.day / 24).inspect #=> "0 seconds" (1.day / 24).to_i #=> 3600 (1.day / 24) == 1.hour #=> true (1.hour).inspect #=> "1 hour" (1.hour).parts #=> {:hours=>1} (1.day / 24).parts #=> {} ``` Sometimes divisions of `ActiveSupport::Duration` make the instance's `parts` attribute empty. But these instances are not always 0 seconds. Related to #31310 and #31302
-
- 28 11月, 2019 9 次提交
-
-
由 Carlos Antonio da Silva 提交于
Fix minor typo in pattern example for number_to_phone [ci skip]
-
由 Michael MacDonald 提交于
There is an extra closing parenthesis on the last example for `number_to_phone` which causes it to be invalid
-
由 y-yagi 提交于
Call `MonitorMixin` initializer before use methods provided by `MonitorMixin`
-
由 yuuji.yaginuma 提交于
`MonitorMixin` setup internal variables in `initialize`, so need to call that before use. `ActionController::Live::Buffer` only use methods that do not depend on those internal variables, so works expertly. But since Ruby 2.7, methods that were not originally the case also depend on internal variables. As a result, some tests fail in Ruby 2.7. https://buildkite.com/rails/rails/builds/65193#02e136eb-edea-4367-aee0-77e0a82f8531/990-1200 I'm not sure if this should be considered Ruby incompatible, but I fixed this because its usage is wrong. Related to [Feature #16255: Make `monitor.rb` built-in](https://bugs.ruby-lang.org/issues/16255)
-
由 Ryuta Kamizono 提交于
Add Rails changelog URI
-
由 Ryuta Kamizono 提交于
Bump RuboCop version to 0.77
-
由 Anthony Ross 提交于
Prior to this change, exponentially_longer had adverse consequences during system-wide downstream failures. This change adds a random value to the back off calculation in order to prevent the thundering herd problem, whereby all retry jobs would retry at the same time. Specifically this change adds a jitter option to retry_on to enable users of it to scope the randomness calculation to a reasonable amount. The default is 15% of the exponential back off calculation.
-
由 Yasuo Honda 提交于
https://github.com/rubocop-hq/rubocop/releases/tag/v0.77.0 * Update cop names to changed as follows: ``` $ bundle exec rubocop Error: The `Layout/IndentFirstArgument` cop has been renamed to `Layout/FirstArgumentIndentation`. (obsolete configuration found in .rubocop.yml, please update it) The `Layout/TrailingBlankLines` cop has been renamed to `Layout/TrailingEmptyLines`. (obsolete configuration found in .rubocop.yml, please update it) The `Lint/StringConversionInInterpolation` cop has been renamed to `Lint/RedundantStringCoercion`. (obsolete configuration found in .rubocop.yml, please update it) $ ``` * Auto correct these offenses: ``` $ bundle exec rubocop -a ... snip ... Offenses: activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb:104:11: C: [Corrected] Style/RedundantReturn: Redundant return detected. return true ^^^^^^ activerecord/lib/active_record/reflection.rb:622:15: C: [Corrected] Style/RedundantReturn: Redundant return detected. return inverse_name ^^^^^^ activerecord/lib/active_record/table_metadata.rb:48:9: C: [Corrected] Style/RedundantReturn: Redundant return detected. return self ^^^^^^ 2812 files inspected, 3 offenses detected, 3 offenses corrected $ ```
-
由 Orien Madgwick 提交于
-
- 27 11月, 2019 3 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Ryuta Kamizono 提交于
Easy to show `bundle exec rubocop` output at GitHub Actions
-
由 Yasuo Honda 提交于
When pull requests have RuboCop offenses they need to click "Build and run RuboCop" section and scroll about 200 lines to skip `bundle install` output. This change splits "Build and run RuboCop" into two parts. then "Run RuboCop" section only shows `bundle exec rubocop --parallel` output
-
- 26 11月, 2019 2 次提交
-
-
由 Eileen M. Uchitelle 提交于
Fix making an extra db file after testing for sqlite3
-
由 Takayuki Nakata 提交于
Testing for sqlite3 makes an extra db file `primary.sqlite3` as below. ``` $ bundle exec rake test:sqlite3 (snip) $ git status On branch test Untracked files: (use "git add <file>..." to include in what will be committed) db/ ```
-
- 25 11月, 2019 4 次提交
-
-
由 Eileen M. Uchitelle 提交于
Prevent generating tests with non-existent routes
-
由 Eileen M. Uchitelle 提交于
Fix actions order in the comment
-
由 Patrik Bóna 提交于
The order of performed actions changed in 07ecaa61 but the comment stayed the same.
-
由 Ryuta Kamizono 提交于
fix(test): only test reaper with fork when fork is available
-