Three minor fixes to tests

test_should_cache_with_trailing_slash_on_url

A trailing slash is removed when a page is cached.

What the test meant to say was : a url with trailing slash
should be cached and the cached page should not have any
trailing slash.

This patch clarifies the name a bit.

Make sure `escape_javascript` return `SafeBuffer` if the incoming argumen

remove unused UserController from test

Fix engine's generator

Fix "warning: assigned but unused variable" on AR tests

class WithSymbolReturningString is not used anywhere in the test.

Date#freeze fails when called more than once in 1.8

Instance variable not used.

Simplify boolean logic into ternary

Secondly it seemed from the method that the intent was to test a case
where layout was declared in a symbol and the method named mention in
layout returns nil.

That case is already covered with class     class WithSymbolReturningNil .

Also the case of SymbolReturningString is covered with the class
WithSymbol.

If you set a js_compressor, it means that you want shit compressed -- we dont need a second option to turn that on

Update CHANGELOG to mention the new SafeBuffer change

Make escape_javascript happy to handle SafeBuffers

* see GH#1553
* allow for the fact that gsub on SafeBuffer does not pass match variables $1, $2 etc to a block

Make test meaningful

If before_filter list was being called mistakenly then
the test should fail. However test will not fail because
second filter is assigning new values to @list. To truly
test that first before_filter is not called when it should
not be called then @list should not assigned value unconditionally.

This patch will make the test fail if first filter is called.

Brought back alternative convention for namespaced models in i18n

Do not hardcode :id as it was ignored by mass assignment filter

As a result test was failing on Oracle where ids are assigned by default from 1000

test name should reflect the name of the method

remove unused class from test

that is actually being called