Refactor to a reusable method.

No need to check that each line contains an extra space, just matching
the space in the regexp is enough to ensure that.

Added a warning about serializing data with JSON cookie jars [skip ci]

Closes #14409

Fix a typo to make clause plural [ci skip]

Reorder conditional logic in link_to_if and link_to_unless

According to the best practice that "unless not" and "unless else"
is hard to follow logically the link_to_unless and link_to_if
were reversed.

Add counter cache test for class_name

Backport test from #14410

Previously, any of the connection checkouts could have failed, and this
test would pass.

Track owning thread for connection pool

.. not a general timeout.

Now, if a thread checks out a connection then dies, we can immediately
recover that connection and re-use it.

This should alleviate the pool exhaustion discussed in #12867. More
importantly, it entirely avoids the potential issues of the reaper
attempting to check whether connections are still active: as long as the
owning thread is alive, the connection is its business alone.

As a no-op reap is now trivial (only entails checking a thread status
per connection), we can also perform one in-line any time we decide to
sleep for a connection.

It wasn't doing anything beyond clearing the statement cache.

Add Public Api for Register New Extensions for Rake Notes

re-raise error if error occurs before committing in streaming

Closes #14406.

Closes #14405.

This is a follow-up to 9e997e90 to restore
the documented behavior.

Add an explicit require for 4ece1243 rather than assume SecureRandom is available

The method `shallow?` returns false if the parent resource is a singleton so
we need to check if we're not inside a nested scope before copying the :path
and :as options to their shallow equivalents.

Fixes #14388.

Follow up to 024e5e31

Extend fixture label replacement to allow string interpolation

Allows fixtures to use their $LABEL as part of a string instead
of limiting use to the entire value.

    mark:
      first_name: $LABEL
      username: $LABEL1973
      email: $LABEL@$LABELmail.com

    users(:mark).first_name # => mark
    users(:mark).username   # => mark1973
    users(:mark).email      # => mark@markmail.com

Reword 5.6 strong parameters and private method stuff [ci skip]

Fix MailerPreview broken tests

add include_hidden option to collection_check_boxes helper

Conflicts:
	actionview/CHANGELOG.md
	actionview/test/template/form_collections_helper_test.rb

`BaseMailerPreview.welcome` is an instance method, so we need to stub the
method on a instance level and not on Class. The stub is important to make
sure the Message object is the same in the other expectations.
This was working randomly because Mocha uses == to compare two objects
on the `with()` expectation and even if the Mail::Message objects were
not the same object they are equal, but thats not the case in 100% of
the runs. So we need to make sure we use `.any_instance` method and have
the right message object.