- 02 5月, 2014 13 次提交
-
-
由 Aaron Patterson 提交于
I think this is wrong, but it gets the build passing for now. We should always add options, but we need to make more guarantees about how the underlying url helper is called
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
if you want options, don't mix them with the first hash, just pass them all in with the second hash
-
由 Rafael Mendonça França 提交于
Symbolize variables of mysql/mysql2 connection configuration Conflicts: activerecord/CHANGELOG.md
-
由 Rafael Mendonça França 提交于
always use File.join in asset_path
-
由 phoet 提交于
-
由 Jeremy Kemper 提交于
[ci skip] Security guide clarity.
-
由 Kyle Heironimus 提交于
-
由 Rafael Mendonça França 提交于
Update mapper.rb
-
由 Rafael Mendonça França 提交于
Make remote_ip detection properly handle private IPv6 addresses Conflicts: actionpack/CHANGELOG.md
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
SQLite3: Always close statements. Conflicts: activerecord/CHANGELOG.md
-
由 Rafael Mendonça França 提交于
Avoid unnecessary conditional block
-
- 01 5月, 2014 12 次提交
-
-
由 Giovanni Cappellotto 提交于
GeneratedAttribute#column_name checks already for reference? on the attribute returning the right name to use as symbol for label and field.
-
由 Rafael Mendonça França 提交于
Add documentation to select_tag for :selected option
-
由 Matthew Draper 提交于
Give real privacy to class methods in AR::PredicateBuilder
-
由 Hector Satre 提交于
-
由 Rizwan Reza 提交于
-
由 Juan David Pastas 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Paul Nikitochkin 提交于
For mysql2/mysql adapters, `sql_mode` variable name set in `database.yml` as string, was ignored and `sql_mode` was set to use strict mode. Fixes #14895
-
由 Aaron Patterson 提交于
this reduces the number of comparisons and method calls `url_for` requires. The nil case no longer calls `symbolize_keys`, we already know options is nil, so no more ||=, and since it is nil we already know that options[:host] will be nil too.
-
- 30 4月, 2014 4 次提交
-
-
由 Arthur Nogueira Neves 提交于
the use of ... in place >> using ... instead
-
由 Jon Atack 提交于
[ci skip]
-
由 Xavier Noria 提交于
Motivated by #14907.
-
由 Vijay Dev 提交于
Update the Getting Started tutorial
-
- 29 4月, 2014 11 次提交
-
-
由 Yves Senn 提交于
-
由 Jon Atack 提交于
Update the Getting Started tutorial to clarify where and how to add controller actions, and fix some grammar. This PR is an improved version of #14828, #14822 and #14815. [skip ci]
-
由 Aaron Patterson 提交于
Merge pull request #14899 from eileencodes/fix-delete-all-with-nil-dependency-to-not-produce-in-statement Fix delete all with nil (:nullify) dependency to not produce in statement
-
由 eileencodes 提交于
Test checks that SQL is the same for a loaded vs not loaded association (category.categorizations, category.categorization.delete_all vs category.cartegroization.delete_al). This was fixed for delete_all dependency but was not fixed for no (:nullify, or nil) dependency).
-
由 eileencodes 提交于
Since clear shouldn't fire callbacks the order doesn't matter since it was never updated. Remove the portion of this test that tests for order after clear.
-
由 eileencodes 提交于
Clear should not call callbacks because it clear calls delete_all and then returns self. It should behave the same as delete_all. This test clarifies the goal of the test and tests the correct outcome.
-
由 eileencodes 提交于
Nullify (or nil dependency) was doing the same thing delete_all was doing in issue #14546, creating a large IN statement if the association was loaded. Loaded and not loaded associations should behave the same. The IN statement is also not great because it's inefficient.
-
由 Yves Senn 提交于
[ci skip] updating active_record/associations to demonstrate where conflict with eager loading.
-
由 anilmaurya 提交于
-
由 Aaron Patterson 提交于
Breakup complex conditionals on delete
-
由 eileencodes 提交于
After reviewing this code I realized the conditional that was there previously was basically saying if the dependency is not delete all. This is a better, cleaner, and clearer way to write this method.
-