- 29 7月, 2018 4 次提交
-
-
由 Bart de Water 提交于
-
由 Bart de Water 提交于
`5 =~ /\d/` returns nil, but Integer doesn't have a `match?` method.
-
由 Bart de Water 提交于
Rubocop warns about "Use String#end_with? instead of a regex match anchored to the end of the string", it doesn't seem aware of the $` special variable like Performance/RegexpMatch
-
由 Bart de Water 提交于
In cases where the MatchData object is not used, this provides a speed-up: https://github.com/JuanitoFatas/fast-ruby/#stringmatch-vs-stringmatch-vs-stringstart_withstringend_with-code-start-code-end
-
- 28 7月, 2018 2 次提交
-
-
由 Kasper Timm Hansen 提交于
Clean up some concepts in the code while we're here.
-
由 lsylvester 提交于
-
- 27 7月, 2018 20 次提交
-
-
由 Eileen M. Uchitelle 提交于
Testing Guide: unnecessary comment
-
由 George Claghorn 提交于
&& binds tighter than || in JavaScript, but we ought not expect readers to remember language trivia.
-
由 George Claghorn 提交于
Closes #33450.
-
由 Yannick Schutz 提交于
* PostgreSQL 10 new relkind for partitioned tables Starting with PostgreSQL 10, we can now have partitioned tables natively * Add comment * Remove extra space * Add test for partition table in postgreSQL10 * Select 'p' for "BASE TABLE" and add a test case to support PostgreSQL 10 partition tables * Address RuboCop offense * Addressed incorrect `postgresql_version` Fixes #33008. [Yannick Schutz & Yasuo Honda & Ryuta Kamizono]
-
由 Ryuta Kamizono 提交于
Remove Rubocop's comments from Rails code base
-
由 George Claghorn 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Add event object subscriptions to AS::Notifications
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 bogdanvlviv 提交于
``` Offenses: activesupport/lib/active_support/subscriber.rb:91:17: C: Layout/SpaceAroundOperators: Operator = should be surrounded by a single space. event = event_stack.pop ```
-
由 bogdanvlviv 提交于
PR#32381 added Rubocop's comments to some tests files in order to exclude `Performance/RedundantMerge`. Turn off `Performance` cops for tests files via `Exclude` in `.rubocop.yml`. Context https://github.com/rails/rails/pull/32381#discussion_r205212331
-
由 Aaron Patterson 提交于
We don't need to have a special subscribe method for objects. The regular `subscribe` method is more expensive than a specialized method, but `subscribe` should not be called frequently. If that turns out to be a hotspot, we can introduce a specialized method. :)
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Fanout notifier can send event objects to subscribers now. Also moved `end` lower in the `finish!` method to guarantee that CPU time is shorter than real time.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Add cpu time, idle time, and allocations features to log subscriber events
-
由 Eileen Uchitelle 提交于
* Use process clock instead of Time.now This fixes any issues with the system clock changing and also eliminates 2 object allocations per event. * Add start! and finish! methods to the event object so we can record more information * Adds cpu time, idle time, and allocation count for a particular event. Co-authored-by: NAaron Patterson <aaron.patterson@gmail.com>
-
由 George Claghorn 提交于
Bump RuboCop to 0.58.2
-
由 Eileen M. Uchitelle 提交于
Remove third party FIXME
-
- 26 7月, 2018 11 次提交
-
-
由 George Claghorn 提交于
AST Guide: install and migrate tasks needed in new app
-
由 Jasper Martin 提交于
Do nothing instead of raising an error when it’s called on an attached blob.
-
由 utilum 提交于
This line refers only to an upgrade situation, but same is need to setup AST in a new application. [ci skip]
-
由 Koichi ITO 提交于
## Summary RuboCop 0.58.2 was released. https://github.com/rubocop-hq/rubocop/releases/tag/v0.58.2 And rubocop-0-58 channel is available in Code Climate. https://github.com/codeclimate/codeclimate/releases/tag/v0.76.0 https://github.com/codeclimate/codeclimate/commit/38f21f0 In addition, the following changes are made in this PR. - Replace Custom cops with Rails cops - Add jaro_winkler gem to Gemfile.lock ### Replace Custom cops with Rails cops These are compatible replacements. - Replace `CustomCops/AssertNot` cop with `Rails/AssertNot` cop. - Replace `CustomCops/RefuteNot` cop with `Rails/RefuteMethods` cop. With this replacement, it was decided to use cop of RuboCop itself. It removes the code related to CustomCops accordingly. ### Add jaro_winkler gem to Gemfile.lock Since RuboCop 0.57.0 depends on jaro_winkler gem, it has been added to Gemfile.lock.
-
由 Ryuta Kamizono 提交于
Reference Active Storage instead of third-party libraries in guide [ci skip]
-
由 Paul McMahon 提交于
Paperclip has officially been deprecated, so we shouldn't mention it anymore. CarrierWave could still be referenced, as there are use cases where it currently makes more sense, but for simplicity, I thought removing the mention of third party libraries made sense. If we want to talk about them, listing "alternatives" within the Active Storage guide could make more sense.
-
由 Richard Schneeman 提交于
Turn on performance based cops
-
由 Alberto Almagro 提交于
This FIXME belongs to a code example that was imported from the internet. As we aren't going to do anything about it, I prefer to remove it so it stops from appearing on searches.
-
由 utilum 提交于
This has been around as far back as I can [see](https://github.com/rails/rails/blob/5137d03cc5b2a5f0820bdcf11b0fffe5bf461470/guides/source/testing.md). No need to specify the obvious. [ci skip]
-
由 George Claghorn 提交于
Update with_options.rb [ci skip]
-
由 Daniel Amireh 提交于
explicit mapping for enum accepts a Hash not an Array, plus the example is using `.keys` which also exists on hash
-
- 25 7月, 2018 2 次提交
-
-
由 Ryuta Kamizono 提交于
Follow up of #33358 for SQLite3.
-
由 Matthew Draper 提交于
Prefer rails command over bin/rails
-
- 24 7月, 2018 1 次提交
-
-
由 Eileen M. Uchitelle 提交于
Rails guides are now served over https
-