- 08 6月, 2014 5 次提交
-
-
由 Rafael Mendonça França 提交于
Remove dead branch when restoring ID within a transaction Conflicts: activerecord/lib/active_record/transactions.rb
-
由 Rafael Mendonça França 提交于
Move conditionals about freezing closer to the definition of `freeze`
-
由 Sean Griffin 提交于
Reduces the number of places that care about the internals of how we store and type cast attributes. We do not need to go through the dup/freeze dance, as you couldn't have saved a frozen new record anyway, and that is the only time we would end up modifying the frozen hash.
-
由 Sean Griffin 提交于
There is no way to have an instance of an Active Record model where `has_attribute?(self.class.primary_key)` returns false. The record is always initialized in such a way that `@raw_attributes` will have an id key with nil for the value.
-
由 Rafael Mendonça França 提交于
Remove duplicated `@raw_attributes.keys`
-
- 07 6月, 2014 32 次提交
-
-
由 Sean Griffin 提交于
Reduces the number of things outside of attribute methods that cares about the details of how we store and type cast attributes
-
由 Matthew Draper 提交于
Specify a time zone when testing TZ aware attributes
-
由 Sean Griffin 提交于
Millisecond inequality causes failures on Travis
-
由 Yves Senn 提交于
This is a follow up to #15556 @kuldeepaggarwal did submit this patch way back (#13624).
-
由 Yves Senn 提交于
Add array support when time zone aware attributes are enabled
-
由 Sean Griffin 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
This is a regression test for 29844dd.
-
由 Xavier Noria 提交于
We cannot cache keys because arrays are mutable. We rather want to cache the arrays. This behaviour is tailor-made for the usage pattern strongs params is designed for. In a forthcoming commit I am going to add a test that covers why we need to cache by value. Every strong params instance has a live span of a request, the cache goes away with the object. Since strong params have such a concrete intention, it would be interesting to see if there are actually any real-world use cases that are an actual leak, one that practically may matter. I am not convinced that the theoretical leak has any practical consequences, but if it can be shown there are, then I believe we should either get rid of the cache (which is an optimization), or else wipe it in the mutating API. This reverts commit e63be276.
-
由 Vijay Dev 提交于
-
由 Vijay Dev 提交于
-
由 Xavier Noria 提交于
Fix capitalization
-
由 Akshay Vishnoi 提交于
-
由 Arthur Nogueira Neves 提交于
remove rubyforge.org that was shut down [ci skip]
-
由 Matthew Draper 提交于
/cc @tenderlove
-
由 Rafael Mendonça França 提交于
Removed unused `klass` definitions from types
-
由 Sean Griffin 提交于
Only `Date` and `Time` are handled.
-
由 Aaron Patterson 提交于
-
由 Rafael Mendonça França 提交于
Remove composed_of special case from multi-parameter attributes
-
由 Rafael Mendonça França 提交于
Don't mess with `_before_type_cast` for numeric types
-
由 Sean Griffin 提交于
As we move towards removing the `klass` method from `column`, the else clause as it stands right now will become the only case.
-
由 Sean Griffin 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Rafael Mendonça França 提交于
This reverts commit be1db994, reversing changes made to 6680ee94. Reason: This changed a behavior where numeric attributes when receiving blank values didn't change its value.
-
由 Rafael Mendonça França 提交于
Don't mess with `_before_type_cast` for numeric types
-
由 Sean Griffin 提交于
-
由 Yves Senn 提交于
Restore I18n.locale to default after test.
-
由 Gaurav Sharma 提交于
-
由 Zuhao Wan 提交于
If i18n_with_controller_test.rb were to run first, the I18n.locale will be changed to :de, and the following tests in base_test.rb will fail: "subject gets default from I18n" “default subject can have interpolations” "translations are scoped properly" "implicit multipart with default locale"
-
由 Santiago Pastorino 提交于
Restore test deliveries properly in ActionMailer.
-
由 Zuhao Wan 提交于
`ActionMailer::Base.delivery_method` and `ActionMailer::Base.perform_deliveries` have leaked states. "delivery method can be customized per instance" and "delivery method can be customized in subclasses not changing the parent" in delivery_methods_test.rb will fail if test_helper_test.rb (in which TestHelperMailerTest is inherited from ActionMailer::TestCase) runs before it.
-
- 06 6月, 2014 3 次提交
-
-
由 Yves Senn 提交于
Add missing test cases for schema dumping defaults
-
由 Sean Griffin 提交于
-
由 Yves Senn 提交于
[ci skip]
-