- 01 8月, 2018 7 次提交
-
-
由 Ryuta Kamizono 提交于
This reverts commit d162188d, reversing changes made to 35767828. Reason: #24131 conflicts the #5153's default order contract, it means that existing apps would be broken by that change. We don't want to break existing apps without a deprecation cycle.
-
由 Ryuta Kamizono 提交于
-
由 Xavier Noria 提交于
Revert "Remove label 'work in progress' for AM and AV guides"
-
由 Xavier Noria 提交于
-
由 Richard Schneeman 提交于
Remove label 'work in progress' for AM and AV guides
-
由 Rafael França 提交于
Throw if ujs loaded twice
-
由 George Claghorn 提交于
Log the remote IP addr of clients behind a proxy
-
- 31 7月, 2018 18 次提交
-
-
由 Atul Bhosale 提交于
[Atul Bhosale, Victor Nawothnig]
-
由 Kazuhiro NISHIYAMA 提交于
I saw two posts of problem about ajax requesting twice on qiita. So I think detecting double loaded earlier make easy to find the problem. https://qiita.com/hot_study_man/items/56dc87ad734cfda68bb6 https://qiita.com/hisas/items/8399aec3a5377bf75017
-
由 Ryuta Kamizono 提交于
[ci skip]
-
由 Richard Schneeman 提交于
Raises exception when respond_to called multiple times in incompatible way
-
由 Ryuta Kamizono 提交于
Fix example in thread_mattr_accessor documentation [ci skip]
-
由 Fabian Mersch 提交于
-
由 Kasper Timm Hansen 提交于
[ci skip] Fix the outdated description for `find_each`.
-
由 Aditya Kapoor 提交于
-
由 Kasper Timm Hansen 提交于
[Docs] All links from README.md now served over https
-
由 Andrea Gómez 提交于
-
由 George Claghorn 提交于
-
由 Ryuta Kamizono 提交于
"active_support/core_ext/module/aliasing" is no longer used since #19434.
-
由 Ryuta Kamizono 提交于
Since 9ac7dd47, class level `update`, `destroy`, and `delete` were placed in the `Persistence` module as class methods. But `Relation#update` without passing ids which was introduced at #11898 is not a class method, and it was caused the extra scoping regression #33470. I moved the relation method back into the `Relation` to fix the regression. Fixes #33470.
-
由 Ryuta Kamizono 提交于
A regression in `deprecate_methods` was introduced in a982a42d:
-
由 Patrick Toomey 提交于
Nesting respond_to calls can lead to unexpected behavior, so it should be avoided. Currently, the first respond_to format match sets the content-type for the resulting response. But, if a nested respond_to occurs, it is possible to match on a different format. For example: respond_to do |outer_type| outer_type.js do respond_to do |inner_type| inner_type.html { render body: "HTML" } end end end Browsers will often include */* in their Accept headers. In the above example, such a request would result in the outer_type.js match setting the content- type of the response to text/javascript, while the inner_type.html match will cause the actual response to return "HTML". This change tries to minimize potential breakage by only raising an exception if the nested respond_to calls are in conflict with each other. So, something like the following example would not raise an exception: respond_to do |outer_type| outer_type.js do respond_to do |inner_type| inner_type.js { render body: "JS" } end end end While the above is nested, it doesn't affect the content-type of the response.
-
由 Edouard CHIN 提交于
- Refactoring alias_chain to Module#prepend broke the possibility to deprecate class methods since the module generated was prepended to the target's instance. A suggestion to fix this was to use `AS#redefine_method` which would solve the problem but with the cost of redefining directly the method. Decided to go with the same alias_chain implementation as before instead. - Fixes #33253
-
由 Kasper Timm Hansen 提交于
Chomp will work without checking for end of the string
-
由 George Claghorn 提交于
-
- 30 7月, 2018 7 次提交
-
-
由 Ryuta Kamizono 提交于
cpu_time and allocations are 0 when JRuby is used
-
由 Yasuo Honda 提交于
According to #33449 and #33468, cpu_time and allocations are 0 when JRuby is used. ```ruby $ ruby -v jruby 9.2.1.0-SNAPSHOT (2.5.0) 2018-07-27 13b2df5 Java HotSpot(TM) 64-Bit Server VM 25.181-b13 on 1.8.0_181-b13 [linux-x86_64] $ bundle exec ruby -w -Itest test/log_subscriber_test.rb -n test_event_attributes Run options: -n test_event_attributes --seed 6231 F Failure: SyncLogSubscriberTest#test_event_attributes [test/log_subscriber_test.rb:84]: Expected 0 to be > 0. rails test test/log_subscriber_test.rb:78 Finished in 0.018983s, 52.6791 runs/s, 105.3582 assertions/s. 1 runs, 2 assertions, 1 failures, 0 errors, 0 skips ```
-
由 George Claghorn 提交于
-
由 Rafael França 提交于
Only use CLOCK_PROCESS_CPUTIME_ID if it's defined
-
由 Bart de Water 提交于
It's not defined on JRuby and unlike monotonic time, concurrent-ruby doesn't have an cross-platform abstraction for this.
-
由 Bart de Water 提交于
-
由 Bart 提交于
The purpose of the module seems to quack like a string.
-
- 29 7月, 2018 8 次提交
-
-
由 Ryuta Kamizono 提交于
To make it easier to construct boundable predicate.
-
由 George Claghorn 提交于
PDFPreviewer became MuPDFPreviewer in 0b717c20. Previewers are simple enough that we can just provide a single example.
-
由 Ryuta Kamizono 提交于
The target object for counter cache is not always determined by the primary key value on the model. I'd like to extract `update_couters` onto the `Relation` for the internal use.
-
由 Ryuta Kamizono 提交于
Ruby 2.4 has native `Regexp#match?`. https://ruby-doc.org/core-2.4.0/Regexp.html#method-i-match-3F Related #32034.
-
由 Richard Schneeman 提交于
Enable regex cops
-
由 Bart de Water 提交于
-
由 Bart de Water 提交于
`5 =~ /\d/` returns nil, but Integer doesn't have a `match?` method.
-
由 Bart de Water 提交于
Rubocop warns about "Use String#end_with? instead of a regex match anchored to the end of the string", it doesn't seem aware of the $` special variable like Performance/RegexpMatch
-