- 25 3月, 2019 1 次提交
-
-
由 Guillermo Iguaran 提交于
-
- 24 3月, 2019 4 次提交
-
-
由 Ryuta Kamizono 提交于
Add `unknown` method to list of methods to write current log [ci skip]
-
由 Ryuta Kamizono 提交于
Add default `config.action_view.raise_on_missing_translations` [ci skip]
-
由 Yuji Yaginuma 提交于
Add `secret_key_base` when creating new credential file
-
由 soartec-lab 提交于
-
- 23 3月, 2019 18 次提交
-
-
由 George Claghorn 提交于
Assigning a has_one association for a persisted record saves the change immediately, so attempting to read a rich-text attribute on a persisted record without a corresponding ActionText::RichText would eagerly create one. Avoid assigning the rich text association to fix.
-
由 Xavier Noria 提交于
-
由 Ryuta Kamizono 提交于
Bugfix: Fix false autosave for has_one :through association
-
由 Richard Schneeman 提交于
[ci skip] Fixed CHANGELOG typo
-
由 Shailesh Kalamkar 提交于
-
由 John Hawthorn 提交于
This updates the comment to reflect how the secret key is generated since 4c743587 Fixes #35717
-
由 yuuji.yaginuma 提交于
Since `secret_key_base` is expected to be included in credential file, `secret_key_base` should be included even if re-create the file. This is the same behavior as creating a new app. When env is specified, it may be unnecessary, so I added it only when not specifying env.
-
由 Gannon McGibbon 提交于
Drop microseconds in job argument assertions
-
由 Gannon McGibbon 提交于
-
由 John Hawthorn 提交于
Update CHANGELOGs for 6.0.0.beta3 release
-
由 John Hawthorn 提交于
-
由 John Hawthorn 提交于
Fix AS CHANGELOG typo
-
由 Ali Ibrahim 提交于
-
由 Rafael França 提交于
Fix rails guides generation
-
由 Eileen M. Uchitelle 提交于
Update AS::Notifications::Instrumenter#instrument
-
由 Sergiy Kukunin 提交于
Fixes #35680 The problem occurred, when a `has one through` association contains a foreign key (it belongs to the intermediate association). For example, Comment belongs to Post, Post belongs to Author, and Author `has_one :first_comment, through: :first_post`. In this case, the value of the foreign key is comparing with the original record, and since they are likely different, the association is marked as changed. So it updates every time when the origin record updates.
-
由 localhostdotdev 提交于
Was getting `formats=': Invalid formats: "html"
-
由 Ali Ibrahim 提交于
-
- 22 3月, 2019 9 次提交
-
-
由 Ali Ibrahim 提交于
with change to ActiveSupport::Notifications::Instrumenter#instrument
-
由 Ali Ibrahim 提交于
* Update #instrument to make passing a block optional. This will let users leverage #instrument for messaging in addition to instrumentation.
-
由 Eileen M. Uchitelle 提交于
Add support for annotating queries generated by ActiveRecord::Relation with SQL comments
-
由 Rafael França 提交于
Prefer render template: over render file: in tests
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Matt Yoho 提交于
This patch has two main portions: 1. Add SQL comment support to Arel via Arel::Nodes::Comment. 2. Implement a Relation#annotate method on top of that. == Adding SQL comment support Adds a new Arel::Nodes::Comment node that represents an optional SQL comment and teachers the relevant visitors how to handle it. Comment nodes may be added to the basic CRUD statement nodes and set through any of the four (Select|Insert|Update|Delete)Manager objects. For example: manager = Arel::UpdateManager.new manager.table table manager.comment("annotation") manager.to_sql # UPDATE "users" /* annotation */ This new node type will be used by ActiveRecord::Relation to enable query annotation via SQL comments. == Implementing the Relation#annotate method Implements `ActiveRecord::Relation#annotate`, which accepts a comment string that will be appeneded to any queries generated by the relation. Some examples: relation = Post.where(id: 123).annotate("metadata string") relation.first # SELECT "posts".* FROM "posts" WHERE "posts"."id" = 123 # LIMIT 1 /* metadata string */ class Tag < ActiveRecord::Base scope :foo_annotated, -> { annotate("foo") } end Tag.foo_annotated.annotate("bar").first # SELECT "tags".* FROM "tags" LIMIT 1 /* foo */ /* bar */ Also wires up the plumbing so this works with `#update_all` and `#delete_all` as well. This feature is useful for instrumentation and general analysis of queries generated at runtime.
-
由 yuuji.yaginuma 提交于
Since https://github.com/puma/puma/pull/1700, the default host is correctly used. So `localhost` is used instead of `0.0.0.0`. As a result, the log output on restart is changed, and the restart test fails on Puma 3.12.1. https://travis-ci.org/rails/rails/jobs/509239592#L2303-L2305 Specify binding explicitly to avoid being affected by Puma changes.
-
由 John Hawthorn 提交于
Many tests were using `render file:`, but were only testing the behaviour of `render template:` (file: just allows more paths/ is less secure then template:). The reason for so many `render file:` is probably that they were the old default. This commit replaces `render file:` with `render template:` anywhere the test wasn't specifically interested in using `render file:`.
-
- 21 3月, 2019 6 次提交
-
-
由 soartec-lab 提交于
-
由 yuuji.yaginuma 提交于
* Show options as list. * Fix incorrect quoting.
-
由 Ryuta Kamizono 提交于
-
由 Gannon McGibbon 提交于
Document option forwarding in ActiveRecord::Base.attribute
-
由 Alan Wu 提交于
This has been supported for a while but we didn't have documentation for it.
-
由 Kasper Timm Hansen 提交于
Bulk Insert: Reuse indexes for unique_by
-
- 20 3月, 2019 2 次提交
-
-
由 Eileen M. Uchitelle 提交于
Validate types assigned to LookupContext#formats=
-
由 Kasper Timm Hansen 提交于
-