- 05 11月, 2015 13 次提交
-
-
由 Jerry D'Antonio 提交于
-
由 Yves Senn 提交于
This solves: ``` Expected /Completed 200 OK in [\d]ms/ to match "Completed 200 OK in 943ms". ```
-
由 Kasper Timm Hansen 提交于
Should use `public_file_server.enabled` instead. Clarified that static files will be served from the public directory, where it made sense. Also removed occurrence of the deprecated `static_cache_control`.
-
由 Kasper Timm Hansen 提交于
Forgot to do it in 748b2f9c, when deprecating `serve_static_files`.
-
由 Yves Senn 提交于
Since `bin/test` would define `Rails.root` before loading AM but `bundle exec rake` would define it after loading AM, this lead to the following test failure when using `bin/test`: ``` --- expected +++ actual @@ -1 +1 @@ -{:location=>"/var/folders/_r/9kh50y4j0vn7zgg2p65z1lcm0000gn/T/mails"} +{:location=>"/Users/senny/Projects/rails/actionmailer/tmp/mails"} ``` This patch ensures that `Rails.root` is defined when loading AM to achieve consistent test results.
-
由 Kasper Timm Hansen 提交于
Add enabled flag to the public file server settings.
-
由 Kasper Timm Hansen 提交于
The configuration for `config.static_cache_control`, and its replacement `config.public_file_server.headers` are implemented in Railties. People would configure this in environment files, which is Railties domain too.
-
由 Rafael França 提交于
document `try!` in ActiveSupport core ext guide
-
-
由 Rafael França 提交于
Don’t allow arbitrary data in back urls
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
Update docs/comments to use setup/teardown blocks vs. methods. [ci skip]
-
由 Ken Collins 提交于
* Remove super for setup block. Not needed.
-
- 04 11月, 2015 8 次提交
-
-
由 Andrew White 提交于
Columns are no longer stored in an attribute since b8a533d5. [ci skip]
-
由 Andrew White 提交于
-
由 Aaron Patterson 提交于
we can just reuse the parent process. We should figure out what files are commonly required among the test files and try to require them in the parent so that the require time cost is amortized across the processes.
-
由 Damien Burke 提交于
`link_to :back` creates a link to whatever was passed in via the referer header. If an attacker can alter the referer header, that would create a cross-site scripting vulnerability on every page that uses `link_to :back` This commit restricts the back URL to valid non-javascript URLs. https://github.com/rails/rails/issues/14444
-
由 Rafael Mendonça França 提交于
When a frame is an eval block without filename argument there is no absolute_path so the previous implementation would fail because `nil` doesn't responds to `start_with?`.
-
由 Ken Collins 提交于
As discussed in the minitest-spec-rails issue (http://git.io/vlHxx) Rails uses setup/teardown callbacks. Defining `setup` or `teardown` methods vs. blocks will yield inconsistent behavior in the callback chain.
-
由 Kasper Timm Hansen 提交于
As discussed in https://github.com/rails/rails/pull/19135#issuecomment-153385986. Replaces `serve_static_files` to unify the static options under the `public_file_server` wing. Deprecates `serve_static_files` accessors, but make them use the newer config internally.
-
由 Rafael Mendonça França 提交于
-
- 03 11月, 2015 7 次提交
-
-
由 Jeremy Daer 提交于
Deprecate exception#original_exception in favor of exception#cause
-
由 Yuki Nishijima 提交于
-
由 Andrew White 提交于
Add test_float_limits to mysql2
-
由 Andrew White 提交于
added missing instructions for `rack-cors`
-
由 Gaurav Sharma 提交于
`config.middleware.insert_before` changes require to restart the server Also added missing `.` at the EOL.
-
由 Aaron Patterson 提交于
-
- 02 11月, 2015 12 次提交
-
-
由 Andrew White 提交于
Make `db:migrate:status` to render `1_some.rb` format migrate files.
-
由 Andrew White 提交于
Fix test_database_created_by_root of mysql
-
由 Yves Senn 提交于
[ci skip] querying guide methods first and last: mentioning the influence of the default scope
-
由 yui-knk 提交于
`1_valid_people_have_last_names.rb` and `20150823202140_create_users.rb` are valid migration file name. But `1_valid_people_have_last_names.rb` is rendered as `********** NO FILE **********` when `rake db:migrate:status`. Fix to this bug, this commit includes * define some API private methdos and a Constant `match_to_migration_filename?`, `parse_migration_filename`, and `MigrationFilenameRegexp` * use these methods in `db:migrate:status` task Example: These files are in `db/migrate` * 1_valid_people_have_last_names.rb * 20150819202140_irreversible_migration.rb * 20150823202140_add_admin_flag_to_users.rb * 20150823202141_migration_tests.rb * 2_we_need_reminders.rb * 3_innocent_jointable.rb we can migrate all of them. Before ```shell $ bundle exec rake db:migrate:status ... Status Migration ID Migration Name -------------------------------------------------- up 001 ********** NO FILE ********** up 002 ********** NO FILE ********** up 003 ********** NO FILE ********** up 20150819202140 Irreversible migration up 20150823202140 Add admin flag to users up 20150823202141 Migration tests ``` After ```shell $ bundle exec rake db:migrate:status ... Status Migration ID Migration Name -------------------------------------------------- up 001 Valid people have last names up 002 We need reminders up 003 Innocent jointable up 20150819202140 Irreversible migration up 20150823202140 Add admin flag to users up 20150823202141 Migration tests ```
-
由 Andrew White 提交于
remove unnecessary `.sass-cache` from plugin's gitignore template
-
由 Andrew White 提交于
Define `sanitize_sql_for_order` for AR and use it inside `preprocess_…
-
由 Andrew White 提交于
Allow bigint with default nil for avoiding auto increment primary key
-
由 Ryuta Kamizono 提交于
Such as #10404, #18206.
-
由 Andrew White 提交于
Remove `DEFAULT_CHARSET` and `DEFAULT_COLLATION`
-
由 Ryuta Kamizono 提交于
This reverts commit f6ca7e4e. The default collation of utf8 in MySQL is the `utf8_general_ci`, and this should not be changed. This is because, the better collation in the all locales is not exists, optimal collation in own application is not known other than themselves. The `utf8_unicode_ci` is known as Japanese killer in Japan, there are serious impacts in search of Japanese. MySQL implements the `utf8_unicode_ci` according to the Unicode Collation Algorithm (UCA) described at http://www.unicode.org/reports/tr10/, but the `utf8_unicode_ci` have only partial support for the UCA, only primary level key comparison implemented (also known as L1 (Base characters) comparison). Because L1 (Base characters) comparison does not distinguish between the presence or absence of the accent, if distinction of the accent is important there is a serious impact (e.g. Japanese). Example: ``` > SHOW CREATE TABLE `dicts`\G *************************** 1. row *************************** Table: dicts Create Table: CREATE TABLE `dicts` ( `word` varchar(255) COLLATE utf8_unicode_ci DEFAULT NULL, `meaning` varchar(255) COLLATE utf8_unicode_ci DEFAULT NULL ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci 1 row in set (0.00 sec) > INSERT INTO `dicts` VALUES ('ハハ', 'mother'), ('パパ', 'father'); Query OK, 2 rows affected (0.00 sec) > SELECT * FROM `dicts` WHERE `word` = 'ハハ'; +--------+---------+ | word | meaning | +--------+---------+ | ハハ | mother | | パパ | father | +--------+---------+ 2 rows in set (0.00 sec) > CREATE UNIQUE INDEX `unique_index_word` ON `dicts`(`word`); ERROR 1062 (23000): Duplicate entry 'ハハ' for key 'unique_index_word' ``` We should omit the collation entirely rather than providing a default. Then the choice is the responsibility of the server and MySQL distribution.
-