- 03 1月, 2015 2 次提交
-
-
由 claudiob 提交于
This commit changes arguments and default value of CallbackChain's :terminator option. After this commit, Chains of callbacks defined **without** an explicit `:terminator` option will be halted as soon as a `before_` callback throws `:abort`. Chains of callbacks defined **with** a `:terminator` option will maintain their existing behavior of halting as soon as a `before_` callback matches the terminator's expectation. For instance, ActiveModel's callbacks will still halt the chain when a `before_` callback returns `false`.
-
由 Rafael Mendonça França 提交于
`MissingSourceFile` was just an alias to `LoadError` and was not being raised inside the framework.
-
- 01 1月, 2015 1 次提交
-
-
由 Robin Dupret 提交于
-
- 23 12月, 2014 1 次提交
-
-
由 Yves Senn 提交于
-
- 10 12月, 2014 1 次提交
-
-
由 Genadi Samokovarov 提交于
-
- 05 12月, 2014 1 次提交
-
-
由 claudiob 提交于
[ci skip] As confirmed by @lleger (the author of `verified`) [in this comment](https://github.com/rails/rails/pull/17727#issuecomment-65488743): > Actually, it no longer returns false explicitly (bc8cc56a), so I guess the CHANGELOG isn't totally accurate. It returns nil instead (but the functionality isn't practically different).
-
- 02 12月, 2014 1 次提交
-
-
由 Logan Leger 提交于
This commit adds a `#verified` method to `ActiveSupport::MessageVerifier` which will return either `false` when it encounters an error or the message. `#verify` continues to raise an `InvalidSignature` exception on error. This commit also adds a convenience boolean method on `MessageVerifier` as a way to check if a message is valid without performing the decoding.
-
- 29 11月, 2014 1 次提交
-
-
由 Rafael Mendonça França 提交于
We will support only Ruby >= 2.1. But right now we don't accept pull requests with syntax changes to drop support to Ruby 1.9.
-
- 11 11月, 2014 1 次提交
-
-
由 Xavier Noria 提交于
-
- 06 11月, 2014 1 次提交
-
-
由 Yves Senn 提交于
/cc @chancancode
-
- 28 10月, 2014 1 次提交
-
-
由 Pablo Herrero 提交于
-
- 26 10月, 2014 1 次提交
-
-
由 Pavel Pravosud 提交于
-
- 23 10月, 2014 1 次提交
-
-
由 Godfrey Chan 提交于
-
- 16 10月, 2014 1 次提交
-
-
由 Yves Senn 提交于
-
- 30 9月, 2014 1 次提交
-
-
由 Xavier Noria 提交于
References f92ac245.
-
- 19 9月, 2014 1 次提交
-
-
由 Agis- 提交于
Fixes #16956.
-
- 18 9月, 2014 2 次提交
-
-
由 Akshay Vishnoi 提交于
-
由 Akshay Vishnoi 提交于
1. spacing issues 2. spelling correction 3. grammar correction 4. Add missing docs
-
- 14 9月, 2014 1 次提交
-
-
由 Agis- 提交于
Closes #16392.
-
- 12 9月, 2014 1 次提交
-
-
由 Kostiantyn Kahanskyi 提交于
Otherwise this will lead to another error later on when generating a signature: TypeError (no implicit conversion of nil into String).
-
- 08 9月, 2014 1 次提交
-
-
由 Godfrey Chan 提交于
Goals: 1. Default to :random for newly generated applications 2. Default to :sorted for existing applications with a warning 3. Only show the warning once 4. Only show the warning if the app actually uses AS::TestCase Fixes #16769
-
- 06 9月, 2014 1 次提交
-
-
由 Matthew Draper 提交于
Fixes #8015, #9756. [Fred Wu & Matthew Draper]
-
- 05 9月, 2014 1 次提交
-
-
由 Agis- 提交于
https://github.com/rails/rails/commit/98b46bf5e201307cae56ee14bf41363a539779c5 did not properly handled out-of-range `:usec`s. Passing a `:usec` that's out of range now throws an `ArgumentError` as it should. Fixes #16759.
-
- 04 9月, 2014 1 次提交
-
-
由 Peter Jaros 提交于
-
- 02 9月, 2014 1 次提交
-
-
由 Yves Senn 提交于
-
- 30 8月, 2014 4 次提交
-
-
由 David Heinemeier Hansson 提交于
We tenderized the wrong method! Object#try already had the yield option, just needed some tenderloving instance_eval to fit the bill
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
-
- 25 8月, 2014 1 次提交
-
-
由 Robin Dupret 提交于
For the sake of backward-compatibility, we need to make #instance_of? return true for Fixnum. On the other hand, the method should still give true for ActiveSupport::Duration itself which was not the case before.
-
- 18 8月, 2014 2 次提交
-
-
由 Robin Dupret 提交于
Since Duration is extending from ProxyObject which extends itself from BasicObject, the Duration object doesn't respond to the #instance_of? method. Thus, the #method_missing hook get triggered, delegating the method to its `value` attribute. However, Rubinius' #eql? definition relies on #instance_of?, thus this will equal to true with a Fixnum (since its `value` attribute is a Fixnum) while it should not. The previous behavior was wrong anyway, no matter the implementation.
-
由 David Heinemeier Hansson 提交于
Fix rounding errors with #travel_to by resetting the usec on any passed time to zero, so we only travel with per-second precision, not anything deeper than that.
-
- 12 8月, 2014 2 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Akira Matsuda 提交于
-
- 07 8月, 2014 1 次提交
-
-
由 Rafael Mendonça França 提交于
Fixes #16406
-
- 05 8月, 2014 1 次提交
-
-
由 Carlos Antonio da Silva 提交于
-
- 02 8月, 2014 2 次提交
-
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
-
- 30 7月, 2014 1 次提交
-
-
由 Pavel Pravosud 提交于
-
- 29 7月, 2014 1 次提交
-
-
由 Godfrey Chan 提交于
`Time#as_json`, `Date#as_json` and `DateTime#as_json` incorrectly depends on a delegation that is set up in `active_support/json/encoding`. We cannot simply require that file in `core_ext/object/json` because it would cause a circular dependency problem (see #12203 for background). We should instead rely on AS's autoload to load that file for us on-demand. To trigger autoload correctly, we need to reference the `AS::JSON::Encoding` constant instead of using the delegated version. Fixes #16131.
-