1. 28 9月, 2017 1 次提交
  2. 30 8月, 2017 1 次提交
  3. 26 8月, 2017 1 次提交
  4. 22 8月, 2017 1 次提交
  5. 18 8月, 2017 1 次提交
    • C
      Do not generate default alt text in image tags · 9a74c7b9
      Cameron Cundiff 提交于
      - Auto-generating content from the filename of an image is not suitable
        alternative text; alt text that isn't fully considered can be
        distracting and fatiguing for screen readers users (blind, low vision,
        dyslexic people).
      - Setting a filename fallback short circuits screen reader default
        behavior and configuration for blank descriptions.
      - Setting poor defaults also creates false negatives for accessibility
        linting and testing software, that makes it harder to improve
        application accessibility.
      
      ***
      
      - After this change, if authors leave images without alt text, screen
        readers will fallback to default behavior for missing alt text.
      - Also with this change, Automated linting and testing tools will
        correctly generate warnings.
      
      [Fixes #30096]
      9a74c7b9
  6. 14 8月, 2017 1 次提交
    • Y
      Clear mail after test · 2f469dc3
      yuuji.yaginuma 提交于
      If clear it before the test, the mail of the last executed test will not
      be correctly cleared.
      
      Therefore, executing the test with seed below will result in an error.
      
      ```
      ./bin/test -w --seed 55480
      Run options: --seed 55480
      
      # Running:
      
      ...........................................................................................................................................................F
      
      Failure:
      MailDeliveryTest#test_does_not_increment_the_deliveries_collection_on_error [/home/yaginuma/program/rails/master_y_yagi/rails/actionmailer/test/delivery_methods_test.rb:221]:
      --- expected
      +++ actual
      @@ -1 +1 @@
      -[]
      +[#<Mail::Message:47011389364640, Multipart: false, Headers: <Date: Mon, 14 Aug 2017 07:48:40 +0900>, <From: test-sender@test.com>, <To: test-receiver@test.com>, <Message-ID: <5990d748ea5b2_29342ac1af8bcf40886f7@yaginuma.mail>>, <Subject: Test Subject>, <Mime-Version: 1.0>, <Content-Type: text/plain>, <Content-Transfer-Encoding: 7bit>>]
      
      bin/test test/delivery_methods_test.rb:216
      ```
      2f469dc3
  7. 06 8月, 2017 1 次提交
  8. 29 7月, 2017 1 次提交
  9. 23 7月, 2017 1 次提交
  10. 02 7月, 2017 1 次提交
  11. 01 7月, 2017 2 次提交
  12. 28 6月, 2017 1 次提交
  13. 20 6月, 2017 1 次提交
  14. 16 6月, 2017 2 次提交
  15. 15 6月, 2017 2 次提交
  16. 14 6月, 2017 1 次提交
  17. 03 6月, 2017 1 次提交
  18. 30 5月, 2017 1 次提交
  19. 23 5月, 2017 1 次提交
  20. 19 5月, 2017 1 次提交
  21. 07 5月, 2017 1 次提交
  22. 02 5月, 2017 1 次提交
    • P
      Add missing require in ActionMailer · eddbb62f
      Philipe Fatio 提交于
      Without this, Action Mailer doesn't work like it used to on version 4.
      The following snippet fails since version 5:
      
          > require 'action_mailer'
          > ActionMailer::Base
          NameError: uninitialized constant ActiveSupport::Rescuable
      eddbb62f
  23. 27 4月, 2017 1 次提交
  24. 07 4月, 2017 1 次提交
  25. 22 3月, 2017 1 次提交
  26. 15 3月, 2017 2 次提交
  27. 08 3月, 2017 1 次提交
  28. 02 3月, 2017 2 次提交
    • A
      Deprecate implicit coercion of `ActiveSupport::Duration` · 75924c45
      Andrew White 提交于
      Currently `ActiveSupport::Duration` implicitly converts to a seconds
      value when used in a calculation except for the explicit examples of
      addition and subtraction where the duration is the receiver, e.g:
      
          >> 2 * 1.day
          => 172800
      
      This results in lots of confusion especially when using durations
      with dates because adding/subtracting a value from a date treats
      integers as a day and not a second, e.g:
      
          >> Date.today
          => Wed, 01 Mar 2017
          >> Date.today + 2 * 1.day
          => Mon, 10 Apr 2490
      
      To fix this we're implementing `coerce` so that we can provide a
      deprecation warning with the intent of removing the implicit coercion
      in Rails 5.2, e.g:
      
          >> 2 * 1.day
          DEPRECATION WARNING: Implicit coercion of ActiveSupport::Duration
          to a Numeric is deprecated and will raise a TypeError in Rails 5.2.
          => 172800
      
      In Rails 5.2 it will raise `TypeError`, e.g:
      
          >> 2 * 1.day
          TypeError: ActiveSupport::Duration can't be coerced into Integer
      
      This is the same behavior as with other types in Ruby, e.g:
      
          >> 2 * "foo"
          TypeError: String can't be coerced into Integer
          >> "foo" * 2
          => "foofoo"
      
      As part of this deprecation add `*` and `/` methods to `AS::Duration`
      so that calculations that keep the duration as the receiver work
      correctly whether the final receiver is a `Date` or `Time`, e.g:
      
          >> Date.today
          => Wed, 01 Mar 2017
          >> Date.today + 1.day * 2
          => Fri, 03 Mar 2017
      
      Fixes #27457.
      75924c45
    • A
      Pass request params to ActionMailer::Preview · 8e6c6d85
      Alexey Zapparov 提交于
      8e6c6d85
  29. 24 2月, 2017 1 次提交
  30. 22 2月, 2017 1 次提交
  31. 07 2月, 2017 1 次提交
  32. 04 2月, 2017 1 次提交
  33. 31 1月, 2017 3 次提交