- 18 12月, 2019 40 次提交
-
-
由 Michael Grosser 提交于
also: - makes test dependencies obvious - makes tests runnable from within subfolders
-
由 Rafael França 提交于
Remove superfluous keep file
-
由 Vipul A M 提交于
Fix documentation indentation: [ci skip]
-
由 Edouard CHIN 提交于
- This was breaking the code highlight in the doc
-
由 Eugene Kenny 提交于
Api-docs validation defaults missing absence [ci skip]
-
由 Rafael Mendonça França 提交于
unify puma types and remove blocks
-
由 Richard 提交于
-
由 y-yagi 提交于
Address `Error: caskroom/cask was moved. Tap homebrew/cask-cask instead`
-
由 Yasuo Honda 提交于
This error message suggests using `tap homebrew/cask-cask`, actually it does not work, refer "FYI - `tap homebrew/cask-cask` cause this error:" below. * Without this change: ``` $ brew bundle Using homebrew/core Using homebrew/bundle Using homebrew/services Error: caskroom/cask was moved. Tap homebrew/cask-cask instead. Tapping caskroom/cask has failed! ``` * With this change: ``` $ brew bundle Using homebrew/core Using homebrew/bundle Using homebrew/services Tapping homebrew/cask Installing ffmpeg Installing memcached Installing mysql Installing postgresql Installing redis Installing yarn Password: Installing xquartz Installing mupdf Installing poppler Installing imagemagick Homebrew Bundle complete! 14 Brewfile dependencies now installed. $ ``` * FYI - `tap homebrew/cask-cask` cause this error: ``` $ brew bundle Using homebrew/core Using homebrew/bundle Using homebrew/services Username for 'https://github.com': yahonda Password for 'https://yahonda@github.com': ==> Tapping homebrew/cask-cask Cloning into '/usr/local/Homebrew/Library/Taps/homebrew/homebrew-cask-cask'... remote: Invalid username or password. fatal: Authentication failed for 'https://github.com/Homebrew/homebrew-cask-cask/' Error: Failure while executing; git clone https://github.com/Homebrew/homebrew-cask-cask /usr/local/Homebrew/Library/Taps/homebrew/homebrew-cask-cask --depth=1 exited with 128. Tapping homebrew/cask-cask has failed! ```
-
由 Ryuta Kamizono 提交于
Remove `:connection_id` in an internal instrument
-
由 yuuji.yaginuma 提交于
Without this, `Rails.application` returns `nil`. Ref: https://buildkite.com/rails/rails/builds/65683#e86ec58e-53a5-41be-8aeb-11c5705ee580/1042-1053
-
由 Ryuta Kamizono 提交于
Seems that is the reason not to work code highlight.
-
由 Ryuta Kamizono 提交于
This broke the markup.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Related #36456. I grepped the code base by `git grep -n 'connection_id: '` then I found extra `connection_id: object_id` which is added at #20818 but unused. Actually the `connection_id: object_id` is not a connection's object_id but a connection_handler's object_id, it is very confusing. Since the `:connection_id` in an internal instrument is not used, we can just remove the incorrect information.
-
由 Rafael Mendonça França 提交于
[Railties] Add config rake_eager_load
-
由 Rafael França 提交于
Update instructions in generated Postgresql database.yml.
-
由 Rafael Mendonça França 提交于
Delegate child session assertions to parent session
-
由 Petrik 提交于
Some code examples were missing the language used for code highlighting.
-
由 Petrik 提交于
-
由 Chris Seelus 提交于
-
由 Rafael França 提交于
Add backend API doc for action text [ci skip]
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Remove call to object_id
-
由 Rafael França 提交于
minor grammar fix
-
由 Rafael Mendonça França 提交于
Update documentation to explain the behavior of explicitly raising ActiveRecord::Rollback in a nested transaction [skip ci]
-
由 Rafael França 提交于
Add some examples for getting current_user
-
由 Rafael França 提交于
Remove `spring-watcher-listen` from default Gemfile
-
由 Rafael França 提交于
Reversible remove_columns
-
由 Rafael Mendonça França 提交于
Update The Rails Initialization Process page[ci skip]
-
由 Rafael França 提交于
Fix FrozenError on ActiveModel::Error clear and delete
-
由 Rafael Mendonça França 提交于
Update downloading section
-
由 Rafael França 提交于
Respect Content-Type header passed in head method
-
由 Eileen M. Uchitelle 提交于
Move `name` key on configuration hash into `DatabaseConfig`
-
由 Rafael França 提交于
Update .yardopts to document *.rb files in [GEM]/app
-
由 John Crepezzi 提交于
`name` is used by Rails to find the configuration by connection specification name, but database adapters don't need to use `name` in order to establish a connection. This is part of our work to separate what the database needs to connect (the configuration hash) and the what Rails needs to find connections (everything else). Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
-
由 Rafael França 提交于
Also close PRs with no activity over 3 months
-
由 Rafael França 提交于
Make `belongs_to_required_by_default` a class attribute:
-
由 Cliff Pruitt 提交于
* Add failing ActiveJob exceptions test for "disable retry jitter" Thanks to @kaspth for the starting point. * Update ActiveJob retry jitter to correctly use zero value * Simplify "disable retry jitter" test We don't need to repeat this many times. Fewer is shorter. * Refactor determine_delay with jitter * Fix indentation * Close the curtains and give JITTER_DEFAULT some privacy * Use .zero? instead of == to check jitter value * Add ActiveJob test for explicit zero jitter Co-authored-by: NKasper Timm Hansen <hey@kaspth.com> Co-authored-by: NCliff Pruitt <cliff.pruitt@cliffpruitt.com>
-
由 Edouard CHIN 提交于
- I'm hoping to get this change accepted even though this flag was introduced years ago in 6576f735 My use case is the following: We were never enforcing belongs to association and we have a lot of models that implicitely declare an association as optional. We are now changing all our models to make associations required by default. Since we have a lot of models (more than 1000), I'd like to progressively enable them to use the `belongs_to_required_by_default` flag. The problem is that this flag is a mattr_accessor and doesn't to be set per model. We basically need to modify all our models (which could take years) before being able to modify the global flag. I'd like to change this flag to a class_attribute to solve the issue.
-