- 17 12月, 2014 1 次提交
-
-
由 Jon Atack 提交于
After c2fe0938, which was reverted yesterday, there will likely be future PRs to address #17661. The test `actionview/test/template/capture_helper_test.rb #test_capture_returns_nil_if_the_returned_value_is_not_a_string` should have errored with c2fe0938, but it was rewritten in the PR to not raise. My guess is that it may have seemed irrelevant to the content_tag tests or already covered by them. This test provides additional protection by being in the content_tag test suite to explicitly raise a red flag in future cases. It foregoes some redundancy for safety — at least until #17661 is closed.
-
- 16 12月, 2014 39 次提交
-
-
由 Xavier Noria 提交于
Improve section in constant autoload guide
-
由 Rafael Mendonça França 提交于
Remove misleading test: around_action return false
-
由 Arthur Nogueira Neves 提交于
English fix [ci skip]
-
由 George Millo 提交于
-
由 Eileen M. Uchitelle 提交于
Improve grammar
-
由 Jon Atack 提交于
[skip ci]
-
由 Xavier Noria 提交于
Constant autoload grammar fix
-
由 Jon Atack 提交于
[skip ci]
-
由 Jon Atack 提交于
[skip ci]
-
由 Yves Senn 提交于
-
由 Abdelkader Boudih 提交于
[ci skip]
✂ blank lines between list items. -
由 Yves Senn 提交于
[ci skip] /cc @sgrif @zzak Conflicts: activerecord/CHANGELOG.md
-
由 Juanito Fatas 提交于
-
由 Xavier Noria 提交于
I think "What" is was fine, "The purpose of" assumes the reader knows such thing exists. "What is" is fine, and also matches the following "What is require_dependency".
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Zachary Scott 提交于
4.2.0", then they should have no problems hacking with Rails. [ci skip] If they do, then its a bug and it should be reported.
-
由 Zachary Scott 提交于
Improving tips about installation in the guides [ci skip]
-
由 Zachary Scott 提交于
-
https://github.com/jonatack/rails由 Zachary Scott 提交于
[ci skip] Conflicts: guides/source/constant_autoloading_and_reloading.md
-
由 Arthur Nogueira Neves 提交于
Counter cache Rails guides fix
-
由 Zachary Scott 提交于
-
由 Zachary Scott 提交于
Adding method chaining section on ActiveRecord querying guide [ci skip]
-
由 Zachary Scott 提交于
[ci skip]
-
由 Zachary Scott 提交于
Improve autoload_paths section [ci skip]
-
由 Steve Lounsbury 提交于
You need to specify the counter_cache option on the has_many side of the association when using a custom counter cache column. This is documented on the has_many association here: http://apidock.com/rails/ActiveRecord/Associations/ClassMethods/has_many [ci skip]
-
由 claudiob 提交于
When an `around_action` does not `yield`, then the corresponding action is *never* executed and the `after_` actions are *never* invoked. The value returned by the `around_action` does not have any impact on this: an `around_action` can "return" `true`, `false`, or `"pizza"`, but as long as `yield` is not invoked, the corresponding action and after callbacks are not executed. The test suite for `ActionController::Callbacks` currently includes separate tests to distinguish the cases in which a non-yielding `around_actions` returns `true` or `false`. In my opinion, having such tests is misleading, giving the impression that the returned value might have some sort of impact, while it does not. At least that's the impression I got when I read those tests. For completeness, the tests were introduced 7 years ago by @NZKoz in e80fabbb.
-
由 Abdelkader Boudih 提交于
Minor typos/fixes to autoloading guide
-
由 claudiob 提交于
@fxn Great job with the guide, I read it all! Yeah! Some paragraphs might be restructured, but I'll leave that to you since you are currently working on it. This commit only includes some minor typos and commas that in my opinion clarify the reading. [ci skip]
-
由 Santiago Pastorino 提交于
-
由 Santiago Pastorino 提交于
This reverts commit c2fe0938.
-
由 Godfrey Chan 提交于
Don't convert empty arrays to nils when deep munging params
-
由 Xavier Noria 提交于
-
由 Rafael Mendonça França 提交于
Dynamic finders already deprecated [ci skip]
-
由 Andrey Nering 提交于
-
由 Jon Atack 提交于
[skip ci] Follow-up to previous commit [skip ci] Fix previous merge [skip ci]
-
由 Jon Atack 提交于
[skip ci]
-
由 Rafael Mendonça França 提交于
fix a typo [ci skip]
-
由 Vijay Dev 提交于
-