- 02 10月, 2015 1 次提交
-
-
由 yui-knk 提交于
This explanation was change by https://github.com/rails/rails/commit/7a27de2b. This change reversed the including module (`ActiveModel::Serializers::JSON`) and the included module (`ActiveModel::Serialization`) by mistake.
-
- 29 9月, 2015 8 次提交
-
-
由 Rafael Mendonça França 提交于
Update docs for `formatted_offset`
-
由 Ronak Jangir 提交于
Output of `formatted_offset` is depends on input so it’s not always in +HH:MM format. Possible outputs are “+5:30”, “+530” or provided alternate UTC string [ci skip]
-
由 Aaron Patterson 提交于
the caller of `handle_conditional_get!` checks the committed state of the response, so we don't need to in the subclass.
-
由 Sean Griffin 提交于
I'm looking to move towards a tree-like structure for dirty checking that involves an attribute holding onto the attribute that it was created from. This means that `changed?` can be fully encapsulated on that object. Since the objects are immutable, in `changes_applied`, we can simply perform a shallow dup, instead of a deep one. I'm not sure if that will actually end up in a performance boost, but I'd like to semantically separate these concepts regardless
-
由 Sean Griffin 提交于
The external uses of this method have been removed, and I'd like to internally re-use that name, as I'm planning to encapsulate `changed?` into the attribute object itself.
-
由 Rafael Mendonça França 提交于
no more class methods for JoinDependency [ci skip]
-
由 Gaurav Sharma 提交于
`ActiveRecord::Associations::JoinDependency` now it’s own class` and `ActiveRecord::Associations::ThroughAssociationScope` doesn’t exists
-
由 Rafael Mendonça França 提交于
Updated docs for transform_keys & transform_values
-
- 28 9月, 2015 13 次提交
-
-
由 Sean Griffin 提交于
We're calling this function on an empty hash as part of copying the attribute set during dirty checking initialization. The new structure caused a performance regression on loading records from the database. This causes `User.all.to_a` to perform about 10% faster w/ 10k records. Calculating ------------------------------------- User.all - master 9.000 i/100ms User.all - sg-fix-ar-regression 8.000 i/100ms ------------------------------------------------- User.all - master 81.236 (± 7.4%) i/s - 405.000 User.all - sg-fix-ar-regression 89.716 (± 7.8%) i/s - 448.000
-
由 Ronak Jangir 提交于
-
由 Kasper Timm Hansen 提交于
Make fuzzy sentence more clear
-
由 David Verhasselt 提交于
[ci skip]
-
由 Kasper Timm Hansen 提交于
check if @rake_patterns is defined
-
由 yuuji.yaginuma 提交于
This removes the following warning. ``` railties/lib/rails/test_unit/minitest_plugin.rb:45: warning: instance variable @rake_patterns not initialize ```
-
由 Ronak Jangir 提交于
-
由 Arthur Nogueira Neves 提交于
Fix minor docs [ci skip]
-
由 Rafael Mendonça França 提交于
Fix `ActiveRecord::RecordNotFound` error message with custom primary …
-
由 Rafael Mendonça França 提交于
[ci skip] Update docs of `AR::Sanitization`
-
由 amitkumarsuroliya 提交于
-
由 Rafael Mendonça França 提交于
[ci skip] Fix which method `FormHelper#date_field` try to call
-
由 Sean Griffin 提交于
minor doc fix [ci skip]
-
- 27 9月, 2015 14 次提交
-
-
由 eileencodes 提交于
Here `app` needed to be `get` because we're getting a route. This fixes the typo so the test passes.
-
由 Eileen M. Uchitelle 提交于
Add missing routing tests for info controller
-
由 yui-knk 提交于
When this method was implemented (https://github.com/rails/rails/pull/5016/files), `to_date` is called. But this behavior was chagned refactoring (https://github.com/rails/rails/pull/6452/files). In the first commit, there were not test which asserts `to_date` is called. I think trying `to_date` is more useful than trying `strftime`, because we can write `"2015-01-01".to_date`. But first fix comments to match actual behavior.
-
由 Kasper Timm Hansen 提交于
Added test case for deprecation of Mime.const_defined? and removed use of it
-
由 Xavier Noria 提交于
Fix proper fonts in `change_column_null` method docs. [ci skip]
-
由 amitkumarsuroliya 提交于
-
由 Ronak Jangir 提交于
-
由 Aditya Kapoor 提交于
Vaguely related to #21605 where I proposed to remove index route since it was redirecting to the 'routes' action, but this was kept so I thought it made sense to add some tests regarding this.
-
由 Godfrey Chan 提交于
[ci skip] Add `Active Model` to a list of independently used modules.
-
由 Mehmet Emin İNAÇ 提交于
-
由 yui-knk 提交于
-
由 Kasper Timm Hansen 提交于
Added test cases where collection partial cached & rendered with different keys
-
由 eileencodes 提交于
`inverse_of` on through associations was accidently removed/caused to stop working in commit f8d2899d which was part of a refactoring on `ThroughReflection`. To fix we moved `inverse_of` and `check_validity_of_inverse!` to the `AbstractReflection` so it's available to the `ThroughReflection` without having to dup any methods. We then need to delegate `inverse_name` method in `ThroughReflection`. `inverse_name` can't be moved to `AbstractReflection` without moving methods that set the instance variable `@automatic_inverse_of`. This adds a test that ensures that `inverse_of` on a `ThroughReflection` returns the correct class name, and the correct record for the inverse relationship. Fixes #21692
-
由 amitkumarsuroliya 提交于
-
- 26 9月, 2015 4 次提交
-
-
由 Ronak Jangir 提交于
-
由 Claudio B. 提交于
Fix typo in configuration test descritive > descriptive [ci skip]
-
由 yui-knk 提交于
* add % style prepared statement and string examples for `sanitize_sql_for_conditions` * add array and string examples for `sanitize_sql_for_assignment` * add examples for `sanitize_sql_like` * add % style prepared statement example for `sanitize_sql_array` * align spaces of exampl code
-
由 amitkumarsuroliya 提交于
-