- 05 9月, 2014 20 次提交
-
-
由 Abdelkader Boudih 提交于
-
由 Godfrey Chan 提交于
This is cased by 03118bc5 + 9b5d603c. The first commit referenced the undefined local variable `column` when it should be using `reflection.type` as the lookup key. The second commit changed `build_arel` to not modify the `bind_values` in- place so we need to combine the arel's `bind_values` with the relation's when building the SQL. Fixes #16591 Related #15821 / #15892 / 7aeca506
-
由 Yves Senn 提交于
Move variable assignment within logging block.
-
由 Andrew White 提交于
Time#change throws exception with an out-of-range :usec
-
由 Zachary Scott 提交于
Fix ActiveJob rdoc `enqueue` -> `perform_later` [ci skip]
-
由 Abdelkader Boudih 提交于
-
由 Guillermo Iguaran 提交于
Cover all cases of `For not` --> `Do not`, related to #16804
-
由 Akshay Vishnoi 提交于
-
由 Guo Xiang Tan 提交于
-
由 David Heinemeier Hansson 提交于
Active Job partial refactor
-
由 Akira Matsuda 提交于
-
由 Aaron Patterson 提交于
Skip StatementCache for eager loaded associations
-
由 Aaron Patterson 提交于
-
由 Zachary Scott 提交于
-
由 Zachary Scott 提交于
Document that method objects are not `duplicable?` [ci skip]
-
由 Rafael Mendonça França 提交于
Change "For not..." to "Do not...".
-
由 Kale Worsley 提交于
-
由 Agis- 提交于
https://github.com/rails/rails/commit/98b46bf5e201307cae56ee14bf41363a539779c5 did not properly handled out-of-range `:usec`s. Passing a `:usec` that's out of range now throws an `ArgumentError` as it should. Fixes #16759.
-
由 Peter Jaros 提交于
-
由 Rafael Mendonça França 提交于
This documentation should be in the guides. Closes #16691
-
- 04 9月, 2014 20 次提交
-
-
由 Sammy Larbi 提交于
Eagerly loaded collection and singular associations are ignored by the StatementCache, which causes errors when the queries they generate reference columns that were not eagerly loaded. This commit skips the creation of the StatementCache as a fix for these scenarios.
-
由 Rafael Mendonça França 提交于
Merge pull request #16801 from eileencodes/refactor-scope_chain-on-through-refelction-to-eliminate-branch-in-eval_scope Always add lambda to scope chain to eliminate branch in eval_scope
-
由 Matthew Draper 提交于
-
由 eileencodes 提交于
We convert all other scopes to lambda's so it makes sense that we should always returns a lambda on a ThroughReflection as well. This eliminates the need to check if the scope is a Relation.
-
由 Matthew Draper 提交于
Followup to PR #16762
-
由 eileencodes 提交于
Remove chain from parameters, it's no longer needed since chain and i are being passed via next_reflection Change name of `reflection` to `owner_reflection` because of shadow variable warning. The last reflection will always be the owner.
-
由 Yves Senn 提交于
[ci skip] Fix typo in rails guide for routing
-
由 Godfrey Chan 提交于
Added a few more methods on Module/Class to the dangerous class methods blacklist. (Technically, allocate and new are already protected currently because we happen to redefine them in the current implantation.) Closes #16792
-
由 Yves Senn 提交于
Warning looked like this: ``` /Users/senny/Projects/rails/activerecord/lib/active_record/associations/association_scope.rb:142: warning: shadowing outer local variable - reflection ```
-
由 Richard Ramsden 提交于
-
由 Cristian Bica 提交于
-
由 Xavier Noria 提交于
* Renames _handle_render_options to _render_to_body_with_renderer, which is more intention-revealing. * The name of the dynamically generated method for a renderer with key :js was "_render_option_js". That name is too weak. :js is an option if you see the render argument as just a generic options hash, but in the context of renderers that's the renderer key, is what identifies the renderer. Now "_render_with_renderer_js" is generated instead, which is crystal clear. * The name of the dynamically generated method for the renderer was constructed using string literals in a few places. That is now encapsulated in a method. * Since we were on it, also removed a couple of redundant selfs.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Add support for ARIA attributes in tags
-
由 PaoMar 提交于
-
由 Rafael Mendonça França 提交于
Methods are not duplicable.
-
由 Peter Jaros 提交于
-
由 Matthew Draper 提交于
[Active Job] Try to deserialize with GlobalID only strings and globalids
-
由 Cristian Bica 提交于
-