- 04 5月, 2014 1 次提交
-
-
由 Guo Xiang 提交于
-
- 18 4月, 2014 2 次提交
-
-
由 Rafael Mendonça França 提交于
Related with cbb91745
-
由 Rafael Mendonça França 提交于
This was changed at cbb91745
-
- 15 4月, 2014 1 次提交
-
-
由 Rafael Mendonça França 提交于
When requesting a controller with the following code with a unknown format: def my_action respond_to do |format| format.json { head :ok } format.any { render text: 'Default response' } end end we should render the default response instead of raising ActionController::UnknownFormat Fixes #14462 Conflicts: actionpack/CHANGELOG.md actionpack/test/controller/mime/respond_with_test.rb Conflicts: actionpack/CHANGELOG.md
-
- 14 4月, 2014 1 次提交
-
-
由 Marcus Stollsteimer 提交于
-
- 07 4月, 2014 2 次提交
-
-
由 Vipul A M 提交于
-
由 Guo Xiang Tan 提交于
Adding flash types to a controller within any of the tests will result in a global state change of the controller under test. This patch will prevent state leaks and allow us to run the test in random order.
-
- 22 3月, 2014 1 次提交
-
-
由 David Heinemeier Hansson 提交于
-
- 15 3月, 2014 1 次提交
-
-
由 Kevin Casey 提交于
update the tests, using an if-else
-
- 14 3月, 2014 1 次提交
-
-
由 Łukasz Strzałkowski 提交于
We're setting variant above, in request object directly
-
- 13 3月, 2014 2 次提交
-
-
由 Aaron Patterson 提交于
avoid freezing the headers until the web server has actually read data from the body proxy. Once the webserver has read data, then we should throw an error if someone tries to set a header
-
由 Aaron Patterson 提交于
when streaming responses, we need to make sure the cookie jar is written to the headers before returning up the stack. This commit introduces a new method on the response object that writes the cookie jar to the headers as the response is committed. The middleware and test framework will not write the cookie headers if the response has already been committed. fixes #14352
-
- 09 3月, 2014 1 次提交
-
-
由 Piotr Chmolowski 提交于
Related to: #14242 #14243 14293 Variants passed to LookupContext#find() seem to be ignored, so I've used the setter instead: `finder.variants = [ variant ]`. I've also added some more test cases for variants. Hopefully this time passing tests will mean it actually works.
-
- 05 3月, 2014 2 次提交
-
-
由 Prem Sichanugrist 提交于
`render :body` should just not set the `Content-Type` header. By removing the header, it breaks the compatibility with other parts. After this commit, `render :body` will returns `text/html` content type, sets by default from `ActionDispatch::Response`, and it will preserve the overridden content type if you override it. Fixes #14197, #14238 This partially reverts commit 30473768.
-
由 John Barton (joho) 提交于
Added the log_warning_on_csrf_failure option to ActionController::RequestForgeryProtection which is on by default.
-
- 04 3月, 2014 1 次提交
-
-
由 Piotr Chmolowski 提交于
Take variants into account when calculating template digests in ActionView::Digest. Digestor#digest now takes a hash as an argument to support variants and allow more flexibility in the future. Old-style arguments have been deprecated. Fixes #14242
-
- 01 3月, 2014 4 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
when an exception happens in an action before the response has been committed, then we should re-raise the exception in the main thread. This lets us reuse the existing exception handling.
-
由 Aaron Patterson 提交于
detect the type of controller we're testing and return the right type of response based on that controller. This allows us to stop doing the weird sleep thing.
-
由 Aaron Patterson 提交于
-
- 27 2月, 2014 1 次提交
-
-
由 Tony Wooster 提交于
Commit 4f2cd3e9 introduced a bug by reordering the call to `@controller.recycle!` above the call to `build_request_uri`. The impact of this was that the `@_url_options` cache ends up not being reset between building a request URI (occurring within the test controller) and the firing of the actual request. We encountered this bug because we had the following setup: class MinimumReproducibleController < ActionController::Base before_filter { @param = 'param' } def index render text: url_for(params) end def default_url_options { custom_opt: @param } end end def test_index get :index # builds url, then fires actual request end The first step in `get :index` in the test suite would populate the @_url_options cache. The subsequent call to `url_for` inside of the controller action would then utilize the uncleared cache, thus never calling the now-updated default_url_options. This commit fixes this bug calling recycle! twice, and removes a call to set response_body, which should no longer be needed since we're recycling the request object explicitly.
-
- 24 2月, 2014 1 次提交
-
-
由 Serj L 提交于
Simple Sungularize ActionController::UnpermittedParameters error in case when only 1 parameter is unpermitted.
-
- 19 2月, 2014 4 次提交
-
-
由 Prem Sichanugrist 提交于
This is an option for to HTML content with a content type of `text/html`. This rendering option calls `ERB::Util.html_escape` internally to escape unsafe HTML string, so you will have to mark your string as html safe if you have any HTML tag in it. Please see #12374 for more detail.
-
由 Prem Sichanugrist 提交于
This is as an option to render content with a content type of `text/plain`. This is the preferred option if you are planning to render a plain text content. Please see #12374 for more detail.
-
由 Prem Sichanugrist 提交于
-
由 Prem Sichanugrist 提交于
This is an option for sending a raw content back to browser. Note that this rendering option will unset the default content type and does not include "Content-Type" header back in the response. You should only use this option if you are expecting the "Content-Type" header to not be set. More information on "Content-Type" header can be found on RFC 2616, section 7.2.1. Please see #12374 for more detail.
-
- 16 2月, 2014 1 次提交
-
-
由 Kevin Casey 提交于
if the controller action has not yet streamed any data, actions should process as normal, and errors should trigger the appropriate behavior (500, or in the case of ActionController::BadRequest, a 400 Bad Request)
-
- 14 2月, 2014 1 次提交
-
-
由 David Heinemeier Hansson 提交于
No variant should also be picked up by variant.any if variant.none is not defined (just like any other variant)
-
- 13 2月, 2014 1 次提交
-
-
由 Lukasz Strzalkowski 提交于
Allow setting `request.variant` as an array - an order in which they will be rendered. For example: request.variant = [:tablet, :phone] respond_to do |format| format.html.none format.html.phone # this gets rendered end
-
- 11 2月, 2014 2 次提交
-
-
由 Godfrey Chan 提交于
-
由 Guillermo Iguaran 提交于
-
- 09 2月, 2014 1 次提交
-
-
由 Zachary Scott 提交于
-
- 07 2月, 2014 1 次提交
-
-
由 Ionatan Wiznia 提交于
-
- 31 1月, 2014 1 次提交
-
-
由 Josh Jordan 提交于
-
- 27 1月, 2014 1 次提交
-
-
由 Andrew White 提交于
The request attributes filtered_parameters, filtered_env and filtered_path are memoized for performance reasons. However this can cause unusual behavior in tests where there are multiple calls to get, post, etc. Fixes #13803.
-
- 25 1月, 2014 1 次提交
-
-
由 Francesco Rodriguez 提交于
-
- 24 1月, 2014 1 次提交
-
-
由 Arthur Neves 提交于
-
- 27 12月, 2013 1 次提交
-
-
由 Łukasz Strzałkowski 提交于
Like `format.any`, you can do the same with variants. It works for both inline: respond_to do |format| format.html.any { render text: "any" } format.html.phone { render text: "phone" } end and block syntax: respond_to do |format| format.html do |variant| variant.any(:tablet, :phablet){ render text: "any" } variant.phone { render text: "phone" } end end
-
- 25 12月, 2013 1 次提交
-
-
由 Akira Matsuda 提交于
-
- 24 12月, 2013 1 次提交
-
-
由 Xavier Noria 提交于
-