1. 15 5月, 2014 1 次提交
    • N
      Make filter_binds filter out symbols that are equal to strings · 1d316ac1
      Nat Budin 提交于
      ActiveRecord::Relation::Merger's filter_binds method does not filter out bind
      variables when one of the attribute nodes has a string name, but the other has
      a symbol name, even when those names are actually equal.
      
      This can result in there being more bind variables than placeholders in the
      generated SQL.  This is particularly an issue for PostgreSQL, where this is
      treated as an error.
      
      This patch changes the filter_binds method to make it convert both attribute
      names to strings before comparing.
      1d316ac1
  2. 12 5月, 2014 6 次提交
  3. 10 5月, 2014 4 次提交
  4. 09 5月, 2014 1 次提交
  5. 08 5月, 2014 4 次提交
  6. 07 5月, 2014 1 次提交
  7. 06 5月, 2014 1 次提交
  8. 05 5月, 2014 2 次提交
  9. 04 5月, 2014 2 次提交
  10. 03 5月, 2014 5 次提交
  11. 02 5月, 2014 1 次提交
  12. 01 5月, 2014 2 次提交
  13. 29 4月, 2014 3 次提交
    • E
      add test to check that loaded and non laoded are the same · 748daa39
      eileencodes 提交于
      Test checks that SQL is the same for a loaded vs not loaded
      association (category.categorizations, category.categorization.delete_all
      vs category.cartegroization.delete_al). This was fixed for delete_all
      dependency but was not fixed for no (:nullify, or nil) dependency).
      748daa39
    • E
      clear shouldnt fire callbacks so remove order test · 96f90b51
      eileencodes 提交于
      Since clear shouldn't fire callbacks the order doesn't
      matter since it was never updated. Remove the portion
      of this test that tests for order after clear.
      96f90b51
    • E
      rewrite test to correctly test clear method · a0401aa2
      eileencodes 提交于
      Clear should not call callbacks because it clear calls
      delete_all and then returns self. It should behave the same
      as delete_all. This test clarifies the goal of the test and
      tests the correct outcome.
      a0401aa2
  14. 26 4月, 2014 1 次提交
    • K
      Fix custom join_table name on habtm reflections · 18fa87b8
      Kassio Borges 提交于
      When used a custom join_table name on a habtm, rails was not saving it
      on Reflections. This causes a problem when rails loads fixtures, because
      it uses the reflections to set database with fixtures.
      18fa87b8
  15. 25 4月, 2014 2 次提交
  16. 24 4月, 2014 1 次提交
  17. 23 4月, 2014 2 次提交
  18. 22 4月, 2014 1 次提交