We can't assign @view_context_class here, define super() in test instead if we want to avoid warnings.

Avoid (@_var ||= nil) pattern by using initialize methods and ensuring everyone calls super as expected.

Move ActionController::Railties::RoutesHelpers and ActionMailer::Railties::RoutesHelper to AbstractController::Railties::RoutesHelpers

mounted_helpers are a bit similar to url_helpers. They're automatically
included in controllers for Rails.application and each of mounted
Engines. Mounted helper allows to call url_for and named helpers for
given application.

Given Blog::Engine mounted as blog_engine, there are 2 helpers defined:
app and blog_engine. You can call routes for app and engine using those
helpers:

app.root_url
app.url_for(:controller => "foo")
blog_engine.posts_path
blog_engine.url_for(@post)

Ensure that inherited helper_methods are available after calling clear_helpers [#5348 state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Add clear_helpers as a way to clean up all helpers added to this controller, maintaing just the helper with the same name as the controller.

Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Move config_accessor :asset_host from ActionController::Base to AbstractController which fixes issues with asset_host in ActionMailer

Including:
  - Moved mailer objects in separate directory
  - Added two tests for asset_host configuration option

Signed-off-by: NJosé Valim <jose.valim@gmail.com>

The error page shown when the method you are requesting on a controller
doesn't specify which controller the method is missing from
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

If you are setting a hash or an array in class_attribute or you need
to freeze it, to ensure people won't modify it in place or you need
to dup it on inheritance.

Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Clean up the config object in ActionPack. Create config_accessor which just delegates to the config object, reducing the number of deprecations and add specific tests.

Revert "protected instance variables added to the deprecated config accessor

This reverts commit 4bce5ba6 and 0ee2d3c8.

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Each controller class has it's own view context subclass. This removes the need for ActionView::Base.for_controller