1. 13 5月, 2020 1 次提交
    • J
      Avoid confliting Kernel-named scopes on Relation · 1b773bca
      John Hawthorn 提交于
      A previous change made singleton methods eagerly define their relation
      methods if it shared a name with a method on Kernel. This caused issues
      with a few methods which were both defined on Kernel and on
      AcitveRecord::Relation.
      
      This commit avoids defining the method if it exists on AR::Relation.
      1b773bca
  2. 12 5月, 2020 1 次提交
  3. 11 5月, 2020 1 次提交
    • Y
      Address `InnerJoinAssociationTest#test_eager_load_with_string_joins` failure with mysql2 · 950a453d
      Yasuo Honda 提交于
      `ReadOnlyTest#test_field_named_field` performs implicit commit the transaction by `ReadOnlyTest#setup`
      because of the MySQL database behavior.
      
      This commit addresses the failure at https://buildkite.com/rails/rails/builds/68962#68213887-1cef-4f76-9c95-aebc8799c806
      Here are minimum steps to reproduce:
      
      ```ruby
      % ARCONN=mysql2 bin/test test/cases/readonly_test.rb test/cases/dirty_test.rb test/cases/associations/inner_join_association_test.rb \
      -n "/^(?:ReadOnlyTest#(?:test_has_many_with_through_is_not_implicitly_marked_readonly)|DirtyTest#(?:test_field_named_field)|InnerJoinAssociationTest#(?:test_eager_load_with_string_joins))$/" --seed 50855
      Using mysql2
      Run options: -n "/^(?:ReadOnlyTest#(?:test_has_many_with_through_is_not_implicitly_marked_readonly)|DirtyTest#(?:test_field_named_field)|InnerJoinAssociationTest#(?:test_eager_load_with_string_joins))$/" --seed 50855
      
      ..F
      
      Failure:
      InnerJoinAssociationTest#test_eager_load_with_string_joins [/Users/yahonda/src/github.com/rails/rails/activerecord/test/cases/associations/inner_join_association_test.rb:87]:
      Expected: 3
        Actual: 4
      
      bin/test test/cases/associations/inner_join_association_test.rb:82
      
      Finished in 0.114674s, 26.1611 runs/s, 26.1611 assertions/s.
      3 runs, 3 assertions, 1 failures, 0 errors, 0 skips
      ```
      
      References:
      - "13.3.3 Statements That Cause an Implicit Commit"
      https://dev.mysql.com/doc/refman/8.0/en/implicit-commit.html
      950a453d
  4. 10 5月, 2020 9 次提交
  5. 09 5月, 2020 3 次提交
  6. 08 5月, 2020 1 次提交
  7. 07 5月, 2020 5 次提交
  8. 06 5月, 2020 8 次提交
  9. 05 5月, 2020 8 次提交
  10. 04 5月, 2020 2 次提交
  11. 03 5月, 2020 1 次提交