- 05 8月, 2019 5 次提交
-
-
由 Lachlan Sylvester 提交于
-
由 Guilherme Mansur 提交于
-
由 Guilherme Mansur 提交于
Added the ability to initialize `thread_mattr_*` methods with default values like so: ``` ruby class MyClass thread_attr_reader :foo, default: :foo thread_attr_writer :bar, default: :bar thread_attr_accessor: baz do "baz" end end ``` This is consistent with the api exposed by `mattr_accessor`.
-
由 Prathamesh Sonpatki 提交于
-
由 Eileen M. Uchitelle 提交于
Fix `PG::ConnectionBad` error when running fixtures
-
- 04 8月, 2019 7 次提交
-
-
由 Kasper Timm Hansen 提交于
Use media_type instead of content_type internally
-
由 Kasper Timm Hansen 提交于
-
由 Eugene Kenny 提交于
These calls to `content_type` were triggering the deprecation from c631e8d0 in upgraded applications. We can use `media_type` in all of these cases to avoid the deprecation.
-
由 Kasper Timm Hansen 提交于
Didn't like the complicated stuff that happened on credentials:edit. It would append to .gitattributes multiple times. Though I see why it was written that way. I'm cutting off for now, but since this new flow would require each developer to run --enable perhaps this should really be: 1. Developer enrolls Rails app by running `credentials:diff --enable` 2. credentials:edit checks .gitattributes for `diff=rails_credentials` and if the current file is covered by that. 3. If so, set up the "rails_credentials" driver automatically.
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
Helpers is more for sharing between commands. Since `Diffing` is only for credentials we should just keep it only for credentials. Replaces "pretty" with diffing since the former is ambiguous, while diffing captures what it does. `opt_in` seemed clunky so it's swapped for the one-word enable.
-
- 03 8月, 2019 8 次提交
-
-
由 y-yagi 提交于
Address `DEPRECATED: Use assert_nil if expecting nil`
-
由 Yasuo Honda 提交于
```ruby $ cd activerecord $ bin/test test/cases/dirty_test.rb:494 ... snip ... DEPRECATED: Use assert_nil if expecting nil from /home/yahonda/git/rails/activerecord/test/cases/dirty_test.rb:494. This will fail in Minitest 6. DEPRECATED: Use assert_nil if expecting nil from /home/yahonda/git/rails/activerecord/test/cases/dirty_test.rb:511. This will fail in Minitest 6. . Finished in 0.061593s, 16.2356 runs/s, 795.5428 assertions/s. 1 runs, 49 assertions, 0 failures, 0 errors, 0 skips $ ``` Refer seattlerb/minitest#666 rails/rails#27712
-
由 Vipul A M 提交于
typo in word compatibily -> compatibility [ci skip]
-
由 Swapnil Gourshete 提交于
-
由 eileencodes 提交于
At first this appeared to be a multi-db bug but after some invesitgation it was clear that this can occur just by calling `establish_connection` from ApplicationRecord. After some investigation we found that this only occurred when using fixtures. The console boots fine, the server runs fine, and the tests even run fine if we used paralellization or eager loading in the tests. I tracked the issue down to the line that calls `self.connection_specification_name = name` in the SchemaMigration changes for Rails 6.0. But how can this be? That is not that major of a change? How could `connection_specification_name` be a problem? First `connection_specification_name` caches the name of the connection specificatio. Second, fixtures were incorrectly holding onto a reference to that connection. So when you went to run the tests the models wouldn't be connected and when the fixtures tried to load the data it would choke on that unconnected database. The changes here move the connection into a lambda so we can call it when we need it rather than blowing up before the model is connected. Fixes #36743 Co-authored-by: NAaron Patterson <aaron.patterson@gmail.com>
-
由 Rafael Mendonça França 提交于
Usually the application requires the entire active support at load time but the configuration happens before it is loaded. For that reason we need to require the core_ext that we want to use in this file.
-
由 Eileen M. Uchitelle 提交于
Add ability to unset preventing writes
-
由 eileencodes 提交于
Previously if an app attempts to do a write inside a read request it will be impossilbe to switch back to writing to the primary. This PR adds an argument to the `while_preventing_writes` so that we can make sure to turn it off if we're doing a write on a primary. Fixes #36830 Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
-
- 02 8月, 2019 20 次提交
-
-
由 Eileen M. Uchitelle 提交于
Introduce InvalidConfigurationError
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
This reverts commit dd779c96.
-
由 Rafael Mendonça França 提交于
This reverts commit 98d0f7eb.
-
由 Rafael Mendonça França 提交于
This reverts commit 8d2866bb.
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 David Heinemeier Hansson 提交于
-
由 Ryuta Kamizono 提交于
Remove duplicate method definition
-
由 Daniel Colson 提交于
no_color! is already defined in [`Rails::Command::Behavior`][behavior], which gets [included into `Rails:Generators`][include]. This duplication came about in 6813edc7 when we introduced the Thor command structure. We have [test coverage][] to ensure this method still behaves correctly on `Rails:Generators`. [behavior]: https://github.com/rails/rails/blob/f7e91c7224560fbd3e95c238a0e8bb362799bcb7/railties/lib/rails/command/behavior.rb#L12-L14 [include]: https://github.com/rails/rails/blob/f7e91c7224560fbd3e95c238a0e8bb362799bcb7/railties/lib/rails/generators.rb#L18 [test coverage]: https://github.com/rails/rails/blob/f7e91c7224560fbd3e95c238a0e8bb362799bcb7/railties/test/generators_test.rb#L163-L168
-
由 Akira Matsuda 提交于
To avoid "uninitialized constant ActiveSupport::Testing (NameError)"
-
由 Akira Matsuda 提交于
-
由 Ryuta Kamizono 提交于
Add tests for selecting aggregrates
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-