- 27 4月, 2018 10 次提交
-
-
由 Ryuta Kamizono 提交于
Currently `ids_reader` doesn't respect dirty target when the target is not loaded yet unlike `collection.size`. I believe the inconsistency is a bug, fixes the `ids_reader` to behave consistently regardless of whether target is loaded or not.
-
由 Ryuta Kamizono 提交于
Loaded associations should not run a new query when size is called
-
由 Jamie Dihiansan 提交于
* Update 'rails_welcome.png' to reflect a more diverse population * Cleanup 'rails_welcome.png'
-
由 Ryuta Kamizono 提交于
This is to ensure that the behavior has not changed before and after #31575.
-
由 Ryuta Kamizono 提交于
Caused at 9276ea89.
-
由 Akira Matsuda 提交于
This method would be called so many times and would create so many temporary garbage Strings
-
由 Akira Matsuda 提交于
Or it would raise if the argument was frozen. And even with this change, it would still reduce String allocations together with 9276ea89 because `escape` should be `true` in most cases
-
由 Akira Matsuda 提交于
This method is called against each tag option for each tag, and creates an extra garbage String per each call
-
由 Akira Matsuda 提交于
tags_text method creates 3 Ruby objects per each logger call when no custom tags are given (which is the default setting, and so presumably the majority use case). This patch reduces two temporary object creations in this case. require 'allocation_tracer' ObjectSpace::AllocationTracer.setup(%i{type}) tags = ['a'] pp before: ObjectSpace::AllocationTracer.trace { tags.collect { |tag| "[#{tag}] " }.join } pp after: ObjectSpace::AllocationTracer.trace { "[#{tags[0]}] " } {:before=>{[:T_ARRAY]=>[1, 0, 0, 0, 0, 0], [:T_STRING]=>[2, 0, 0, 0, 0, 0]}} {:after=>{[:T_STRING]=>[1, 0, 0, 0, 0, 0]}}
-
由 Graham Turner 提交于
Already loaded associations were running an extra query when `size` was called on the association. This fix ensures that an extra query is no longer run. Update tests to use proper methods
-
- 26 4月, 2018 6 次提交
-
-
由 Ryuta Kamizono 提交于
Remove math module from count
-
由 George Claghorn 提交于
Prevent code duplication in ActiveStorage analyzers tests
-
由 Ricardo Díaz 提交于
ImageAnalyzerTest and VideoAnalyzerTest are defining the same helper, since both use `#create_file_blob` that is defined in TestHelper, it makes sense to move `#extract_metadata_from` to that side.
-
由 George Claghorn 提交于
-
由 Javan Makhmali 提交于
Unminify activestorage.js
-
由 Nikolai B 提交于
Not required after https://github.com/rails/arel/pull/449
-
- 25 4月, 2018 16 次提交
-
-
由 Javan Makhmali 提交于
-
由 Ryuta Kamizono 提交于
Make get_value public again
-
由 Graham Turner 提交于
Adds test case for failing issue Moves set_value back to protected
-
由 Rafael França 提交于
Fix title for example of removing data from `session` [ci skip]
-
由 yuuji.yaginuma 提交于
-
由 Rafael França 提交于
Fix segmentation fault in EventedFileUpdateChecker
-
由 Rafael França 提交于
Break up Journey's scanner test
-
由 Matthew Draper 提交于
Address `NameError: uninitialized constant Arel::Collectors::Bind`
-
由 Yasuo Honda 提交于
when tested with Ruby 2.5 or higher ```ruby $ ruby -v ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux] $ bundle exec ruby -w -Itest test/cases/arel/collectors/bind_test.rb -n test_compile_gathers_all_bind_params Run options: -n test_compile_gathers_all_bind_params --seed 24420 E Error: Arel::Collectors::TestBind#test_compile_gathers_all_bind_params: NameError: uninitialized constant Arel::Collectors::Bind Did you mean? Binding test/cases/arel/collectors/bind_test.rb:15:in `collect' test/cases/arel/collectors/bind_test.rb:19:in `compile' test/cases/arel/collectors/bind_test.rb:31:in `test_compile_gathers_all_bind_params' bin/rails test test/cases/arel/collectors/bind_test.rb:30 Finished in 0.002343s, 426.8559 runs/s, 0.0000 assertions/s. 1 runs, 0 assertions, 0 failures, 1 errors, 0 skips $ ``` It is likely due to Ruby 2.5 does not look up top level constant. https://www.ruby-lang.org/en/news/2017/12/25/ruby-2-5-0-released/ "Top-level constant look-up is no longer available."
-
由 Matthew Draper 提交于
Merge Arel
-
由 vaidehijoshi 提交于
This breaks up the one megatest for Journey's scanner into multiple test cases, which also provides better output when there is a failure in the scanner. Before: ``` ./bin/test test/journey/route/definition/scanner_test.rb Run options: --seed 778 F Failure: ActionDispatch::Journey::Definition::TestScanner#test_tokens [/Users/vaidehijoshi/Code/tilde/rails/actionpack/test/journey/route/definition/scanner_test.rb:57]: --- expected +++ actual @@ -1 +1 @@ -[[:SLASH, "/"], [:LITERAL, "page!!"]] +[[:SLASH, "/"], [:LITERAL, "page!"]] bin/test Users/vaidehijoshi/Code/tilde/rails/actionpack/test/journey/route/definition/scanner_test.rb:14 Finished in 0.090899s, 11.0012 runs/s, 44.0049 assertions/s. 1 runs, 4 assertions, 1 failures, 0 errors, 0 skips ``` After: ``` ./bin/test test/journey/route/definition/scanner_test.rb Run options: --seed 2230 ....................F Failure: ActionDispatch::Journey::Definition::TestScanner#test_scanning_/page$ [/Users/vaidehijoshi/Code/tilde/rails/actionpack/test/journey/route/definition/scanner_test.rb:58]: Wrong tokens for `/page$`. --- expected +++ actual @@ -1 +1 @@ -[[:SLASH, "/"], [:LITERAL, "page$$"]] +[[:SLASH, "/"], [:LITERAL, "page$"]] bin/test Users/vaidehijoshi/Code/tilde/rails/actionpack/test/journey/route/definition/scanner_test.rb:56 F Failure: ActionDispatch::Journey::Definition::TestScanner#test_scanning_/page! [/Users/vaidehijoshi/Code/tilde/rails/actionpack/test/journey/route/definition/scanner_test.rb:58]: Wrong tokens for `/page!`. --- expected +++ actual @@ -1 +1 @@ -[[:SLASH, "/"], [:LITERAL, "page!!"]] +[[:SLASH, "/"], [:LITERAL, "page!"]] bin/test Users/vaidehijoshi/Code/tilde/rails/actionpack/test/journey/route/definition/scanner_test.rb:56 F Failure: ActionDispatch::Journey::Definition::TestScanner#test_scanning_/page& [/Users/vaidehijoshi/Code/tilde/rails/actionpack/test/journey/route/definition/scanner_test.rb:58]: Wrong tokens for `/page&`. --- expected +++ actual @@ -1 +1 @@ -[[:SLASH, "/"], [:LITERAL, "page&&"]] +[[:SLASH, "/"], [:LITERAL, "page&"]] bin/test Users/vaidehijoshi/Code/tilde/rails/actionpack/test/journey/route/definition/scanner_test.rb:56 Finished in 0.126447s, 181.8944 runs/s, 181.8944 assertions/s. 23 runs, 23 assertions, 3 failures, 0 errors, 0 skips ```
-
由 yuuji.yaginuma 提交于
We don't use `mini_magick` directly since #32471.
-
由 utilum 提交于
resolves #32705
-
由 Eileen M. Uchitelle 提交于
Fix typo in migrations guide [ci skip]
-
由 Daniel Colson 提交于
Introduced in #32646
-
由 Sean Griffin 提交于
Update schema.rb documentation [CI SKIP]
-
- 24 4月, 2018 8 次提交
-
-
由 Derek Prior 提交于
The documentation previously claimed that `db/schema.rb` was "the authoritative source for your database schema" while simultaneously also acknowledging that the file is generated. These two statements are incongruous and the guides accurately call out that many database constructs are unsupported by `schema.rb`. This change updates the comment at the top of `schema.rb` to remove the assertion that the file is authoritative. The documentation also previously referred vaguely to "issues" when re-running old migrations. This has been updated slightly to hint at the types of problems that one can encounter with old migrations. In sum, this change attempts to more accurately capture the pros, cons, and shortcomings of the two schema formats in the guides and in the comment at the top of `schema.rb`. [Derek Prior & Sean Griffin] Co-authored-by: NSean Griffin <sean@seantheprogrammer.com>
-
由 Andrew White 提交于
Use strict_encode64 instead of gsub newline for ScreenshotHelper
-
由 Bart de Water 提交于
-
由 Ryuta Kamizono 提交于
Save a hash allocation in MySQL statement pool
-
由 George Claghorn 提交于
Ensure that other processes like ImageMagick and FFmpeg see the complete contents of the file.
-
由 George Claghorn 提交于
Use ImageProcessing gem for ActiveStorage variants
-
由 Eugene Kenny 提交于
There's no need to wrap the statement in a hash with a single key.
-