1. 15 6月, 2019 10 次提交
  2. 14 6月, 2019 4 次提交
    • A
      Keep part when scope option has value · 85855d63
      Alberto Almagro 提交于
      When a route was defined within an optional scope, if that route didn't
      take parameters the scope was lost when using path helpers. This patch
      ensures scope is kept both when the route takes parameters or when it
      doesn't.
      
      Fixes #33219
      85855d63
    • R
      Merge pull request #36477 from albertoalmagro/alberto/button-to-default-path · b34e3a57
      Rafael França 提交于
      [ci skip] Use default path in button_to documentation
      b34e3a57
    • J
      Make ActiveRecord `ConnectionPool.connections` thread-safe. (#36473) · 05ee6624
      jeffdoering 提交于
      * Make ActiveRecord `ConnectionPool.connections` thread-safe.
      
      ConnectionPool documentation is clear on the need to synchronize
      access to @connections but also states that public methods do not
      require synchronization. Existing code exposed @connections
      directly via attr_reader. The fix uses synchronize() to lock
      @connections then returns a copy to the caller using Array.dup().
      
      Includes comments on the connections method that thread-safe access
      to the connections array does not imply thread-safety of accessing
      methods on the actual connections.
      
      Adds a test-case that modifies the pool using a supported method
      in one thread  while a second thread accesses pool.connections.
      The test fails without this patch.
      
      Fixes #36465.
      
      * Update activerecord/test/cases/connection_pool_test.rb
      
      [jeffdoering + Rafael Mendonça França]
      05ee6624
    • R
      Merge pull request #36466 from wbnns/update-missing-create-action-screenshot · 4e55d0d1
      Rafael França 提交于
      images/getting_started: Update screenshot for missing action
      4e55d0d1
  3. 13 6月, 2019 1 次提交
  4. 12 6月, 2019 4 次提交
  5. 07 6月, 2019 4 次提交
  6. 06 6月, 2019 2 次提交
  7. 05 6月, 2019 6 次提交
  8. 04 6月, 2019 3 次提交
    • E
      Merge pull request #36395 from cpruitt/6-0-stable · f9a0ae63
      Eileen M. Uchitelle 提交于
      Do not clear deprecated initializer dependencies if using classic autoloader
      f9a0ae63
    • C
      Do not clear deprecated initializer dependencies if using classic autoloader · bb3f24af
      Cliff Pruitt 提交于
      `Rails::Application::Finisher` defines a `:let_zeitwerk_take_over` initializer. This initializer is always run but it's statements are wrapped in a guard: `config.autoloader == :zeitwerk`.
      
      `Finisher` also defines a `initializer :warn_if_autoloaded` initializer with a `before: :let_zeitwerk_take_over` option which also always runs. This initializer unloads any constants autoloaded during initialization and displays a deprecation warning. This initializer does not account for `config.autoloader` being set to `:classic`.
      
      The problem is that this initializer changes the behavior of the classic autoloader. Constant autoloading from initializers is deprecated but the deprecation should not break existing applications which currently depend on autoloaded constants in initializers.
      
      This commit prevents the dependencies from being unloaded if the autoloader is not Zeitwerk. It also updates the deprecation warning, if the classic autoloader is enabled, to indicate that the constants would have been unloaded if Zeitwerk had been used.
      bb3f24af
    • Y
      Merge pull request #36397 from y-yagi/only_clear_cache_when_view_paths_are_specified · 287539fc
      Yuji Yaginuma 提交于
      Only clear cache when view paths are specified
      287539fc
  9. 03 6月, 2019 1 次提交
  10. 02 6月, 2019 2 次提交
  11. 01 6月, 2019 2 次提交
  12. 29 5月, 2019 1 次提交