1. 22 3月, 2018 1 次提交
    • R
      Fix `test_config_another_database` failure · 958c5ad9
      Ryuta Kamizono 提交于
      Somehow `test_config_another_database` didn't fail on CI, but it will
      fail locally.
      
      https://travis-ci.org/rails/rails/jobs/356212950#L2474-L2482
      
      ```
      % bundle exec ruby -w -Itest test/generators/app_generator_test.rb -n test_config_another_database
      Run options: -n test_config_another_database --seed 7260
      
      # Running:
      
      F
      
      Failure:
      AppGeneratorTest#test_config_another_database [test/generators/app_generator_test.rb:417]:
      Expected /^\s*gem\s+["']mysql2["'], '~> 0.4.4'$*/ to match "source 'https://rubygems.org'\ngit_source(:github) { |repo| \"https://github.com/\#{repo}.git\" }\n\nruby '2.5.0'\n\n# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'\ngem 'rails', '~> 6.0.0.alpha'\n# Use mysql as the database for Active Record\ngem 'mysql2', '>= 0.4.4', '< 0.6.0'\n# Use Puma as the app server\ngem 'puma', '~> 3.11'\n# Use SCSS for stylesheets\ngem 'sass-rails', '~> 5.0'\n# Use Uglifier as compressor for JavaScript assets\ngem 'uglifier', '>= 1.3.0'\n# See https://github.com/rails/execjs#readme for more supported runtimes\n# gem 'mini_racer', platforms: :ruby\n\n# Use CoffeeScript for .coffee assets and views\ngem 'coffee-rails', '~> 4.2'\n# Turbolinks makes navigating your web application faster. Read more: https://github.com/turbolinks/turbolinks\ngem 'turbolinks', '~> 5'\n# Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder\ngem 'jbuilder', '~> 2.5'\n# Use Redis adapter to run Action Cable in production\n# gem 'redis', '~> 4.0'\n# Use ActiveModel has_secure_password\n# gem 'bcrypt', '~> 3.1.7'\n\n# Use ActiveStorage variant\n# gem 'mini_magick', '~> 4.8'\n\n# Use Capistrano for deployment\n# gem 'capistrano-rails', group: :development\n\n# Reduces boot times through caching; required in config/boot.rb\ngem 'bootsnap', '>= 1.1.0', require: false\n\ngroup :development, :test do\n  # Call 'byebug' anywhere in the code to stop execution and get a debugger console\n  gem 'byebug', platforms: [:mri, :mingw, :x64_mingw]\nend\n\ngroup :development do\n  # Access an interactive console on exception pages or by calling 'console' anywhere in the code.\n  gem 'web-console', '>= 3.3.0'\n  gem 'listen', '>= 3.0.5', '< 3.2'\n  # Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring\n  gem 'spring'\n  gem 'spring-watcher-listen', '~> 2.0.0'\nend\n\ngroup :test do\n  # Adds support for Capybara system testing and selenium driver\n  gem 'capybara', '>= 2.15', '< 4.0'\n  gem 'selenium-webdriver'\n  # Easy installation and use of chromedriver to run system tests with Chrome\n  gem 'chromedriver-helper'\nend\n\n# Windows does not include zoneinfo files, so bundle the tzinfo-data gem\ngem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]\n".
      
      bin/rails test test/generators/app_generator_test.rb:411
      
      Finished in 0.174681s, 5.7247 runs/s, 34.3483 assertions/s.
      1 runs, 6 assertions, 1 failures, 0 errors, 0 skips
      ```
      958c5ad9
  2. 27 2月, 2018 1 次提交
    • A
      Don't enforce UTF-8 by default · 96eeea53
      Andrew White 提交于
      With the disabling of TLS 1.0 by most major websites, continuing to run
      IE8 or lower becomes increasingly difficult so default to not enforcing
      UTF-8 encoding as it's not relevant to other browsers.
      96eeea53
  3. 24 2月, 2018 1 次提交
  4. 23 2月, 2018 2 次提交
  5. 22 2月, 2018 2 次提交
  6. 20 2月, 2018 1 次提交
  7. 19 2月, 2018 2 次提交
  8. 17 2月, 2018 1 次提交
  9. 13 2月, 2018 2 次提交
  10. 12 2月, 2018 1 次提交
    • C
      Respect --force option for config/master.key · 24284fd3
      claudiob 提交于
      This is similar to #30700 which ensures the `--quiet` option of `rails new`
      is respected by the `MasterKeyGenerator` (missing from #30067).
      
      Before this commit, running `rails new app --force` would still prompt the
      user what to do with the conflict in `config/master.key`:
      
      ```
                    …
         identical  config/locales/en.yml
          conflict  config/master.key
      Overwrite /Users/claudiob/Desktop/pizza/config/master.key? (enter "h" for help) [Ynaqdh]
      ```
      
      After this commit, `config/master.key` is overwritten:
      
      ```
                 …
      identical  config/locales/en.yml
          force  config/master.key
         append  .gitignore
      ```
      
      The newly added test generates an app and then generates it again with
      `--force`. Without this commit, the test would just wait forever for user
      input.
      24284fd3
  11. 26 1月, 2018 1 次提交
  12. 11 1月, 2018 1 次提交
  13. 10 1月, 2018 1 次提交
    • B
      Clean up railties tests · b6ed9a7f
      bogdanvlviv 提交于
        Remove `AppGeneratorTest#test_active_storage_install`.
        The test is added by 67db41aa,
        since #31534 this test doesn't test anything.
      
        Remove redundant assertions in `SharedGeneratorTests`.
        These assertions is added by 4a835aa3.
        Follows 67db41aa, #31534.
      b6ed9a7f
  14. 26 12月, 2017 1 次提交
  15. 24 12月, 2017 1 次提交
  16. 19 12月, 2017 1 次提交
  17. 16 12月, 2017 1 次提交
    • Y
      Add `skip_bootsnap` option · 838b40da
      yuuji.yaginuma 提交于
      `bootsnap` is a useful gem normally. However, `bootsnap` is unnecessary
      when generating a Rails application to be used only for testing.
      So I want to control whether use this or not by option.
      838b40da
  18. 15 12月, 2017 1 次提交
  19. 05 12月, 2017 2 次提交
  20. 04 12月, 2017 1 次提交
  21. 03 12月, 2017 1 次提交
    • C
      Fix typo in test error message · a71bbed7
      claudiob 提交于
      With the current code, a failing test shows this error, which is missing
      the number of times called and has two periods at the end.
      
      ```
      /railties$ be ruby -Itest test/generators/app_generator_test.rb -n test_active_storage_install
      
      Failure:
      AppGeneratorTest#test_active_storage_install [test/generators/app_generator_test.rb:313]:
      active_storage:install expected to be called once, but was called  times..
      Expected: 1
        Actual: 2
      ```
      
      After the fix, the error message looks correct:
      
      ```
      /railties$ be ruby -Itest test/generators/app_generator_test.rb -n test_active_storage_install
      
      Failure:
      AppGeneratorTest#test_active_storage_install [test/generators/app_generator_test.rb:313]:
      active_storage:install expected to be called once, but was called 2 times.
      Expected: 1
        Actual: 2
      ```
      a71bbed7
  22. 28 11月, 2017 1 次提交
  23. 27 11月, 2017 3 次提交
  24. 26 11月, 2017 1 次提交
  25. 18 11月, 2017 1 次提交
  26. 16 11月, 2017 1 次提交
    • Y
      Add master key to `gitignore` on `rails new` · f27319a7
      yuuji.yaginuma 提交于
      We generate master key on `rails new`.
      Therefore, if do not add master key to `.gitginore` on `rails new`as
      well, there is a possibility that the master key will be committed
      accidentally.
      f27319a7
  27. 14 11月, 2017 2 次提交
  28. 13 11月, 2017 1 次提交
  29. 09 11月, 2017 1 次提交
  30. 08 11月, 2017 1 次提交
  31. 07 11月, 2017 2 次提交
    • B
      f4af77ab
    • B
      `rails new` runs `rails active_storage:install` · 0835527d
      bogdanvlviv 提交于
      Omit `rails activestorage:install` for jdbcmysql, jdbc and shebang tests
      
      AppGeneratorTest#test_config_jdbcmysql_database
      
        rails aborted!
        LoadError: Could not load 'active_record/connection_adapters/mysql_adapter'.
        Make sure that the adapter in config/database.yml is valid.
        If you use an adapter other than 'mysql2', 'postgresql' or 'sqlite3' add
        the necessary adapter gem to the Gemfile.
        (compressed)
        bin/rails:4:in `<main>'
        Tasks: TOP => activestorage:install => environment
        (See full trace by running task with --trace)
      
      AppGeneratorTest#test_config_jdbc_database
      
        rails aborted!
        LoadError: Could not load 'active_record/connection_adapters/jdbc_adapter'.
        Make sure that the adapter in config/database.yml is valid.
        If you use an adapter other than 'mysql2', 'postgresql' or 'sqlite3' add
        the necessary adapter gem to the Gemfile.
        (compressed)
        bin/rails:4:in `<main>'
        Tasks: TOP => activestorage:install => environment
        (See full trace by running task with --trace)
      
      AppGeneratorTest#test_shebang_is_added_to_rails_file
      
        /home/ubuntu/.rbenv/versions/2.4.1/bin/ruby: no Ruby script found in input (LoadError)
      
      Prevent PendingMigrationError in tests
      
       * Run `bin/rails db:migrate RAILS_ENV=test` in test_cases before start tests to prevent PendingMigrationError
       * FileUtils.rm_r("db/migrate")
       * --skip-active-storage
      
      Fix failed tests in `railties/test/railties/engine_test.rb`
      
      Related to #30111
      
      Imporve `SharedGeneratorTests#test_default_frameworks_are_required_when_others_are_removed`
      
       - Explicitly skip active_storage
       - Ensure that skipped frameworks are commented
       - Ensure that default frameworks are not commented
      
      Fix error `Errno::ENOSPC: No space left on device - sendfile`
      
      Since `rails new` runs `rails active_storage:install`
      that boots an app.
      
      Since adding Bootsnap 0312a5c6
      during booting an app, it creates the cache:
      
         264K    tmp/cache/bootsnap-load-path-cache
         27M     tmp/cache/bootsnap-compile-cache
      
      * teardown_app must remove app
      0835527d