- 13 12月, 2017 4 次提交
-
-
由 Rafael França 提交于
Merge pull request #31405 from bogdanvlviv/fix-conflicts-counter_cache-with-touch-by-optimistic_locking Fix conflicts `counter_cache` with `touch: true` by optimistic locking.
-
由 Rafael França 提交于
Fix doc typo [ci skip]
-
由 Tom Copeland 提交于
-
由 Rafael França 提交于
Quote colum_names when building select:
-
- 12 12月, 2017 24 次提交
-
-
由 Eileen M. Uchitelle 提交于
Revert "only install ffmpeg and mupdf on activestorage builds"
-
由 Yasuo Honda 提交于
This reverts commit 6ec0ed67.
-
由 Ryuta Kamizono 提交于
[ci skip] Fix Active Support Changelog about :race_condition_ttl
-
由 Mehmet Emin INAC 提交于
-
由 Ryuta Kamizono 提交于
Remove stale comment about `ActiveRecord::SchemaDumper.ignore_tables` [skip ci]
-
由 fatkodima 提交于
-
由 Ryuta Kamizono 提交于
Follow up of #31390.
-
由 Ryuta Kamizono 提交于
Prevent race condition when resetting time stubs
-
由 Eugene Kenny 提交于
If the current thread is preempted after the stub has been removed but before the original method has been restored, then the other thread will get a `NoMethodError` when it tries to call the method. Using `silence_redefinition_of_method` instead of `undef_method` ensures that either the stub or the original method is always in place.
-
由 Ryuta Kamizono 提交于
Fix secrets command deprecation message
-
由 Ryuta Kamizono 提交于
[ci skip] Update routing guide for Direct & resolved routes
-
由 Stefan Wrobel 提交于
-
由 Yoshiyuki Hirano 提交于
* Added the direct method to routing guide.
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
This reverts commit a80f81af.
-
由 Rafael França 提交于
`create_fixtures` doesn't work since at least a94220b6
-
由 bogdanvlviv 提交于
``` # create_table :posts do |t| # t.integer :comments_count, default: 0 # t.integer :lock_version # t.timestamps # end class Post < ApplicationRecord end # create_table :comments do |t| # t.belongs_to :post # end class Comment < ApplicationRecord belongs_to :post, touch: true, counter_cache: true end ``` Before: ``` post = Post.create! # => begin transaction INSERT INTO "posts" ("created_at", "updated_at", "lock_version") VALUES ("2017-12-11 21:27:11.387397", "2017-12-11 21:27:11.387397", 0) commit transaction comment = Comment.create!(post: post) # => begin transaction INSERT INTO "comments" ("post_id") VALUES (1) UPDATE "posts" SET "comments_count" = COALESCE("comments_count", 0) + 1, "lock_version" = COALESCE("lock_version", 0) + 1 WHERE "posts"."id" = 1 UPDATE "posts" SET "updated_at" = '2017-12-11 21:27:11.398330', "lock_version" = 1 WHERE "posts"."id" = 1 AND "posts"."lock_version" = 0 rollback transaction # => ActiveRecord::StaleObjectError: Attempted to touch a stale object: Post. Comment.take.destroy! # => begin transaction DELETE FROM "comments" WHERE "comments"."id" = 1 UPDATE "posts" SET "comments_count" = COALESCE("comments_count", 0) - 1, "lock_version" = COALESCE("lock_version", 0) + 1 WHERE "posts"."id" = 1 UPDATE "posts" SET "updated_at" = '2017-12-11 21:42:47.785901', "lock_version" = 1 WHERE "posts"."id" = 1 AND "posts"."lock_version" = 0 rollback transaction # => ActiveRecord::StaleObjectError: Attempted to touch a stale object: Post. ``` After: ``` post = Post.create! # => begin transaction INSERT INTO "posts" ("created_at", "updated_at", "lock_version") VALUES ("2017-12-11 21:27:11.387397", "2017-12-11 21:27:11.387397", 0) commit transaction comment = Comment.create!(post: post) # => begin transaction INSERT INTO "comments" ("post_id") VALUES (1) UPDATE "posts" SET "comments_count" = COALESCE("comments_count", 0) + 1, "lock_version" = COALESCE("lock_version", 0) + 1, "updated_at" = '2017-12-11 21:37:09.802642' WHERE "posts"."id" = 1 commit transaction comment.destroy! # => begin transaction DELETE FROM "comments" WHERE "comments"."id" = 1 UPDATE "posts" SET "comments_count" = COALESCE("comments_count", 0) - 1, "lock_version" = COALESCE("lock_version", 0) + 1, "updated_at" = '2017-12-11 21:39:02.685520' WHERE "posts"."id" = 1 commit transaction ``` Fixes #31199.
-
由 Edouard CHIN 提交于
- #30980 introcuded a change to not use `Arel.star` when model have ignored columns, a query used to look like `SELECT *. FROM developers` whereas now it would like `SELECT column1, column2 FROM developers` - If a column has the same name has a reserved database specific keyword (such as key, where ...) then the query would fail because the names aren't quoted - Quoting almost always happen unless we use a `from` clause in the query https://github.com/rails/rails/blob/9965b98dc0d58a86e10b4343bb6e15e01661a8c3/activerecord/lib/active_record/relation/query_methods.rb#L1052 - This PR cast all columns name to symbols in order for the quoting logic to be picked up https://github.com/rails/rails/blob/9965b98dc0d58a86e10b4343bb6e15e01661a8c3/activerecord/lib/active_record/relation/query_methods.rb#L1054-L1055 - A reproduction script can be found here https://gist.github.com/Edouard-chin/f56d464a0adcb76962afc1a9134a1536
-
由 Edouard CHIN 提交于
- The namespacing should be `ActiveRecord::FixtureSet` - I might be missing something but I'm not sure why `create_fixtures` is useful for nowaday (unless for testing rails internal /shrug) and since it's been that long it wasn't working I think it should be fine to just fire it
-
由 George Claghorn 提交于
Return `nil` instead of `false` if raise `Azure::Core::Http::HTTPError`
-
由 George Claghorn 提交于
[ci skip] Update instrumentation guide for ActiveStorage
-
由 Yoshiyuki Hirano 提交于
* Added `service_delete_prefixed.active_storage`.
-
由 George Claghorn 提交于
Execute a single mogrify command with multiple options rather than one command per option. Permit the use of all mogrify options, not just the ones that fall through to MiniMagick::Image#method_missing.
-
由 Yoshiyuki Hirano 提交于
* If it raise error `Azure::Core::Http::HTTPError`, return `nil` instead of `false` in `ActiveStorage::Service::AzureStorageService#delete`. * Other services behave as same as this.
-
- 11 12月, 2017 3 次提交
-
-
由 Eileen M. Uchitelle 提交于
StreamingTemplateRenderer fails to forward I18n.locale in layouts
-
由 Javan Makhmali 提交于
`webpack` is assigned but never used in webpack.config.js
-
由 Eileen M. Uchitelle 提交于
Remove whitespace
-
- 10 12月, 2017 6 次提交
-
-
由 Lonre Wang 提交于
-
由 Yoshiyuki Hirano 提交于
* Removed webpack const, so it is assigned but never used in webpack.config.js.
-
由 yuuji.yaginuma 提交于
Currently, `test_copy_table_with_composite_primary_keys` test fails depending on execution order. The reproduction step is as follows. ``` $ ARCONN=sqlite3_mem bin/test -w -n "/^(?:CalculationsTest#(?:test_#skip_query_cache\\!_for_a_simple_calculation)|PrimaryKeyAnyTypeTest#(?:test_any_type_primary_key)|ActiveRecord::ConnectionAdapters::SQLite3AdapterTest#(?:test_copy_table_with_composite_primary_keys))$/" --seed 41545 ``` The column info is cached by `PrimaryKeyAnyTypeTest#test_any_type_primary_key`, and the test seems to have failed due to the influence. So clear cache after testing so as not to affect other tests. Related: https://travis-ci.org/rails/rails/jobs/313730163#L1788
-
由 Guillermo Iguaran 提交于
Change the system tests to set Puma as default server only when the user haven't specified manually another server.
-
由 Guillermo Iguaran 提交于
Change the system tests to set Puma as default server only when the user haven't specified manually another server.
-
由 Guillermo Iguaran 提交于
-
- 09 12月, 2017 3 次提交
-
-
由 Ryuta Kamizono 提交于
CI against JRuby 9.1.15.0
-
由 Claudio B 提交于
docs: add example for a nil name in link_to
-
由 Aaron Patterson 提交于
Fix Rails environment when running tests with Ruby
-