1. 15 10月, 2018 1 次提交
  2. 13 10月, 2018 1 次提交
  3. 11 10月, 2018 1 次提交
  4. 09 10月, 2018 1 次提交
    • G
      Fix directly uploading using a MIME type synonym · 5fb47034
      George Claghorn 提交于
      When Content-Type is "application/x-gzip", request.content_type resolves to "application/gzip", because application/x-gzip is a synonym of application/gzip by default. This causes the acceptable_content? check in ActiveStorage::DiskController to fail, because the direct upload token contains application/x-gzip, which is not equal to application/gzip.
      
      Fix by comparing the token content type with the request content type *and its synonyms*.
      5fb47034
  5. 08 10月, 2018 1 次提交
  6. 07 10月, 2018 2 次提交
  7. 05 10月, 2018 1 次提交
    • M
      Bugfix: ActiveSupport::EncryptedConfiguration reading of comment-only encrypted files (#34014) · 6a43a409
      Martin Spickermann 提交于
      * Fix reading comment only encrypted files
      
      When a encrypted file contains only comments then reading that files raises an error:
      
          NoMethodError: undefined method `deep_symbolize_keys' for false:FalseClass
              activesupport/lib/active_support/encrypted_configuration.rb:33:in `config'
              test/encrypted_configuration_test.rb:52:in `block in <class:EncryptedConfigurationTest>'
      
      This happens because the previous implementation returned a `{}` fallback for blank YAML strings. But it did not handle YAML strings that are present but still do not contain any _usefull_ YAML - like the file created by `Rails::Generators::EncryptedFileGenerator` which looks like this:
      
          # aws:
          #   access_key_id: 123
          #   secret_access_key: 345
      
      * Fix coding style violation
      
      * Add backwardscompatible with Psych versions that were shipped with Ruby <2.5
      
      * Do not rely on railties for Active Support test
      
      * Simplify error handling
      
      * Improve test naming
      
      * Simplify file creation in test
      6a43a409
  8. 28 9月, 2018 1 次提交
  9. 24 9月, 2018 1 次提交
  10. 22 9月, 2018 4 次提交
  11. 21 9月, 2018 5 次提交
  12. 20 9月, 2018 1 次提交
  13. 17 9月, 2018 4 次提交
  14. 15 9月, 2018 1 次提交
  15. 14 9月, 2018 1 次提交
  16. 13 9月, 2018 1 次提交
  17. 12 9月, 2018 3 次提交
  18. 11 9月, 2018 3 次提交
  19. 07 9月, 2018 2 次提交
  20. 03 9月, 2018 1 次提交
  21. 31 8月, 2018 1 次提交
  22. 30 8月, 2018 2 次提交
    • Y
      Generate the same value as a label of view in system test template · 545a1104
      yuuji.yaginuma 提交于
      In the system test template, enter a value based on label.
      However, since `label` method does not use `titleize` by default.
      If generate a value including underscore, cannot find a label and the test
      will fail.
      
      ```
      $ ./bin/rails g scaffold user name:string phone_number:string
      $ ./bin/rails t test/system/users_test.rb
      
      E
      
      Error:
      UsersTest#test_creating_a_User:
      Capybara::ElementNotFound: Unable to find field "Phone Number"
          test/system/users_test.rb:18:in `block in <class:UsersTest>'
      ```
      
      This removes unnecessary `titleize` so that the generated file will pass
      even if the attribute contains an underscore.
      545a1104
    • R
      Merge pull request #33744 from bogdanvlviv/fixes-27852 · 0e8362b1
      Ryuta Kamizono 提交于
      Prevent leaking of user's DB credentials on `rails db:create` failure
      0e8362b1
  23. 29 8月, 2018 1 次提交