1. 21 2月, 2015 1 次提交
  2. 08 2月, 2015 1 次提交
    • S
      Push multi-parameter assignement into the types · 631707a5
      Sean Griffin 提交于
      This allows us to remove `Type::Value#klass`, as it was only used for
      multi-parameter assignment to reach into the types internals. The
      relevant type objects now accept a hash in addition to their previous
      accepted arguments to `type_cast_from_user`. This required minor
      modifications to the tests, since previously they were relying on the
      fact that mulit-parameter assignement was reaching into the internals of
      time zone aware attributes. In reaility, changing those properties at
      runtime wouldn't change the accessor methods for all other forms of
      assignment.
      631707a5
  3. 19 11月, 2014 1 次提交
    • S
      Improve the performance of reading attributes · 08576b94
      Sean Griffin 提交于
      We added a comparison to "id", and call to `self.class.primary_key` a
      *lot*. We also have performance hits from `&block` all over the place.
      We skip the check in a new method, in order to avoid breaking the
      behavior of `read_attribute`
      08576b94
  4. 29 9月, 2014 1 次提交
    • B
      Isolate access to @associations_cache and @aggregations cache to the... · 9d569585
      Ben Woosley 提交于
      Isolate access to @associations_cache and @aggregations cache to the Associations and Aggregations modules, respectively.
      
      This includes replacing the `association_cache` accessor with a more
      limited `association_cached?` accessor and making `clear_association_cache`
      and `clear_aggregation_cache` private.
      9d569585
  5. 07 6月, 2014 2 次提交
  6. 18 5月, 2014 1 次提交
  7. 12 9月, 2013 1 次提交
  8. 24 7月, 2013 1 次提交
  9. 23 7月, 2013 1 次提交
  10. 03 1月, 2013 1 次提交
  11. 02 1月, 2013 1 次提交
  12. 09 11月, 2012 1 次提交
  13. 28 7月, 2012 1 次提交
  14. 19 6月, 2012 1 次提交
    • S
      Removing composed_of from ActiveRecord. · 14fc8b34
      Steve Klabnik 提交于
      This feature adds a lot of complication to ActiveRecord for dubious
      value. Let's talk about what it does currently:
      
      class Customer < ActiveRecord::Base
        composed_of :balance, :class_name => "Money", :mapping => %w(balance amount)
      end
      
      Instead, you can do something like this:
      
          def balance
            @balance ||= Money.new(value, currency)
          end
      
          def balance=(balance)
            self[:value] = balance.value
            self[:currency] = balance.currency
            @balance = balance
          end
      
      Since that's fairly easy code to write, and doesn't need anything
      extra from the framework, if you use composed_of today, you'll
      have to add accessors/mutators like that.
      
      Closes #1436
      Closes #2084
      Closes #3807
      14fc8b34
  15. 24 5月, 2012 1 次提交
    • V
      Revert "Remove blank trailing comments" · 1ad0b378
      Vijay Dev 提交于
      This reverts commit fa6d921e.
      
      Reason: Not a fan of such massive changes. We usually close such changes
      if made to Rails master as a pull request. Following the same principle
      here and reverting.
      
      [ci skip]
      1ad0b378
  16. 22 5月, 2012 1 次提交
  17. 20 5月, 2012 3 次提交
    • H
      Remove blank trailing comments · fa6d921e
      Henrik Hodne 提交于
      For future reference, this is the regex I used: ^\s*#\s*\n(?!\s*#). Replace
      with the first match, and voilà! Note that the regex matches a little bit too
      much, so you probably want to `git add -i .` and go through every single diff
      to check if it actually should be changed.
      fa6d921e
    • O
      Revert typo · ba896d37
      Oscar Del Ben 提交于
      ba896d37
    • O
      Typo · fae4a263
      Oscar Del Ben 提交于
      fae4a263
  18. 11 5月, 2012 1 次提交
  19. 03 5月, 2012 1 次提交
    • Y
      allow the :converter Proc form composed_of to return nil · fa5f0375
      Yves Senn 提交于
      This makes it possible to filter invalid input values before they are passed
      into the value-object (like empty strings). This behaviour is only relevant
      if the :allow_nil options is set to true. Otherwise you will get
      the resulting NoMethodError.
      fa5f0375
  20. 02 5月, 2012 3 次提交
  21. 25 2月, 2012 1 次提交
  22. 23 10月, 2011 1 次提交
  23. 24 5月, 2011 1 次提交
  24. 19 1月, 2011 1 次提交
  25. 08 1月, 2011 4 次提交
  26. 09 11月, 2010 1 次提交
  27. 01 9月, 2010 1 次提交
  28. 14 8月, 2010 2 次提交
  29. 02 8月, 2010 1 次提交
  30. 31 7月, 2010 1 次提交
  31. 24 6月, 2010 1 次提交