1. 10 4月, 2014 3 次提交
  2. 09 4月, 2014 1 次提交
  3. 08 4月, 2014 2 次提交
    • M
      Give a deprecation message even when the lookup fails · 23692184
      Matthew Draper 提交于
      If the supplied string doesn't contain a colon, it clearly cannot be a
      database URL. They must have intended to do a key lookup, so even though
      it failed, give the explanatory deprecation warning, and raise the
      exception that lists the known configs.
      
      Conveniently, this also simplifies our logical behaviour: if the string
      matches a known configuration, or doesn't contain a colon (and is
      therefore clearly not a URL), then we output a deprecation warning, and
      behave exactly as we would if it were a symbol.
      23692184
    • A
      wrap the literal value before handing it to arel · a38e957f
      Aaron Patterson 提交于
      this lets arel know how to correctly quote the value
      a38e957f
  4. 07 4月, 2014 1 次提交
    • M
      Use connection-specific bytea escaping · c4bdca19
      Matthew Draper 提交于
      In our normal usage, it's rare for this to make a difference... but is
      more technically correct.
      
      As well as a spec that proves this is a good idea, let's also add a more
      sane-looking one that just covers basic to_sql functionality. There
      aren't many places where we actually use escape_bytea, but that's one
      that won't be going away.
      c4bdca19
  5. 04 4月, 2014 1 次提交
    • Y
      PostgreSQL and SQLite, remove varchar limit. [Vladimir Sazhin & Toms Mikoss & Yves Senn] · f4226c3a
      Yves Senn 提交于
      There is no reason for the PG adapter to have a default limit of 255 on :string
      columns. See this snippet from the PG docs:
      
          Tip: There is no performance difference among these three types, apart
          from increased storage space when using the blank-padded type, and a
          few extra CPU cycles to check the length when storing into a
          length-constrained column. While character(n) has performance
          advantages in some other database systems, there is no such advantage
          in PostgreSQL; in fact character(n) is usually the slowest of the
          three because of its additional storage costs. In most situations text
          or character varying should be used instead.
      f4226c3a
  6. 03 4月, 2014 3 次提交
    • D
      Treat blank UUID values as nil · 1f432c54
      Dmitry Lavrov 提交于
      1f432c54
    • M
      Avoid including DB details in exception messages · ad141538
      Matthew Draper 提交于
      The keys are quite sufficient; we shouldn't be throwing passwords
      around.
      ad141538
    • M
      Avoid a spurious deprecation warning for database URLs · 88e60a48
      Matthew Draper 提交于
      This is all about the case where we have a `DATABASE_URL`, and we have a
      `database.yml` present, but the latter doesn't contain the key we're
      looking for.
      
      If the key is a symbol, we'll always connect to `DATABASE_URL`, per the
      new behaviour in 283a2ede.
      
      If the key is a string, on the other hand, it should always be a URL:
      the ability to specify a name not present in `database.yml` is new in
      this version of Rails, and that ability does not stretch to the
      deprecated use of a string in place of a symbol.
      
      Uncovered by @guilleiguaran while investigating #14495 -- this actually
      may be related to the original report, but we don't have enough info to
      confirm.
      88e60a48
  7. 02 4月, 2014 7 次提交
  8. 01 4月, 2014 1 次提交
    • Y
      PostgreSQL determine `Column#type` through corresponding OID. #7814 · 4d344bb4
      Yves Senn 提交于
      I ran the whole test suite and compared the old to the new types.
      Following is the list of types that did change with this patch:
      
      ```
      DIFFERENT TYPE FOR mood: NEW: enum, BEFORE:
      DIFFERENT TYPE FOR floatrange: NEW: floatrange, BEFORE: float
      ```
      
      The `floatrange` is a custom type. The old type `float` was simply a coincidence
      form the name `floatrange` and our type-guessing.
      4d344bb4
  9. 31 3月, 2014 4 次提交
  10. 29 3月, 2014 1 次提交
  11. 27 3月, 2014 7 次提交
  12. 26 3月, 2014 2 次提交
  13. 20 3月, 2014 1 次提交
    • J
      Postgres schema: Constrain sequence search classid · 0110d7b7
      Josh Williams 提交于
      The pk_an_sequence_for query previously joined against pg_class's oid
      for rows in pg_depend, but pg_depend's objid may point to other system
      tables, such as pg_attrdef.  If a row in one of those other tables
      coincidentally has the same oid as an (unrelated) sequence, that
      sequence name may be returned instead of the real one.
      
      This ensures that only the pg_depend entries pointing to pg_class are
      considered.
      0110d7b7
  14. 18 3月, 2014 2 次提交
    • M
      Reap connections based on owning-thread death · 9e457a86
      Matthew Draper 提交于
      .. not a general timeout.
      
      Now, if a thread checks out a connection then dies, we can immediately
      recover that connection and re-use it.
      
      This should alleviate the pool exhaustion discussed in #12867. More
      importantly, it entirely avoids the potential issues of the reaper
      attempting to check whether connections are still active: as long as the
      owning thread is alive, the connection is its business alone.
      
      As a no-op reap is now trivial (only entails checking a thread status
      per connection), we can also perform one in-line any time we decide to
      sleep for a connection.
      9e457a86
    • M
      Teach PostgreSQLAdapter#reset! to actually reset · cc0d54bc
      Matthew Draper 提交于
      It wasn't doing anything beyond clearing the statement cache.
      cc0d54bc
  15. 15 3月, 2014 1 次提交
  16. 14 3月, 2014 2 次提交
  17. 12 3月, 2014 1 次提交