- 29 11月, 2017 15 次提交
-
-
由 Guillermo Iguaran 提交于
Add preload_link_tag helper.
-
由 Rafael França 提交于
Refactor Date/Time next_occurring and prev_occurring
-
由 Guillermo Iguaran 提交于
-
由 Guillermo Iguaran 提交于
-
由 Guillermo Iguaran 提交于
This helper creates a link tag with preload keyword that allows to browser to initiate early fetch of resources. Additionally this send Early Hints if supported. See https://github.com/rails/rails/pull/30744/commits/59a02fb7bcbe68f26e1e7fdcec45c00c66e4a065 for more details about Early Hints. Preload spec: https://w3c.github.io/preload/
-
由 Yuji Yaginuma 提交于
Formatting fix for example code
-
由 T.J. Schuck 提交于
Just cleaning up the formatting of the example code here to format an inline bit of commentary as a comment. Before: ![](https://monosnap.com/file/Clso8IQGOWHU3o6cStbY5NaMPx3ysP.png) After: ![](https://monosnap.com/file/QdbKKvLAeiQ0RucppVYETvaWEstnOI.png) [ci skip]
-
由 T.J. Schuck 提交于
These methods were originally added in https://github.com/rails/rails/pull/26600 This includes a couple of refactors to make these methods behave more similarly to other Date/Time extensions added by Active Support: 1. Use `advance` instead of `since` and `ago` to time-travel — this is particularly important to keep the returned instance’s class matching `self`. Before this change: today = Date.today # => Tue, 28 Nov 2017 today.class # => Date today.next_occurring(:wednesday) # => Wed, 29 Nov 2017 00:00:00 UTC +00:00 today.next_occurring(:wednesday).class # => ActiveSupport::TimeWithZone After this change, a Date (or Time, or DateTime) instance is properly returned (just like is shown in the new docs). This is generally how everything else in DateAndTime::Calculations works. 2. Move the tests from the DateTime tests to the DateAndTimeBehavior tests. The latter location is mixed in to the core_ext tests for _all_ of Date, Time, and DateTime to test the behavior across all of the classes. The previous location is for testing core_ext functionality added specifically just to DateTime. 3. Better docs!
-
由 Rafael Mendonça França 提交于
Scoping reserved names
-
由 Rafael França 提交于
[ci skip]Update docs `ActiveRecord::FinderMethods#find`
-
由 Rafael Mendonça França 提交于
Action Mailer context for example responds to request but don't have a a request object. Fixes #31265
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Fix typos and add a few suggestions
-
由 Fatos Morina 提交于
-
由 Andrew White 提交于
Fix optimized url helpers when using relative url root
-
- 28 11月, 2017 19 次提交
-
-
由 Andrew White 提交于
Fixes #31220.
-
由 Chen Kinnrot 提交于
Due to inconsistent behavior when chaining scopes and one scope named after a Relation method Validation code added in 2 places: - scope, to prevent problematic scope names. - enum, cause it tries to auto define scope.
-
由 Ryuta Kamizono 提交于
[ci skip] Update MVC wiki link
-
由 Dixit Patel 提交于
-
-
由 yuuji.yaginuma 提交于
Follow up of 924a368f
-
由 Rafael França 提交于
Include migration files in gem
-
由 yuuji.yaginuma 提交于
Fixes #31245
-
由 Sean Griffin 提交于
There are two concerns which are both being combined into one here, but both have the same goal. There are certain attributes which we want to always consider initialized. Previously, they were handled separately. The primary key (which is assumed to be backed by a database column) needs to be initialized, because there is a ton of code in Active Record that assumes `foo.id` will never raise. Additionally, we want attributes which aren't backed by a database column to always be initialized, since we would never receive a database value for them. Ultimately these two concerns can be combined into one. The old implementation hid a lot of inherent complexity, and is hard to optimize from the outside. We can simplify things significantly by just passing in a hash. This has slightly different semantics from the old behavior, in that `Foo.select(:bar).first.id` will return the default value for the primary key, rather than `nil` unconditionally -- however, the default value is always `nil` in practice.
-
由 Ryuta Kamizono 提交于
Since #31173, mysql2 adapter depends on `automatic_close` which is introduced since mysql2 0.4.3. So the adapter with the mysql2 version before doesn't work with fork now. ``` % ARCONN=mysql2 be ruby -w -Itest test/cases/connection_adapters/connection_handler_test.rb -n test_forked_child_doesnt_mangle_parent_connection Using mysql2 Run options: -n test_forked_child_doesnt_mangle_parent_connection --seed 19988 /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb:108:in `discard!': undefined method `automatic_close=' for #<Mysql2::Client:0x00007fedaa91dfd0> (NoMethodError) ``` This drops mysql2 version less than 0.4.3 to guarantee fork safety.
-
由 Rafael França 提交于
[ci skip] Fix documentation for deprecation method_wrappers
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Update Rails on Rack guide [ci skip]
-
由 Ignat Zakrevsky 提交于
Seems like version with class methods doesn't work. ```ruby require "active_support/deprecation.rb" module Fred extend self def aaa; end def bbb; end def ccc; end def ddd; end def eee; end end ActiveSupport::Deprecation.deprecate_methods(Fred, :aaa, bbb: :zzz, ccc: 'use Bar#ccc instead') Fred.aaa Fred.bbb Fred.ccc ``` # produces nothing vs ```ruby require "active_support/deprecation.rb" class Fred def aaa; end def bbb; end def ccc; end def ddd; end def eee; end end ActiveSupport::Deprecation.deprecate_methods(Fred, :aaa, bbb: :zzz, ccc: 'use Bar#ccc instead') Fred.new.aaa Fred.new.bbb Fred.new.ccc ``` produces ``` DEPRECATION WARNING: aaa is deprecated and will be removed from Rails 5.2 (called from <main> at deprications.rb:15) DEPRECATION WARNING: bbb is deprecated and will be removed from Rails 5.2 (use zzz instead) (called from <main> at deprications.rb:16) DEPRECATION WARNING: ccc is deprecated and will be removed from Rails 5.2 (use Bar#ccc instead) (called from <main> at deprications.rb:17) ```
-
由 Francis Go 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Added first draft of Rails 5.2 release notes [ci skip]
-
由 Rafael Mendonça França 提交于
This will keep the behavior of an application with the defaults of a 4.2 or 5.0 application behaving the same when upgrading to 5.2.
-
- 27 11月, 2017 6 次提交
-
-
由 yuuji.yaginuma 提交于
Since `ContentSecurityPolicy::Middleware` is not loaded in API-only Applications, initializer is unnecessary. Ref: https://github.com/rails/rails/blob/9c10fec4c06da38f8975dfb851f4d899aa85f8b7/railties/lib/rails/application/default_middleware_stack.rb#L66..L68
-
由 Prathamesh Sonpatki 提交于
-
由 Andrew White 提交于
Added missing test for presence of CSP initializer
-
由 Andrew White 提交于
Fix CHANGELOG for CSP PR #31162 [ci skip]
-
由 Prathamesh Sonpatki 提交于
-
由 Prathamesh Sonpatki 提交于
-