1. 13 9月, 2012 22 次提交
  2. 12 9月, 2012 14 次提交
  3. 11 9月, 2012 4 次提交
    • J
      ConnectionPool, unify exceptions, ConnectionTimeoutError · 5b7cfc5e
      Jonathan Rochkind 提交于
      As a result of different commits, ConnectionPool had become
      of two minds about exceptions, sometimes using PoolFullError
      and sometimes using ConnectionTimeoutError. In fact, it was
      using ConnectionTimeoutError internally, but then recueing
      and re-raising as a PoolFullError.
      
      There's no reason for this bifurcation, standardize on
      ConnectionTimeoutError, which is the rails2 name and still
      accurately describes semantics at this point.
      
      History
      
      In Rails2, ConnectionPool raises a ConnectionTimeoutError if
      it can't get a connection within timeout.
      
      Originally in master/rails3, @tenderlove had planned on removing
      wait/blocking in connectionpool entirely, at that point he changed
      exception to PoolFullError.
      
      But then later wait/blocking came back, but exception remained
      PoolFullError.
      
      Then in 02b23355 pmahoney introduced fair waiting logic, and
      brought back ConnectionTimeoutError, introducing the weird bifurcation.
      
      ConnectionTimeoutError accurately describes semantics as of this
      point, and is backwards compat with rails2, there's no reason
      for PoolFullError to be introduced, and no reason for two
      different exception types to be used internally, no reason
      to rescue one and re-raise as another.  Unify!
      5b7cfc5e
    • R
      Merge pull request #7488 from needfeed/master · 616ba15f
      Rafael Mendonça França 提交于
      Have rails dbconsole pass sslca to the mysql command line client.
      616ba15f
    • C
      Merge pull request #7569 from skorfmann/improve-has-many-through-exception-message · 82956635
      Carlos Antonio da Silva 提交于
      Improve exception message for HasManyThroughAssociationPolymorphicSourceError
      82956635
    • R
      Merge pull request #7594 from guilleiguaran/rb-template-handler · db17046b
      Rafael Mendonça França 提交于
      Add .rb template handler
      db17046b