- 28 9月, 2018 13 次提交
-
-
由 Rafael França 提交于
Fix optionally scoped root route unscoped access
-
由 Ryuta Kamizono 提交于
Revert "record who created the node when $DEBUG is true"
-
由 Rafael Mendonça França 提交于
Fixing an edge case when using objects as constraints
-
由 Simon Courtois 提交于
This PR fixes an issue when the following situation occurs. If you define a class like this class MyConstraint def call(*args) # for some reason this is defined end def matches?(*args) # checking the args end end and try to use it as a constraint get "/", to: "home#show", constraints: MyConstraint.new if its `matches?` method returns `false` there will be an error for the mapper will ask for the constraint arity, thinking it is a proc, lambda or method. This PR checks for the presence of the `arity` method on the constraint calling it only if present, preventing the error while keeping the basic behavior.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
This reverts commit a1b72178.
-
由 Ryuta Kamizono 提交于
Since Ruby 2.4 unified Fixnum and Bignum into Integer.
-
由 Ryuta Kamizono 提交于
Before: ``` Topic Update All (0.4ms) UPDATE `topics` SET `topics`.`replies_count` = COALESCE(`topics`.`replies_count`, 0) + 1, `topics`.`updated_at` = '2018-09-27 18:34:05.068774' WHERE `topics`.`id` = ? [["id", 7]] ``` After: ``` Topic Update All (0.4ms) UPDATE `topics` SET `topics`.`replies_count` = COALESCE(`topics`.`replies_count`, 0) + ?, `topics`.`updated_at` = ? WHERE `topics`.`id` = ? [["replies_count", 1], ["updated_at", 2018-09-27 18:55:05 UTC], ["id", 7]] ```
-
由 Rafael França 提交于
Add a way to check for subset of arguments when performing jobs:
-
由 Rafael França 提交于
Remove Rails 5.0 workaround from ActionCable::Channel::TestCase
-
由 Gannon McGibbon 提交于
Add missing rdoc +code+ tags [ci skip]
-
由 Gannon McGibbon 提交于
-
由 Ryuta Kamizono 提交于
Before: ``` Pet Update All (0.8ms) UPDATE `pets` LEFT OUTER JOIN `toys` ON `toys`.`pet_id` = `pets`.`pet_id` SET `pets`.`name` = 'Bob' WHERE `toys`.`name` = ? [["name", "Bone"]] ``` After: ``` Pet Update All (1.1ms) UPDATE `pets` LEFT OUTER JOIN `toys` ON `toys`.`pet_id` = `pets`.`pet_id` SET `pets`.`name` = ? WHERE `toys`.`name` = ? [["name", "Bob"], ["name", "Bone"]] ```
-
- 27 9月, 2018 21 次提交
-
-
由 Rafael França 提交于
Added ActionController::Parameters.each_value methods
-
由 Eileen M. Uchitelle 提交于
Fix `transaction` reverting for migrations
-
由 Rafael França 提交于
Add migrations_paths option to model generator
-
由 Vladimir Dementyev 提交于
The hack was merged from action-cable-testing gem by mistake. We don't need it in Rails 6. (cherry picked from commit 92030ec4b4309835ed0e792229984a1f0a044cef)
-
由 Gannon McGibbon 提交于
-
由 Ryuta Kamizono 提交于
Since counter cache handles touch option too.
-
由 Lukas Zapletal 提交于
-
由 Ryuta Kamizono 提交于
Refactor counter cache to extract `decrement_counters_before_last_save` on the belongs_to association
-
由 Ryuta Kamizono 提交于
Use -X when loading structure.sql via psql
-
由 J Smith 提交于
-
由 Ryuta Kamizono 提交于
Removed invalid -X flag for pg_dump, fixes #33996
-
由 Vladimir Dementyev 提交于
ActionCable::Channel::TestCase provides an ability to unit-test channel classes. There are several reasons to write unit/functional cable tests: - Access control (who has access to the channel? who can perform action and with which argument? - Frontend-less applications have no system tests at all–and we still need a way to test channels logic. See also #27191
-
由 Matthias Winkelmann 提交于
-
由 Edouard CHIN 提交于
- When calling `assert_performed_with`/`assert_enqueued_with`, the +args+ needs to match exactly what the job get passed. Some jobs can have lot of arguments, or even a simple hash argument has many key. This is not convenient to test as most tests doesn't need to check if the arguments matches perfectly. This PR make it possible to only check if a subset of arguments were passed to the job.
-
由 Aaron Patterson 提交于
Eagerly build the routing helper module after routes are committed
-
由 fatkodima 提交于
[fatkodima & David Verhasselt]
-
由 Aaron Patterson 提交于
* master: Remove force parent loading when counter cache child is created/destroyed Raise an error when loading all fixtures from nil fixture_path Revert "Remove `counter_cache_target` which is no longer called" Update counter cache in memory if parent target is existed If association is a hash-like object preloading fails Use the same option for create database statements between Raketask and travis.rb Fix "warning: shadowing outer local variable - config" Remove `counter_cache_target` which is no longer called Fix more offences Change the empty block style to have space inside of the block Fix a content_for test description Stringify database configurations Improve error message when assign wrong attributes to model
-
由 Aaron Patterson 提交于
-
由 Rafael França 提交于
Improve error message when assign wrong attributes to model
-
由 Aaron Patterson 提交于
Also we want to eager load routes before anything else.
-
由 Rafael França 提交于
Raise an error when loading all fixtures from nil fixture_path
-
- 26 9月, 2018 6 次提交
-
-
由 Eileen M. Uchitelle 提交于
If association is a hash-like object preloading fails
-
由 Ryuta Kamizono 提交于
`association.increment_counters` and `association.decrement_counters` works regardless of parent target is loaded or not. Related 52e11e46.
-
由 Gannon McGibbon 提交于
[Gannon McGibbon + Max Albrecht]
-
由 Ryuta Kamizono 提交于
This reverts commit 376ffe0e. Since 38fae1f2, `association.increment_counters` is called without inflated parent target if inverse_of is disabled. In that case, that commit would cause extra queries to inflate parent.
-
由 Ryuta Kamizono 提交于
Fixes #19550.
-
由 Bohdan Pohorilets 提交于
If you pass a hash-like object to preload associations (for example ActionController::Parameters) preloader will fail with the ArgumentError. This change allows passing objects that may be converted to a Hash or String into a preloader
-