- 29 12月, 2013 2 次提交
-
-
由 Piotr Sarnacki 提交于
Rubinius has problems with bundling when shared gems are disabled (ie. when --path or --deployhment is used). There is no real reason to install it with --path on TravisCI, so I'm dropping it.
-
由 Xavier Noria 提交于
The contract of blank? and present? was in principle to return Object, as we generally do, the test suite and description was consistent with that, but some examples had comments like "# => true". This cannot be unclear, we either fix the examples, or update the contract. Since users may be already assuming singletons due to the examples and the fact that they were returned before 30ba7ee5, the safest option seems to be to revise the contract and the implementation of String#blank? The motivation for 30ba7ee5 was to improve the performance of the predicate, the refactor based on === is on par regarding speed. With this commit we start documenting return types using YARD conventions. We plan to document return types gradually.
-
- 28 12月, 2013 9 次提交
-
-
由 Xavier Noria 提交于
String#blank? returns True/False
-
由 Paul Nikitochkin 提交于
-
由 Yves Senn 提交于
Removed warnings: setting `changed_attributes` instance variable if it is already initialized.
-
由 Kuldeep Aggarwal 提交于
-
由 Arun Agrawal 提交于
Typo fix [ci skip]
-
由 Ilja Krijger 提交于
-
由 Guillermo Iguaran 提交于
-
由 Yves Senn 提交于
Copy changed_attributes across to newly become'd records
-
由 Norman Clarke 提交于
6.3.0 was released on September 30, 2013. http://unicode-inc.blogspot.com.ar/2013/09/announcing-unicode-standard-version-63.html
-
- 27 12月, 2013 13 次提交
-
-
由 Jonathan del Strother 提交于
Without this, the original record's values won't get saved, since the partial insertions support (https://github.com/rails/rails/commit/144e8691cbfb8bba77f18cfe68d5e7fd48887f5e) checks for changed values and thinks there are none.
-
由 Yves Senn 提交于
Ensure backward compatibility between Minitest 5 and 4
-
由 Robin Dupret 提交于
Define Minitest::Test in case we are running the gist under Minitest 4 and avoid relying on MiniTest::Unit::TestCase to avoid displaying warning on version five. [ci skip]
-
由 Yves Senn 提交于
Adding missing backslashes in active_model files so as to avoid unwanted [ci skip]
-
由 Yves Senn 提交于
-
由 aditya-kapoor 提交于
-
由 Yves Senn 提交于
rbconfig is not used in these files remove unused requires
-
由 Guillermo Iguaran 提交于
Minitest::Unit::TestCase is Minitest::Test [ci skip]
-
由 Arun Agrawal 提交于
-
由 Arun Agrawal 提交于
remove unused requires
-
由 Jeremy Kemper 提交于
Use String#scrub when available to tidy bytes
-
由 Arun Agrawal 提交于
Fixed typo in Rails 4.1 Release Notes [CI skip]
-
由 Semenyk Dmitriy 提交于
-
- 26 12月, 2013 15 次提交
-
-
由 Norman Clarke 提交于
-
由 Xavier Noria 提交于
Improve font of some code in API documentation [ci skip]
-
由 Chun-wei Kuo 提交于
* Add "<tt>" or "+" to improve font of some code and filenames in API documentation * Does not contain wording changes
-
由 Godfrey Chan 提交于
Updated documentation for Attribute Methods [ci skip]
-
由 Guillermo Iguaran 提交于
Partial fix of database url tests
-
由 schneems 提交于
-
由 schneems 提交于
-
由 schneems 提交于
Right now `db:drop` depends on `load_config` since so when `db:drop` gets executed `load_config` gets run. `db:structure:load` depends on `[:environment, :load_config]`. So before it runs, it executes `environment` but because `load_config` has already executed it is skipped. Note `db:load_config` is "invoke"-d twice, but only "execute"-d once: ``` ** Invoke db:drop (first_time) ** Invoke db:load_config (first_time) ** Execute db:load_config ** Execute db:drop ** Invoke db:structure:load (first_time) ** Invoke environment (first_time) ** Execute environment ** Invoke db:load_config ** Execute db:structure:load ``` The fix for this is making sure that the environment is run before any `load_config`: ``` ** Invoke environment (first_time) ** Execute environment ** Invoke db:drop (first_time) ** Invoke db:load_config (first_time) ** Execute db:load_config ** Execute db:drop ** Invoke db:structure:load (first_time) ** Invoke environment ** Invoke db:load_config ** Execute db:structure:load ```
-
由 schneems 提交于
Prior to #13463 when `DATABASE_URL` was set, Rails automagically used that value instead of the database.yml. There are tests in dbs_test that expect this to still be true. After that PR, `RAILS_DATABASE_URL` is expected to be read into the YAML file via ERB, this PR fixes that behavior. Note: this does not entirely fix the tests. It seems that `ActiveRecord::Tasks::DatabaseTasks.current_config` does not process the url string correctly (convert it into a hash), and ` ActiveRecord::Tasks::DatabaseTasks.structure_load(current_config, filename)` as well as other methods in `DatabaseTasks` expect a hash. It seems like we should involve the resolver somewhere in this process to correctly convert the database url, I do not know the best place for that /cc @josevalim
-
由 Guillermo Iguaran 提交于
-
由 Guillermo Iguaran 提交于
Fix railties warnings
-
由 Łukasz Strzałkowski 提交于
Warning: DEPRECATION WARNING: Passing a string to ActiveRecord::Base.establish_connection for a configuration lookup is deprecated, please pass a symbol (:development) instead.
-
由 Łukasz Strzałkowski 提交于
Warning: ~/projects/rails/activerecord/lib/active_record/railtie.rb:140: warning: method redefined; discarding old extend_message ~/projects/rails/activerecord/lib/active_record/errors.rb:104: warning: previous definition of extend_message was here
-
由 Guillermo Iguaran 提交于
Move mysql2 test for when adapter will be loaded
-
由 Guillermo Iguaran 提交于
-
- 25 12月, 2013 1 次提交
-
-
由 aditya-kapoor 提交于
Added Backslashes to ActiveModel::AttributeMethods to prevent unwanted links in the rdoc + some other doc fixes.[ci skip]
-