- 02 8月, 2019 12 次提交
-
-
由 Daniel Colson 提交于
no_color! is already defined in [`Rails::Command::Behavior`][behavior], which gets [included into `Rails:Generators`][include]. This duplication came about in 6813edc7 when we introduced the Thor command structure. We have [test coverage][] to ensure this method still behaves correctly on `Rails:Generators`. [behavior]: https://github.com/rails/rails/blob/f7e91c7224560fbd3e95c238a0e8bb362799bcb7/railties/lib/rails/command/behavior.rb#L12-L14 [include]: https://github.com/rails/rails/blob/f7e91c7224560fbd3e95c238a0e8bb362799bcb7/railties/lib/rails/generators.rb#L18 [test coverage]: https://github.com/rails/rails/blob/f7e91c7224560fbd3e95c238a0e8bb362799bcb7/railties/test/generators_test.rb#L163-L168
-
由 Ryuta Kamizono 提交于
Add tests for selecting aggregrates
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
This hack prevails everywhere in the codebase by being copy & pasted, and it's actually not a negative thing but a necessary thing for framework implementors, so it should better have a name and be a thing. And with this commit, activesupport/test/abstract_unit.rb now doesn't silently autoload AS::TestCase, so we're ready to establish clearner environment for running AS tests (probably in later commits)
-
由 Akira Matsuda 提交于
It's used everywhere, clean and mature enough
-
由 Ryuta Kamizono 提交于
Deduplicate joins values
-
由 Ryuta Kamizono 提交于
#36805 have one possible regression that failing deduplication if `joins_values` have complex order (e.g. `joins_values = [join_node_a, :comments, :tags, join_node_a]`). This fixes the deduplication to take it in the first phase before grouping.
-
由 Godfrey Chan 提交于
These tests verifies that aggregates like `AVG` can be selected as "virtual attributes" on Active Record models and have the correct column type.
-
由 Ryuta Kamizono 提交于
-
- 01 8月, 2019 19 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Carlos Antonio da Silva 提交于
Added missing comment notation for the example of form_with in form_helpers.md documentation. [ci skip]
-
由 Akshay Mohite 提交于
Added missing comment notation for the example of form_with in form_helpers.md documentation. [ci skip]
-
由 Akira Matsuda 提交于
This causes "NameError: undefined local variable or method `nsec' for #<DateTime:0x0000559163cdd878>"
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
In most cases it works now without explicit require because it's accidentally required through active_support/core_ext/date_and_time/calculations.rb where we still call `try`, but that would stop working if we changed the Calculations implementation and remove the require call there.
-
由 Akira Matsuda 提交于
and Git taught me that this crap was added via this commit... https://github.com/rails/rails/commit/68db6bc431fbff0b2291f1f60ccf974b4eece596
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Vipul A M 提交于
Fixed a typo in documentation example of activerecord database configuration. [ci skip]
-
由 Akshay Mohite 提交于
- The example has sqlite3 adpater in database.yml, whereas configuration object had incorrectly specified mysql2 in documentation.
-
由 yuuji.yaginuma 提交于
This fixes the following warnings. ``` actionmailer/test/base_test.rb:272: warning: method redefined; discarding old welcome actionmailer/test/base_test.rb:260: warning: previous definition of welcome was here ```
-
由 Gannon McGibbon 提交于
Upload filename and disposition for Azure
-
由 Peter Zhu 提交于
-
由 Eileen M. Uchitelle 提交于
Prevent error on transliterate with frozen strings
-
由 Gannon McGibbon 提交于
Upload with filename and disposition for S3
-
由 Eileen M. Uchitelle 提交于
Fix db:seed
-
由 eileencodes 提交于
The `rake db:seed` command was broken for the primary environment if the application is using multiple databases. We never implemented `rake db:seed` for other databases (coming soon), but that shouldn't break the default case. The reason this was broken was because `abort_if_pending_migrations` would loop through the configs for all databases and check for migrations but would leave the last established connection. So `db:seed` was looking in the wrong database for the table to seed. This PR doesn't fix the fact that `db:seed` doesn't work for multiple databases but does fix the default case. Fixes #36817 Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
-
由 Cliff Pruitt 提交于
ActiveSupport::Inflector.transliterate mutates strings by changing encodings. Prior to this commit passing a frozen string would raise a `FrozenError`. This change duplicates the internal string, if frozen, before transliterating.
-
- 31 7月, 2019 9 次提交
-
-
由 Peter Zhu 提交于
-
由 Ryuta Kamizono 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-