1. 06 3月, 2018 4 次提交
  2. 05 3月, 2018 6 次提交
  3. 04 3月, 2018 3 次提交
  4. 03 3月, 2018 1 次提交
  5. 02 3月, 2018 6 次提交
  6. 28 2月, 2018 5 次提交
  7. 27 2月, 2018 4 次提交
    • K
      Fix `#columsn_for_distinct` of MySQL and PostgreSQL · 2d48268d
      kg8m 提交于
      Prevent `ActiveRecord::FinderMethods#limited_ids_for` from using correct primary
      key values even if `ORDER BY` columns include other table's primary key.
      
      Fixes #28364.
      2d48268d
    • R
      Partly revert 91b30a00 · 19672421
      Ryuta Kamizono 提交于
      Actually `reflection.klass` should be valid AR model unless
      `polymorphic?`. Previously it worked limitedly by ignoring `NameError`
      even if `reflection.klass` is invalid, and our isolated testing depends
      on the limited working.
      Probably we should also check the klass validity in `check_validity!`
      properly. Until that time, I restored the error suppression for now.
      
      Closes #32113.
      19672421
    • S
      Ensure we don't write virtual attributes on update, too · c2a2b84d
      Sean Griffin 提交于
      See 948b9319 for context
      c2a2b84d
    • S
      Never attempt to write virtual attributes to the database · 948b9319
      Sean Griffin 提交于
      Currently the place where we limit what gets sent to the database is in
      the implementation for `partial_writes`. We should also be restricting
      it to column names when partial writes are turned off.
      
      Note that we're using `&` instead of just defaulting to
      `self.class.column_names`, as the instance version of `attribute_names`
      does not include attributes which are uninitialized (were not included
      in the select clause)
      948b9319
  8. 26 2月, 2018 3 次提交
  9. 23 2月, 2018 5 次提交
  10. 22 2月, 2018 3 次提交
    • A
      Properly escape column name embedded into regexp · d53b259a
      Andreas Bühmann 提交于
      SQLServerAdapter (gem `activerecord-sqlserver-adapter`) uses square
      brackets for quoting column names (e.g. `[id]`). Those brackets must not
      be misinterpreted in regular expressions.
      
      Failure:
      Expected /SELECT [developers].[id].* FROM developers/ to match "SELECT [developers].[id], [developers].[name], [developers].[salary], [developers].[firm_id], [developers].[mentor_id], [developers].[created_at], [developers].[updated_at], [developers].[created_on], [developers].[updated_on] FROM developers".
      d53b259a
    • A
      9c0c9097
    • E
      Call `YAML.load` correctly · 63d530c5
      eileencodes 提交于
      We should call methods with `.method_name` not `::method_name`. Fix two
      instances of `YAML::load` I found in favor of `YAML.load`.
      63d530c5