This reverts commit 9d396ee8, reversing
changes made to fa2bfd83.

Reason: the change broke the build.

Simplify the test by using id and name. `id` will be the only real sort criteria in any case as it's unique.

This reverts commit 9d396ee8, reversing
changes made to fa2bfd83.

Reason: the change broke the build.

Simplify the test by using id and name. `id` will be the only real sort criteria in any case as it's unique.

Use latest Arel syntax and pass each order by expression as separate argument to order method as otherwise invalid Oracle SQL is generated.

* Only on postgresql, order("first asc, second asc") was invalid
* Closes #1720

Refactor Active Record test connection setup. Please see the RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases.

Addresses an inconsistency in the ActiveRecord::Base.method_missing handling of dynamic finder methods and the passing of the &block parameter for :find_by_attributes.

Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

The test fails on PostgreSQL when trying to load the records as
the comments_count field is not included in the GROUP BY clause.

[#5829 state:resolved]
Signed-off-by: NAndrew White <andyw@pixeltrix.co.uk>

Referencing a table via the ON condition in a join should force that table to be eager-loaded via a JOIN rather than via subsequent queries.

Referencing a table via the ON condition in a join should force that table to be eager-loaded via a JOIN rather than via subsequent queries.

removed an unnecessary second query when passing an ActiveRecord::Relation to a where clause.  And added ability to use subselects in where clauses.

ActiveRecord::Relation#primary_key should return a string, just like ActiveRecord::Base.primary_key does.

Let AssociationCollection#find use #scoped to do its finding. Note that I am removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences.

Fix test_any in relations_test.rb, which was failing when relations_test.rb is run on its own (it passes when the entire suite is run). This is a hacky fix for a problem I didn't quite get to the bottom of, so I'd welcome a better solution...

* rename method names (actually in tests)
* rename instance variable @_named_scopes_cache to @_scopes_cache
* rename references in doc comments
* don't touch CHANGELOG :)

[#6022 state:resolved]

When use where more than once on the same column, relation doesn't do an 'or' or 'in' with the values