1. 11 8月, 2015 1 次提交
    • A
      Dont try to call method missing in routes if thats not what we want · 0ffaa56d
      Arthur Neves 提交于
      If, doing a test like this:
      
      ```
      class BugTest < ActionView::TestCase
        def test_foo
          omg
        end
      ```
      
      Will raise with:
      ```
      RuntimeError: In order to use #url_for, you must include routing helpers
      explicitly. For instance, `include
      Rails.application.routes.url_helpers`.
      ```
      
      Thats a bit confusing, as we are not calling url_for at all.
      0ffaa56d
  2. 10 8月, 2015 15 次提交
  3. 09 8月, 2015 19 次提交
  4. 08 8月, 2015 5 次提交
    • E
      Refactor route assertion methods in resources test · 286cb890
      eileencodes 提交于
      The tests and methods were hard to read with `options[:options]` all
      over the place. This refactoring makes the code easier to understand.
      
      The change came out of work for moving the underlying code of controller
      tests to integraiton tests.
      286cb890
    • R
      Merge pull request #11352 from xaviershay/dispatcher-api · d919fd88
      Rafael Mendonça França 提交于
      Allow a custom dispatcher to be provided to routing.
      d919fd88
    • E
      Fix deprecation warning in tests · 12f08acb
      eileencodes 提交于
      Using the string version of the class reference is now deprecated when
      referencing middleware. This should be written as a class not as a string.
      
      Deprecation warning that this change fixes:
      ```
      DEPRECATION WARNING: Passing strings or symbols to the middleware
      builder is deprecated, please change
      them to actual class references.  For example:
        "ActionDispatch::ShowExceptions" => ActionDispatch::ShowExceptions
      ```
      12f08acb
    • E
      Rename `extra_keys` variables to `query_string_keys` · e7dd9069
      eileencodes 提交于
      `extra_keys` is a confusing variable name because it's not clear what is
      "extra". This renames it to `query_string_keys` so it's clear that the
      "extra" is just the query string.
      e7dd9069
    • E
      Refactor to remove DrawOnce module · c8b82955
      eileencodes 提交于
      We were doing extra work that could be pushed off to Integration test
      and SharedRoutes. Creating an extra module isn't necessary when those
      are created by their respective classes.
      c8b82955