- 22 10月, 2015 1 次提交
-
-
由 Konstantinos Rousis 提交于
-
- 27 8月, 2015 1 次提交
-
-
由 Aaron Patterson 提交于
Since all controller instances are required to have a request and response object, RackDelegation is no longer needed (we always have to delegate to the response)
-
- 24 8月, 2015 1 次提交
-
-
由 Marcin Olichwirowicz 提交于
-
- 18 7月, 2015 1 次提交
-
-
由 Prem Sichanugrist 提交于
This will silence deprecation warnings. Most of the test can be changed from `render :text` to render `:plain` or `render :body` right away. However, there are some tests that needed to be fixed by hand as they actually assert the default Content-Type returned from `render :body`.
-
- 16 6月, 2015 1 次提交
-
-
由 Mehmet Emin İNAÇ 提交于
-
- 12 6月, 2015 1 次提交
-
-
由 Jorge Bejar 提交于
-
- 28 5月, 2015 1 次提交
-
-
由 Mehmet Emin İNAÇ 提交于
`head` method works similar to `render` method with `:nothing` option
-
- 13 3月, 2015 1 次提交
-
-
由 Joel Hayhurst 提交于
It was returning false in normal circumstances. This broke the `head :ok and return if` construct. Add appropriate test.
-
- 16 2月, 2015 1 次提交
-
-
由 Arthur Neves 提交于
Add http_cache_forever to ActionController, so we can cache results forever. Things like static pages are a good candidate for this type of caching. This cache only controls caching headers, so it is up to the browser to cache those requests.
-
- 11 2月, 2015 2 次提交
-
-
由 claudiob 提交于
The methods `fresh_when` and `stale?` from ActionController::ConditionalGet accept a single record as a short form for a hash. For instance ```ruby def show @article = Article.find(params[:id]) fresh_when(@article) end ``` is just a short form for: ```ruby def show @article = Article.find(params[:id]) fresh_when(etag: @article, last_modified: @article.created_at) end ``` This commit extends `fresh_when` and `stale?` to also accept a collection of records, so that a short form similar to the one above can be used in an `index` action. After this commit, the following code: ```ruby def index @article = Article.all fresh_when(etag: @articles, last_modified: @articles.maximum(:created_at)) end ``` can be simply written as: ```ruby def index @article = Article.all fresh_when(@articles) end ```
-
由 claudiob 提交于
PR #18772 changed the parameters of `stale?` to use `kwargs`. [As for this comment](https://github.com/rails/rails/pull/18872/files#r24456288) the default value for the `etag` parameter should be `record`, not `nil`. This commit fixes the code and introduces a test that: - passed before #18872 - fails on the current master (after #18772) - passes again after setting the default value of `etag` to `record`.
-
- 29 1月, 2015 1 次提交
-
-
由 Kir Shatrov 提交于
Non-kwargs requests are deprecated now. Guides are updated as well. `post url, nil, nil, { a: 'b' }` doesn't make sense. `post url, params: { y: x }, session: { a: 'b' }` would be an explicit way to do the same
-
- 12 1月, 2015 1 次提交
-
-
由 claudiob 提交于
When `render` was moved from ActionPack to ActionView in acc8e259, some fixtures required by the tests were duplicated, but they are actually only required by ActionView tests. To give one example, `double_render` is already defined [in the AV tests](https://github.com/rails/rails/blob/72139d8d310d896db78eaec98582c7a638135102/actionview/test/actionpack/controller/render_test.rb#L407) and is never used in the ActionPack tests.
-
- 31 12月, 2014 1 次提交
-
-
由 Robin Dupret 提交于
Commit 20fece14 introduced the `_status_code` method to fix calls to `head :ok`. This method has been added on both ActionController::Metal and ActionDispatch::Response. As for the latter, this method is just equivalent to the `response_code` one so commit aefec3c6 removed it from the `Reponse` object so call to the `_status_code` method on an ActionController::Base instance would be handled by the `Metal` class (which `Base` inherits from) but the status code is not updated according to the response at this level. The fix is to actually rely on `response_code` for ActionController::Base instances but this method doesn't exist for bare Metal controllers so we need to define it.
-
- 17 8月, 2014 1 次提交
-
-
由 Jeremy Kemper 提交于
New default: the template digest is automatically included in your ETags. When you call `fresh_when @post`, the digest for `posts/show.html.erb` is mixed in so future changes to the HTML will blow HTTP caches for you. This makes it easy to HTTP-cache many more of your actions. If you render a different template, you can now pass the `:template` option to include its digest instead: fresh_when @post, template: 'widgets/show' Pass `template: false` to skip the lookup. To turn this off entirely, set: config.action_controller.etag_with_template_digest = false
-
- 06 6月, 2014 2 次提交
-
-
由 Guo Xiang Tan 提交于
-
由 Guo Xiang Tan 提交于
-
- 05 12月, 2013 1 次提交
-
-
由 Carlos Antonio da Silva 提交于
-
- 25 8月, 2013 2 次提交
-
-
由 Łukasz Strzałkowski 提交于
-
由 Łukasz Strzałkowski 提交于
This interface should be use when implementing renderers.
-
- 18 8月, 2013 1 次提交
-
- 26 7月, 2013 1 次提交
-
-
由 Akira Matsuda 提交于
Reset ActionView::Base.logger after tests
-
- 19 6月, 2013 1 次提交
-
-
由 Stephen Becker IV 提交于
-
- 07 5月, 2013 1 次提交
-
-
- 06 1月, 2013 2 次提交
-
-
由 Akira Matsuda 提交于
-
由 Yves Senn 提交于
They don't add any benefits over `assert object.blank?` and `assert object.present?`
-
- 31 12月, 2012 1 次提交
-
-
由 Yves Senn 提交于
1) Failure: test_head_created_with_image_png_content_type(RenderTest) [test/controller/render_test.rb:1238]: Expected: "image/png" Actual: "image/png; charset=utf-8"
-
- 20 12月, 2012 1 次提交
-
-
由 SHIBATA Hiroshi 提交于
-
- 08 12月, 2012 1 次提交
-
-
由 Francesco Rodriguez 提交于
-
- 20 11月, 2012 1 次提交
-
-
由 Yves Senn 提交于
This resolves issues when rendering nested partials. Previously the `PartialRenderer` was reused which led to situations where the state of the renderer was reset. Closes #8197
-
- 06 10月, 2012 1 次提交
-
-
由 Yves Senn 提交于
the documentation on #assert_template states that the :locals option is only available in view test cases: # In a view test case, you can also assert that specific locals are passed # to partials: I added a warning when it's passed in an inapropriate context to prevent a NoMethodError.
-
- 30 8月, 2012 1 次提交
-
-
由 David Heinemeier Hansson 提交于
Added controller-level etag additions that will be part of the action etag computation *Jeremy Kemper/DHH*
-
- 01 8月, 2012 1 次提交
-
- 21 6月, 2012 1 次提交
-
-
由 Arun Agrawal 提交于
1. Change in test name as already defined. 2. ambiguous first argument; put parentheses or even spaces
-
- 19 6月, 2012 2 次提交
-
-
由 Dmitry Vorotilin 提交于
Added test for case when view doesn't have logger method when using ActionController::Metal controller.
-
由 James Tucker 提交于
There are several aspects to this commit, that don't well fit into broken down commits, so they are detailed here: * When a user uses response.headers['Cache-Control'] = some_value, then the documented convention in ConditionalGet is not adhered to, in this case, response.cache_control is ignored due to `return if self[CACHE_CONTROL].present?` * When a middleware sets cache-control headers that would clobber, they're converted to symbols directly, without underscores. This would lead to bugs. * Items that would live in :extras if set through expires_in, are placed directly in the @cache_control hash, and not respected in many cases (somewhat adhering to the aforementioned documentation). * Although quite useless, any directive named 'extras' would be ignored. The general convention applied is that expires_* take precedence, but no longer overwrite everything and expires_* are ALWAYS applied, even if the header is set. I am still unhappy about the contents of this commit, and the code in general. Ideally it should be refactored to no longer use :extras. I'd likely recommend expanding @cache_control into a class, and giving it the power to handle the merge in a more efficient fashion. Such a commit would be a larger change that could have additional semantic changes for other libraries unless they utilize expires_in in very standard ways.
-
- 08 5月, 2012 1 次提交
-
-
由 Kunal Shah 提交于
Add failing test re #3436 which demonstrates content_type is not respected when using the :head method/shortcut
-
- 25 4月, 2012 1 次提交
-
-
由 Jose and Yehuda 提交于
In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964
-
- 29 3月, 2012 1 次提交
-
-
由 Santiago Pastorino 提交于
Closes #5632
-
- 27 3月, 2012 1 次提交
-
-
由 Piotr Sarnacki 提交于
Previously `rendered_format` was set only based on mime types passed in Accept header, which was wrong if first type from Accept was different than rendered partial. The fix is to simply move setting rendered_format to the place where template is available and grab format from the template. If it fails we can fallback to formats passed by Accept header.
-