- 04 10月, 2016 6 次提交
-
-
由 Andrew White 提交于
Made ActiveRecord consistently use ActiveRecord::Type (not ActiveModel::Type)
-
由 Andrew White 提交于
Restore missing Gemfile.lock entries
-
由 Ryuta Kamizono 提交于
These lines were lost in https://github.com/rails/rails/pull/26695/files#diff-e79a60dc6b85309ae70a6ea8261eaf95L192.
-
由 Jon Moss 提交于
[ci-skip] Swap method and its alias, format doc
-
由 Andrey Molchanov 提交于
-
由 Matthew Draper 提交于
We hit when we skip the PostgreSQL adapter.
-
- 03 10月, 2016 12 次提交
-
-
由 Iain Beeston 提交于
ActiveModel::Type) Some code was previously referring to ActiveModel::Type::*. This could cause issues in the future if any of the ActiveRecord::Type classes were overridden in the future.
-
由 Eileen M. Uchitelle 提交于
Allow the use of listen's 3.1.x branch.
-
由 Esteban Santana Santana 提交于
When the initial evented monitor feature was written, the latest version of listen was the 3.0.x series. Since then the listen project has moved on to the 3.1.x series. This patch allows the use of the new versions.
-
由 Andrew White 提交于
Show an "unmatched constraints" error when params fail to match constraints
-
由 Chris Carter 提交于
Currently a misleading "missing required keys" error is thrown when a param fails to match the constraints of a particular route. This commit ensures that these params are recognised as unmatching rather than missing. Note: this means that a different error message will be provided between optimized and non-optimized path helpers, due to the fact that the former does not check constraints when matching routes. Fixes #26470.
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
Fix issue with `cache_key` when the named timestamp column has value nil
-
由 Matthew Draper 提交于
Different parts of concurrent-ruby's documentation make inconsistent claims about how kill will behave. It doesn't do the thing we want.
-
由 Matthew Draper 提交于
Shutdown pubsub connection before classes are reloaded
-
由 Andrew White 提交于
In #25880 we tried to cache localtime to fix the performance regression but that proved to be difficult due to the fact that localtime/getlocal can take a utc_offset argument. We tried caching based on the argument but since the argument can be nil sometimes that meant that if the TZ environment variable changed then the cached value for nil became invalid. By moving the caching to DateAndTime#compatibility we don't have to worry about arguments since it doesn't take any. There is a possible edge condition where preserve_timezone is set to false and the system timezone changes then it could result in a cached value being incorrect but the only way to fix this would be to remove all caching and live with the performance issue.
-
由 Andrew White 提交于
Turns out trying to cache on localtime with arguments is too hard so we'll do it on DateAndTime::Compatibility#to_time instead. This reverts commit 3132fa6b, reversing changes made to 6949f8e5.
-
由 Andrew White 提交于
Turns out trying to cache on localtime with arguments is too hard so we'll do it on DateAndTime::Compatibility#to_time instead. This reverts commit 9ce2d1b1, reversing changes made to 53ede1af.
-
- 02 10月, 2016 12 次提交
-
-
由 Jon Moss 提交于
-
由 Jon Moss 提交于
-
由 Jon Moss 提交于
Before this patch, if you were to make a file edit in your Rails application and you tried to load up the page, it would hang indefinitely. The issue is that Active Record is trying to cleanup after itself and clear all active connection, but Action Cable is still holding onto a connection from the pool. To resolve this, we are now shutting down the pubsub adapter before classes are reloaded, to avoid this altogether (connection is being returned to the pool). Credits to @skateman for discovering this bug. :)
-
由 Jon Moss 提交于
add `cached` key to `sql.active_record` event [ci skip]
-
由 Matthew Draper 提交于
Avoid compiling ruby keywords into template locals
-
由 Peter Schilling 提交于
this lets you pass ruby keywords to templates: <%= render 'example', class: "cool" %> <%= render 'example', "spaces are" => "a-ok" %> <%= render 'example', Foo: "bar" %> Previously you'd see confusing syntax errors like this: SyntaxError (.../_example.html.erb:1: syntax error, unexpected '=' Now you can reference invalid identifiers through local_assigns. If you try to use an invalid keyword (e.g. class) in your template, you get a syntax error on the line where you use it.
-
由 yuuji.yaginuma 提交于
Follow up to #26584
-
由 Matthew Draper 提交于
Use websocket-client-simple instead of Faye in tests
-
由 Matthew Draper 提交于
Mostly, this is just to avoid EventMachine. But there's also an argument to be made that we're better off using a different protocol library for our test suite than the one we use to implement the server.
-
由 Matthew Draper 提交于
-
由 Andrew White 提交于
Fix `ActiveSupport::TimeWithZone#localtime`
-
由 Matthew Draper 提交于
Add missing require for zlib in ActiveRecord::Migrator
-
- 01 10月, 2016 10 次提交
-
-
由 Lars Kanis 提交于
Zlib is used to generate the advisory lock since commit 2c2a8755 . Using the Migrator fails since then, when it is called without the rails context: NameError: uninitialized constant ActiveRecord::Migrator::Zlib This patch fixes the above error.
-
由 Andrew White 提交于
The class-level respond_to was extracted in ee77770d to responders gem [ci skip]
-
由 Thomas Balthazar 提交于
Previously memoization in `localtime` wasn't taking the `utc_offset` parameter into account when returning a cached value. It now caches the computed value depending on the `utc_offset` parameter, e.g: Time.zone = "US/Eastern" t = Time.zone.local(2016,5,2,11) # => Mon, 02 May 2016 11:00:00 EDT -04:00 t.localtime(-7200) # => 2016-05-02 13:00:00 -0200 t.localtime(-3600) # => 2016-05-02 14:00:00 -0100
-
由 Matthew Draper 提交于
Remove Faye mode
-
由 Matthew Draper 提交于
We've seen occasional Travis failures mentioning deadlocks. I think they're escaping from this test.
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
No deprecation, because it was never documented.
-
由 Matthew Draper 提交于
Avoid race condition on subscription confirmation
-
由 Jon Moss 提交于
Remove dup distinct from AR query list doc [ci skip]
-
由 Jeremy Wilmot 提交于
-