- 19 1月, 2019 3 次提交
-
-
由 Aaron Patterson 提交于
Rather than doing is_a? checks, ask the view object for its compiled method container. This gives us the power to replace the method container depending on the instance of the view.
-
由 Aaron Patterson 提交于
We always want to include this module. It'll be used in production (maybe)
-
由 Aaron Patterson 提交于
This patch removes the instance writer of view_context_class. Subclasses may override it, but it doesn't need to be written. This also eliminates the need to cache the return value of the class level `view_context_class` method.
-
- 18 1月, 2019 2 次提交
-
-
由 Aaron Patterson 提交于
It's always called with 0 params, so just remove the parameter
-
由 Aaron Patterson 提交于
-
- 17 1月, 2019 4 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Since everything goes through a `run` method, we can pull the buffer assignment up.
-
由 Aaron Patterson 提交于
Methods created by views should always be evaluated against an AV::Base instance. This way we can extract and refactor things in to classes.
-
由 Aaron Patterson 提交于
This pulls the "output buffer existence" conditional up. Instead of evaling the same conditional over and over, we can pull it in to "only compiled once" Ruby code.
-
- 16 1月, 2019 2 次提交
-
-
由 Kasper Timm Hansen 提交于
Allows the releaser to verify that: - A rich text description can be edited and shown *richly*. - An image/PDF can be uploaded and generate a variant that's shown. Also moves the generated app to a tmp directory for less cleanup need.
-
由 Kasper Timm Hansen 提交于
-
- 15 1月, 2019 17 次提交
-
-
由 Laerti 提交于
This PR addresses the issue described in #28025. On `dependent: :nullify` strategy only the foreign key of the relation is nullified. However on polymorphic associations the `*_type` column is not nullified leaving the record with a NULL `*_id` but the `*_type` column is present.
-
由 Ryuta Kamizono 提交于
The `@prevent_writes` should be updated only in the `while_preventing_writes`, it is not necessary to expose the attr writer.
-
由 Ryuta Kamizono 提交于
This attr writer was introduced at 7db90aa7, but the usage is already removed at bd2f5c06 before v3.2.0.rc1 is released. If we'd like to customize the visitor in the connection, `arel_visitor` which is implemented in all adapters (mysql2, postgresql, sqlite3, oracle-enhanced, sqlserver) could be used for the purpose #23515.
-
由 Ryuta Kamizono 提交于
This class is no longer used since 9cbfc8a3.
-
由 Rafael França 提交于
Add mention to the main README about new libraries [ci skip]
-
由 Rafael França 提交于
Document the ActionCable JS changes in the upgrade guide and release notes
-
由 Richard Macklin 提交于
-
由 Rafael França 提交于
Allow strong params in ActiveRecord::Base#exists?
-
由 Krzysztof Rybka 提交于
* Calculate first month of quarter instead of finding * Calculate last month of quarter instead of finding [Krzysztof Rybka + Rafael Mendonça França]
-
由 Rafael França 提交于
Clean up ActionCable JS a bit more after the CoffeeScript conversion
-
由 Kasper Timm Hansen 提交于
Restructure credentials after environment overrides.
-
由 Richard Macklin 提交于
in Connection#close. We can do this because `isActive()` can only return `true` if `this.webSocket` is truthy. (We can't have an active connection without having instantiated a WebSocket. This is confirmed in the code: Connection#isActive calls Connection#isState which calls Connection#getState, which checks if `this.webSocket` is truthy and returns `null` otherwise.)
-
由 Kasper Timm Hansen 提交于
Add Action Cable testing guides and generators
-
由 Richard Macklin 提交于
by relying on the implicit undefined return value
-
由 Richard Macklin 提交于
-
由 Kasper Timm Hansen 提交于
Follow up to: e0d3313b - Revert renames from `encrypted` and `encrypted_file` back to `credentials`. They might be using our Encrypted* generators but from that level of abstraction they're still about credentials. - Same vein: extract a `credentials` method for the `encrypted` local variable. But don't call it `encrypted` just because it uses that under the hood. It's about capturing the credentials. It's also useful in `change_credentials_in_system_editor`. - Remove lots of needless argument passing. We've abstracted content_path and key_path into methods for a reason, so they should be used. Also spares a conspicuous rename of content_path into file_path in other methods. - Reorders private methods so they're grouped into: command building blocks, option parsers, and the generators. - Extracts commonality in the credentials application tests. A tad unsure about this. But I do like that we go with key, content thus matching the command and remove the yield which isn't really needed. - Moves test/credentials_test.rb to beneath the test/application directory. It's a Rails application test, so it should be in there. - Uses `root.join` — a neat trick gleaned from the tests! — and composes the configuration private methods such that the building block is below the callers.
-
由 Vladimir Dementyev 提交于
-
- 14 1月, 2019 9 次提交
-
-
由 Vladimir Dementyev 提交于
-
由 Vladimir Dementyev 提交于
-
由 Kasper Timm Hansen 提交于
* Don't reimplement assert_raises Also test what happens in case there's no explicit rejection. * Avoid OpenStruct. Remove space beneath private. * Simplify verification methods for code under test. * Match documentation with other Rails docs. Also remove mention of the custom path argument for now. Unsure how useful that really is.
-
由 Ryuta Kamizono 提交于
Fix "Action Cable Overview" guide [ci skip]
-
由 bogdanvlviv 提交于
Fix path to channel files. `rails generate channel Chat` generates `app/javascript/channels/chat_channel.js`. See also, railties/lib/rails/generators/rails/app/templates/app/javascript/packs/application.js.tt, actioncable/lib/rails/generators/channel/templates/javascript/index.js.tt by default `application.js` imports "channels", where `app/javascript/channels/index.js` loads all the channels within this directory and all subdirectories. Follow up #34709 Related to #33079
-
由 Ryuta Kamizono 提交于
Merge `actioncable/README.md` to the Action Cable Overview guide [ci skip]
-
由 bogdanvlviv 提交于
Action Mailbox and Action Text belong to rails/rails since #34786 and #34873.
-
由 bogdanvlviv 提交于
In #34709 we updated the guide, but `actioncable/README.md` is still outdated. Instead of fixing content in the file. I suggest not duplicate the info that is already in the guide and instead remove the info from the file and just add a message: "You can read more about Action Cable in the [Action Cable Overview](https://edgeguides.rubyonrails.org/action_cable_overview.html) guide." The same approach is being used for Action Mailbox and Action Text, see #34812 and #34878.
-
由 Kasper Timm Hansen 提交于
Add ActionCable::Connection::TestCase
-
- 13 1月, 2019 1 次提交
-
-
由 George Claghorn 提交于
-
- 12 1月, 2019 2 次提交
-
-
由 Ryuta Kamizono 提交于
And support endless ranges for `not_between` like as `between`. Follow up #34906.
-
由 Aaron Patterson 提交于
-