- 06 9月, 2016 3 次提交
-
-
由 yui-knk 提交于
Bang methods of `AR::QueryMethods` are used only internally. We only use `left_outer_joins!`, so we can remove this alias.
-
由 Andrew White 提交于
Move `require "models/post"` before `require "models/comment"`
-
由 Andrew White 提交于
use `descendants` to get class that inherited `ActiveJob::Base`
-
- 05 9月, 2016 4 次提交
-
-
由 Andrew White 提交于
Remove unnecessary `query_scope`
-
由 Vipul A M 提交于
change `Class#descendants` to public API [ci skip]
-
由 yuuji.yaginuma 提交于
`Class#descendants` has already been displayed in Rails guide, so I think that may be displayed in doc. http://guides.rubyonrails.org/active_support_core_extensions.html#descendants
-
由 yuuji.yaginuma 提交于
`subclasses` get only child classes. Therefore, if create a job common parent class as `ApplicationJob`, inherited class does not get properly.
-
- 04 9月, 2016 9 次提交
-
-
由 Eileen M. Uchitelle 提交于
rename test method to avoid overriding
-
由 Eileen M. Uchitelle 提交于
Remove unnecessary `count` method for collection proxy
-
由 Eileen M. Uchitelle 提交于
make `fixture_file_upload` work in integration tests
-
由 yuuji.yaginuma 提交于
Currently, `fixture_file_upload` does not work in integration test. Because, `TestProcess` module has been include in `Session` class, but `fixture_path` can not get from `Session` class. Modify to include `TestProcess` in `IntegrationTest` class in order to get correct value of `fixture_path`.
-
由 Ryuta Kamizono 提交于
Simply use its own method because `CollectionProxy` inherits `Relation`.
-
由 Vipul A M 提交于
Update ActiveRecord callback guide for exceptions [ci skip]
-
由 Nathan Wenneker 提交于
07d3d402 changed how exceptions are handled in after_commit and after_destroy callbacks. This commit updates the 5.0 release notes and the ActiveRecord callback guide to reflect the new behavior. [ci skip]
-
由 Guillermo Iguaran 提交于
Allow download of email attachments in the Mailer Preview template.
-
由 Guillermo Iguaran 提交于
Remove blank else branch
-
- 03 9月, 2016 10 次提交
-
-
由 Yves Senn 提交于
Extract duplicated `create` and `create!` definition for association
-
由 Ryuta Kamizono 提交于
-
由 Xavier Noria 提交于
Fix broken heredoc indentation caused by rubocop auto-correct
-
由 yuuji.yaginuma 提交于
This removes the following warning. ``` ./test/dispatch/routing_test.rb:3696: warning: method redefined; discarding old test_namespaced_roots ./test/dispatch/routing_test.rb:1632: warning: previous definition of test_namespaced_roots was here ```
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
All indentation was normalized by rubocop auto-correct at 80e66cc4. But heredocs was still kept absolute position. This commit aligns heredocs indentation for consistency.
-
由 Guillermo Iguaran 提交于
add Active Job bug report templates to guide [ci skip]
-
由 yuuji.yaginuma 提交于
Follow up to #26362
-
由 jpd800 提交于
-
由 Yasuo Honda 提交于
to address BasicsTest#test_readonly_attributes failure #26368 It reproduces only when both of these conditions are satisfied: - Other test files `autosave_association_test.rb` or `where_test.rb` which executes `require "models/comment"` then `require "models/post"` - When `autosave_association_test.rb` or `where_test.rb` executed before `base_test.rb`
-
- 02 9月, 2016 12 次提交
-
-
由 Kasper Timm Hansen 提交于
fix class name typo in bug report templates for Active Job
-
由 Vipul A M 提交于
Improve Getting Started [ci skip]
-
由 Shia 提交于
-
由 yuuji.yaginuma 提交于
-
由 Guillermo Iguaran 提交于
Added bug report templates for Active Job
-
由 Prathamesh Sonpatki 提交于
-
由 प्रथमेश Sonpatki 提交于
Grammar fix
-
由 Waitaya Krongapiradee 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
- 01 9月, 2016 2 次提交
-
-
由 Andrew White 提交于
As demonstrated in #25880 the to_time method converts the utc time instance to a local time instance which is an expensive operation. Since to_datetime involves similar expensive operations we should also cache it to speed up comparison with lots of values.
-
由 Vipul A M 提交于
fix document for radio_button [ci skip]
-