- 11 11月, 2015 1 次提交
-
-
由 Christoph 提交于
According to the W3 spec[1] the value should use a 1-based index and not a 0-based index for the week number. [1]: http://www.w3.org/TR/html-markup/datatypes.html#form.data.week
-
- 10 11月, 2015 1 次提交
-
-
由 Christoph 提交于
According to the W3 spec[1] the value should use a 1-based index and not a 0-based index for the week number. [1]: http://www.w3.org/TR/html-markup/datatypes.html#form.data.week
-
- 08 11月, 2015 1 次提交
-
-
由 Grzegorz Witek 提交于
Now both `javascript_include_tag` and `stylesheet_tag` can accept `host` option to provide custom host for the asset
-
- 04 11月, 2015 2 次提交
-
-
由 Damien Burke 提交于
`link_to :back` creates a link to whatever was passed in via the referer header. If an attacker can alter the referer header, that would create a cross-site scripting vulnerability on every page that uses `link_to :back` This commit restricts the back URL to valid non-javascript URLs. https://github.com/rails/rails/issues/14444
-
由 Rafael Mendonça França 提交于
-
- 03 11月, 2015 1 次提交
-
-
由 Yuki Nishijima 提交于
-
- 30 10月, 2015 1 次提交
-
-
由 Lecky Lao 提交于
making selected value to accept Hash like the default option. E.g. selected: {day: params[:day].to_i, month: params[:month].to_id} Adds in test test_date_select_with_selected_in_hash and change log fixes typo in CHANGELOG
-
- 29 10月, 2015 2 次提交
-
-
由 Genadi Samokovarov 提交于
Stumbled upon this one while trying to deprecate the String/Symbol passing to `form_for`. This test passed on an accident, because the signature of `form_for` currently accepts 2 positional arguments and a block. Calling it with the wrong number of arguments caused: ```ruby (byebug) form_for(:post, @post, html: { id: 'create-post' }) *** ArgumentError Exception: wrong number of arguments (3 for 1..2) ``` This made the test pass, because it was still an `ArgumentError`. :-)
-
由 Kasper Timm Hansen 提交于
It's already represented in the key name. Demonstrate with a test. Also test that the default isn't output.
-
- 25 10月, 2015 1 次提交
-
-
由 Sebastian McKenzie 提交于
-
- 21 10月, 2015 1 次提交
-
-
由 Vasiliy Ermolovich 提交于
-
- 20 10月, 2015 1 次提交
-
-
由 yui-knk 提交于
When `require 'active_support/rails'`, 'active_support/deprecation' is automatically loaded.
-
- 07 10月, 2015 1 次提交
-
-
由 Jeremy Daer 提交于
Rails 4.x and earlier didn't support `Mime::Type[:FOO]`, so libraries that support multiple Rails versions would've had to feature-detect whether to use `Mime::Type[:FOO]` or `Mime::FOO`. `Mime[:foo]` has been around for ages to look up registered MIME types by symbol / extension, though, so libraries and plugins can safely switch to that without breaking backward- or forward-compatibility. Note: `Mime::ALL` isn't a real MIME type and isn't registered for lookup by type or extension, so it's not available as `Mime[:all]`. We use it internally as a wildcard for `respond_to` negotiation. If you use this internal constant, continue to reference it with `Mime::ALL`. Ref. efc6dd55
-
- 06 10月, 2015 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 01 10月, 2015 2 次提交
-
-
由 Prakash Laxkar 提交于
-
由 Akshay Vishnoi 提交于
-
- 29 9月, 2015 1 次提交
-
-
由 Akshay Vishnoi 提交于
-
- 26 9月, 2015 1 次提交
-
-
由 Ronak Jangir 提交于
-
- 25 9月, 2015 2 次提交
-
-
由 Mauro George 提交于
as string
-
由 Mauro George 提交于
This will avoid a error be raised when the only input on the form is the `collection_radio_buttons`.
-
- 22 9月, 2015 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 21 9月, 2015 2 次提交
-
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
- 19 9月, 2015 2 次提交
-
-
由 Aaron Patterson 提交于
This can still be added to the middleware stack, but is really not necessary. I'll follow up with a commit that deprecates the constant
-
由 Kir Shatrov 提交于
-
- 18 9月, 2015 2 次提交
-
-
由 Akira Matsuda 提交于
-
由 Akshay Vishnoi 提交于
Earlier when `data-disable-with` option is added direclty as in options then ```ruby submit_tag("Save", { "data-disable-with" => "Processing..." }) # => <input type="submit" name="commit" value="Save" data-disable-with="Processing..." data-disable-with="Processing..." /> ``` Now when `data-disable-with` option is added direclty as in options then ```ruby submit_tag("Save", { "data-disable-with" => "Processing..." }) # => <input type="submit" name="commit" value="Save" data-disable-with="Processing..." /> ```
-
- 06 9月, 2015 1 次提交
-
-
由 Aaron Patterson 提交于
`hfvalue` parts should always be percent encoded, so lets do that! Revert "use path escaping for email addresses" This reverts commit 21ffef38.
-
- 05 9月, 2015 2 次提交
-
-
由 Aaron Patterson 提交于
Due to e25fdad2, we are correctly using path escaping for email addresses. This commit fixes the tests to expect path escaping.
-
由 Bernerd Schaefer 提交于
The `url_for` methods in `actionpack` and `actionview` now make a copy of the provided options before generating polymorphic paths or URLs. The bug in the previous behavior is most noticeable in a case like: url_options = [:new, :post, param: 'value'] if current_page?(url_options) css_class = "active" end link_to "New Post", url_options, class: css_class
-
- 31 8月, 2015 1 次提交
-
-
由 ojab 提交于
In case of the form with nested fields_for, i. e. <%= form_for :foos, url: root_path do |f| %> <% @foos.each do |foo| %> <%= f.fields_for 'foo[]', foo do |f2| %> <%= f2.text_field :id %> <% foo.bars.each do |bar| %> <%= f2.fields_for 'bar[]', bar do |b| %> <%= b.text_field :id %> <% end %> <% end %> <% end %> <% end %> <%= f.submit %> <% end %> rails doesn't add index for 'foo' in the inner fields_for block, so field names in the outer fields_for looks like "foos[foo][#{foo_index}][id]" and in the inner "foos[foo[]][bar][#{bar_index}][id]". Submitting of such form leads to an error like: >ActionController::BadRequest (Invalid request parameters: expected Array >(got Rack::QueryParser::Params) for param `foo'): This commit adds indexes for the foos in the inner blocks, so field names become "foos[foo][#{foo_index}][bar][#{bar_index}][id]" and submitting of such form works fine as expected. Fixes #15332
-
- 28 8月, 2015 2 次提交
-
-
由 Lachlan Sylvester 提交于
-
由 Vipul A M 提交于
- Extracted `DELIMITED_REGEX` to `delimited_regex` method and made use of user passed `options[:delimited_regex]` if available. Changed `DELIMITED_REGEX` to `DEFAULT)DELIMITED_REGEX` to signify what it means. - Added tests for number to delimited and number to currency in both actionview and activesupport. Changes Changes
-
- 27 8月, 2015 1 次提交
-
-
由 Gaurav Sharma 提交于
-
- 24 8月, 2015 1 次提交
-
-
由 Ronak Jangir 提交于
-
- 16 8月, 2015 1 次提交
-
-
由 eileencodes 提交于
Oops, I broke the build :( Fixes the method signature of `assign_parameters` which now takes 6 arguments instead of 4. We likely will end up chaning the method signature further so good to know this test is here.
-
- 12 8月, 2015 2 次提交
-
-
由 Justin Schiff 提交于
Prevents double submission by making disable_with the default. Default disable_with option will only be applied if user has not specified her/his own disable_with option, whether that is in the `data-disable-with` string form or the `:data => { :disable_with => "Saving..." }` hash form. disable_with will default to the value attribute. A configuration option was added to opt out of this functionality if the user so desires. `config.action_view.automatically_disable_submit_tag = false`
-
由 Mauricio Gomez Aguinaga 提交于
Sometimes you need a specific break sequence while using word wrap and as today the only option we have is "\n" and is hardcoded. With this change you will be able to specify any break sequence ("\r\n" for example) as an option. adding proper documentation for break_sequence in ActionView::Helpers::TextHelper.word_wrap adding some more documentation for word_wrap custom break sequence and making sure we use new hash syntax
-
- 08 8月, 2015 1 次提交
-
-
由 eileencodes 提交于
Using the string version of the class reference is now deprecated when referencing middleware. This should be written as a class not as a string. Deprecation warning that this change fixes: ``` DEPRECATION WARNING: Passing strings or symbols to the middleware builder is deprecated, please change them to actual class references. For example: "ActionDispatch::ShowExceptions" => ActionDispatch::ShowExceptions ```
-
- 27 7月, 2015 1 次提交
-
-
由 Kasper Timm Hansen 提交于
-