1. 11 11月, 2015 1 次提交
  2. 10 11月, 2015 1 次提交
  3. 08 11月, 2015 1 次提交
  4. 04 11月, 2015 2 次提交
  5. 03 11月, 2015 1 次提交
  6. 30 10月, 2015 1 次提交
  7. 29 10月, 2015 2 次提交
    • G
      Fix a faulty form_for test · 252660b8
      Genadi Samokovarov 提交于
      Stumbled upon this one while trying to deprecate the String/Symbol
      passing to `form_for`.
      
      This test passed on an accident, because the signature of `form_for`
      currently accepts 2 positional arguments and a block. Calling it with
      the wrong number of arguments caused:
      
      ```ruby
      (byebug) form_for(:post, @post, html: { id: 'create-post' })
      *** ArgumentError Exception: wrong number of arguments (3 for 1..2)
      ```
      
      This made the test pass, because it was still an `ArgumentError`. :-)
      252660b8
    • K
      Ignore scope in missing translation input. · 0fb2d1a0
      Kasper Timm Hansen 提交于
      It's already represented in the key name. Demonstrate with a test.
      
      Also test that the default isn't output.
      0fb2d1a0
  8. 25 10月, 2015 1 次提交
  9. 21 10月, 2015 1 次提交
  10. 20 10月, 2015 1 次提交
  11. 07 10月, 2015 1 次提交
    • J
      Use `Mime[:foo]` instead of `Mime::Type[:FOO]` for back compat · 565094a8
      Jeremy Daer 提交于
      Rails 4.x and earlier didn't support `Mime::Type[:FOO]`, so libraries
      that support multiple Rails versions would've had to feature-detect
      whether to use `Mime::Type[:FOO]` or `Mime::FOO`.
      
      `Mime[:foo]` has been around for ages to look up registered MIME types
      by symbol / extension, though, so libraries and plugins can safely
      switch to that without breaking backward- or forward-compatibility.
      
      Note: `Mime::ALL` isn't a real MIME type and isn't registered for lookup
      by type or extension, so it's not available as `Mime[:all]`. We use it
      internally as a wildcard for `respond_to` negotiation. If you use this
      internal constant, continue to reference it with `Mime::ALL`.
      
      Ref. efc6dd55
      565094a8
  12. 06 10月, 2015 1 次提交
  13. 01 10月, 2015 2 次提交
  14. 29 9月, 2015 1 次提交
  15. 26 9月, 2015 1 次提交
  16. 25 9月, 2015 2 次提交
  17. 22 9月, 2015 1 次提交
  18. 21 9月, 2015 2 次提交
  19. 19 9月, 2015 2 次提交
  20. 18 9月, 2015 2 次提交
    • A
      File encoding is defaulted to utf-8 in Ruby >= 2.1 · dcecbb42
      Akira Matsuda 提交于
      dcecbb42
    • A
      Fix - Prevent adding of `data-disable-with` option twice in html. · 9331f002
      Akshay Vishnoi 提交于
      Earlier
      when `data-disable-with` option is added direclty as in options then
      
      ```ruby
      submit_tag("Save", { "data-disable-with" => "Processing..." })
      # => <input type="submit" name="commit" value="Save" data-disable-with="Processing..." data-disable-with="Processing..." />
      ```
      
      Now
      when `data-disable-with` option is added direclty as in options then
      
      ```ruby
      submit_tag("Save", { "data-disable-with" => "Processing..." })
      # => <input type="submit" name="commit" value="Save" data-disable-with="Processing..." />
      ```
      9331f002
  21. 06 9月, 2015 1 次提交
  22. 05 9月, 2015 2 次提交
    • A
      use path escaping for email addresses · 21ffef38
      Aaron Patterson 提交于
      Due to e25fdad2, we are correctly using
      path escaping for email addresses.  This commit fixes the tests to
      expect path escaping.
      21ffef38
    • B
      `url_for` does not modify polymorphic options · ee63532d
      Bernerd Schaefer 提交于
      The `url_for` methods in `actionpack` and `actionview`
      now make a copy of the provided options
      before generating polymorphic paths or URLs.
      
      The bug in the previous behavior
      is most noticeable in a case like:
      
          url_options = [:new, :post, param: 'value']
      
          if current_page?(url_options)
            css_class = "active"
          end
      
          link_to "New Post", url_options, class: css_class
      ee63532d
  23. 31 8月, 2015 1 次提交
    • O
      Handle nested fields_for by adding indexes to record_name · 7089768b
      ojab 提交于
      In case of the form with nested fields_for, i. e.
      
      <%= form_for :foos, url: root_path do |f| %>
          <% @foos.each do |foo| %>
              <%= f.fields_for 'foo[]', foo do |f2| %>
                  <%= f2.text_field :id %>
                  <% foo.bars.each do |bar| %>
                      <%= f2.fields_for 'bar[]', bar do |b| %>
                          <%= b.text_field :id %>
                      <% end %>
                  <% end %>
              <% end %>
           <% end %>
          <%= f.submit %>
      <% end %>
      
      rails doesn't add index for 'foo' in the inner fields_for block, so field names
      in the outer fields_for looks like "foos[foo][#{foo_index}][id]" and in the
      inner "foos[foo[]][bar][#{bar_index}][id]". Submitting of such form leads to an
      error like:
      >ActionController::BadRequest (Invalid request parameters: expected Array
      >(got Rack::QueryParser::Params) for param `foo'):
      
      This commit adds indexes for the foos in the inner blocks, so field names
      become "foos[foo][#{foo_index}][bar][#{bar_index}][id]" and submitting of such
      form works fine as expected.
      
      Fixes #15332
      7089768b
  24. 28 8月, 2015 2 次提交
  25. 27 8月, 2015 1 次提交
  26. 24 8月, 2015 1 次提交
  27. 16 8月, 2015 1 次提交
    • E
      Fix test assign_parameter method signature · 2ae68eef
      eileencodes 提交于
      Oops, I broke the build :(
      
      Fixes the method signature of `assign_parameters` which now takes 6
      arguments instead of 4. We likely will end up chaning the method
      signature further so good to know this test is here.
      2ae68eef
  28. 12 8月, 2015 2 次提交
    • J
      Make disable_with default in submit_tag · 3822a322
      Justin Schiff 提交于
      Prevents double submission by making disable_with the default.
      
      Default disable_with option will only be applied if user has not
      specified her/his own disable_with option, whether that is in the
      `data-disable-with` string form or the
      `:data => { :disable_with => "Saving..." }` hash form. disable_with
      will default to the value attribute.
      
      A configuration option was added to opt out of this functionality if
      the user so desires.
      `config.action_view.automatically_disable_submit_tag = false`
      3822a322
    • M
      Sometimes you need a specific break sequence while using word wrap and as... · cf93c6ae
      Mauricio Gomez Aguinaga 提交于
      Sometimes you need a specific break sequence while using word wrap and as today the only option we have is "\n" and is hardcoded.
      
      With this change you will be able to specify any break sequence ("\r\n" for example) as an option.
      
      adding proper documentation for break_sequence in ActionView::Helpers::TextHelper.word_wrap
      
      adding some more documentation for word_wrap custom break sequence and making sure we use new hash syntax
      cf93c6ae
  29. 08 8月, 2015 1 次提交
    • E
      Fix deprecation warning in tests · 12f08acb
      eileencodes 提交于
      Using the string version of the class reference is now deprecated when
      referencing middleware. This should be written as a class not as a string.
      
      Deprecation warning that this change fixes:
      ```
      DEPRECATION WARNING: Passing strings or symbols to the middleware
      builder is deprecated, please change
      them to actual class references.  For example:
        "ActionDispatch::ShowExceptions" => ActionDispatch::ShowExceptions
      ```
      12f08acb
  30. 27 7月, 2015 1 次提交