- 23 8月, 2020 5 次提交
-
-
由 Eugene Kenny 提交于
Followup to 0adcec49.
-
由 Jonathan Hefner 提交于
consistent syntax for items in list
-
由 Jonathan Hefner 提交于
Corrects the documentation for AciveSupport::Configurable config class [ci skip]
-
由 Akshay Birajdar 提交于
-
由 Brandon Zylstra 提交于
The majority of items in this list are clauses that complete the sentence "...you will know...". But the 2nd item was an independent question with its own question mark, and the other changed one had the syntax of a question despite lacking a question mark.
-
- 21 8月, 2020 5 次提交
-
-
由 Jonathan Hefner 提交于
Formats code blocks for better syntax highlighting [ci skip]
-
由 Chirag 提交于
-
由 Jonathan Hefner 提交于
Fix minor formatting issue [ci skip]
-
由 Chirag Shah 提交于
-
由 Carlos Antonio da Silva 提交于
Fix markdown syntax error in docs [ci skip]
-
- 20 8月, 2020 5 次提交
-
-
由 Rafael França 提交于
Bump minimum web-console version to 4.0.3
-
由 Gregorio Kusowski 提交于
-
由 Ryuta Kamizono 提交于
fix documented default values for datetime_select view helper [ci skip]
-
由 nathanallen 提交于
-
由 Aaron Patterson 提交于
Correctly wrap inline attachments.
-
- 19 8月, 2020 7 次提交
-
-
由 Prem Sichanugrist 提交于
[Guides] Update web_console settings to use allowed_ips
-
由 Ryuta Kamizono 提交于
Fix generated default index names in API doc [ci skip]
-
由 mikong 提交于
-
由 Jonathan Hefner 提交于
Fix small typo in configuring guide [skip ci]
-
由 Petrik 提交于
-
由 Daniel Colson 提交于
Update Engine getting started generation instructions for consistency
-
由 Jeff McAffer 提交于
New to Rails but looks like everything for an engine should be done inside the engine's folder. The updated text has been there for a long time so I hope I'm not just missing something. At this point in the example the user does not have an application (that comes in the next section) and elsewhere in the doc there is talk of the importance of running the commands from the *engine* root so it seems more consistent to talk about "engine root" as updated.
-
- 18 8月, 2020 7 次提交
-
-
由 Eileen M. Uchitelle 提交于
Combine and deprecate `rails db:structure:{dump,load}` tasks into `rails db:schema:{dump,load}`
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Update outdated bundler in gemspec
-
由 Jonathan Hefner 提交于
Use headings to make Action Cable terminology more clear [skip ci]
-
由 Petrik 提交于
The Terminology section of the Action Cable guide currently is one large text without any headings. Instead of having one large text, we can use headings to describe all terminology for easier scanability and improved table of contents. The Broadcastings section mentions Pub/Sub so it's moved beneath the Pub/Sub section. The following part is moved up to the Connections terminology section. It makes more sense to have it where it introduces the term. > Connections form the foundation of the client-server relationship.
-
由 Jonathan Hefner 提交于
Refer to channel instead of cable [ci-skip]
-
由 mikong 提交于
-
- 17 8月, 2020 6 次提交
-
-
由 Eileen M. Uchitelle 提交于
-
由 Eileen M. Uchitelle 提交于
Merge pull request #39886 from lanzhiheng/append-some-description-about-advance-constraints-in-block-form [ci skip] Append some description about advance constraints
-
由 Eileen M. Uchitelle 提交于
Automatically set Link header for each stylesheet and script
-
由 Ryuta Kamizono 提交于
Fix eager loading that non-select columns will be loaded
-
由 Ryuta Kamizono 提交于
Fix preloader to associate preloaded records by default
-
由 Ryuta Kamizono 提交于
Related to #35210. We sometimes use `select` to limit unused columns for performance. For example, `GET /posts/1` (post detail) usually use (almost) all columns, but `GET /posts` (post list) does not always use all columns (e.g. use `id` and `title` for the list view, but `body` is not used). If an association is eager loaded, the limited `select` doesn't works as expected, eager loading will load all columns on the model, plus also load the `select` columns additionally. It works differently with natural load and preload. It means that changing natural load or preload to eager load (or vice versa) is unsafe. This fixes eager loading that always load all columns (plus extra `select` columns), to respect the `select` columns like as others. ```ruby post = Post.select("UPPER(title) AS title").first post.title # => "WELCOME TO THE WEBLOG" post.body # => ActiveModel::MissingAttributeError # Rails 6.0 (ignore the `select` values) post = Post.select("UPPER(title) AS title").eager_load(:comments).first post.title # => "Welcome to the weblog" post.body # => "Such a lovely day" # Rails 6.1 (respect the `select` values) post = Post.select("UPPER(title) AS title").eager_load(:comments).first post.title # => "WELCOME TO THE WEBLOG" post.body # => ActiveModel::MissingAttributeError ```
-
- 16 8月, 2020 3 次提交
-
-
由 Ryuta Kamizono 提交于
Someone had relied on the behavior that preloading with a given scope, but the behavior has lost in #35496 to fix the minor bug that unloading through association. Basically we don't guarantee the internal behavior, but the bugfix can be achieved without any breaking change, so I've restored the lost functionality. Fixes #36638. Fixes #37720.
-
由 Daniel Colson 提交于
fix(guides): Update AWDwR book link in Releasing Rails guide [ci skip]
-
由 Eugene Kenny 提交于
Use superclass name in inspect of anonymous ActionView::Base subclass
-
- 15 8月, 2020 2 次提交
-
-
由 Petrik 提交于
When rendering views an anonymous subclass is created by calling ActionView::Base.with_empty_template_cache. This causes inspect to return an unhelpful description when calling inspect: `#<#<Class:0x012345012345>:<0x012345012345>`. This can be confusing when exceptions are raised because it's hard to figure out where to look. For example calling an undefined method in a template would raise the following exception: undefined method `undefined' for #<#<Class:0x012345012345>:<0x012345012345> Instead we can return the non-anonymous superclass name. undefined method `undefined' for #<ActionView::Base:0x01234502345> The anonymous class is created in ActionView::Base.with_empty_template_cache. See f9bea630 This seems to be done for performance reasons only, without expecting a change to calling `inspect`.
-
由 Jonathan Hefner 提交于
Remove double negative in testing docs [ci-skip]
-