- 23 12月, 2019 12 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Regex did not match CREATE TABLE in all cases
-
由 Ulrich Thomas Gabor 提交于
The regular expression did not match CREATE TABLE statements printed out by AWS Aurora MySQL 5.6 instances, because they lack the required space at that position.
-
由 Ryuta Kamizono 提交于
Add preposition and conjunction example to title guideline [ci skip]
-
由 Ryuta Kamizono 提交于
Fix title capitalization in guides according to guidelines [ci skip]
-
由 Petrik 提交于
-
由 Petrik 提交于
According to the guide guidelines, all words except for prepositions, conjunctions, internal articles, and forms of the verb "to be" should be capitalized. This commit fixes some titles.
-
由 Kasper Timm Hansen 提交于
Improve escape_javascript performance.
-
由 Ben Ubois 提交于
-
由 Jean Boussier 提交于
-
由 Eugene Kenny 提交于
Tiny code example fix [ci skip]
-
由 Petrik 提交于
The code example wasn't properly formatted because of missing line break.
-
- 22 12月, 2019 4 次提交
-
-
由 Kasper Timm Hansen 提交于
github actions checkout v2
-
由 Kasper Timm Hansen 提交于
Encode template source before extracting lines
-
由 Sean C. Sullivan 提交于
-
由 John Hawthorn 提交于
Fixes for isolation tests
-
- 21 12月, 2019 21 次提交
-
-
由 Ryuta Kamizono 提交于
Use multiline example blocks for improved readability [ci skip]
-
由 Petrik 提交于
-
由 John Hawthorn 提交于
We need a more complete understanding of mime types for the asset tags to render properly, so we need to load this rather than just the stubs included by actionview by default. This fixes running these tests in isolation.
-
由 John Hawthorn 提交于
These tests were failing because Array#second from core_ext wasn't loaded. In one place we now load it, in another we use arr[1] instead.
-
由 Eugene Kenny 提交于
Before 2169bd3d, a template's source was encoded in place when it was compiled, and the `source_extract` method could rely on `Template#source` to return a properly encoded string. Now that `Template#source` always returns a new copy of the template source with no encoding, `source_extract` should call `encode!` itself.
-
由 John Hawthorn 提交于
Revert "Fix keyward arguments warning in `MiddlewareStack#build`"
-
由 John Hawthorn 提交于
This reverts commit 6b633a28.
-
由 John Hawthorn 提交于
Merge pull request #37351 from bbuchalter/bb.avoid_applying_db_actions_to_test_when_database_url_is_present Ignore test env in DatabaseTasks when DATABASE_URL is present
-
由 Brian Buchalter 提交于
Fixes https://github.com/rails/rails/issues/28827. The steps to reproduce are as follows: git clone git@github.com:bbuchalter/rails-issue-28827.git cd rails-issue-28827 bundle install bin/rails db:create Observe that we create two databases when invoking db:create: development and test. Now observe what happens when we invoke our drop command while using DATABASE_URL. DATABASE_URL=sqlite3://$(pwd)/db/database_url.sqlite3 bin/rails db:create As expected, the development environment now uses the DATABASE_URL. What is unexpected is that the test environment does not. It's unclear what the expected behavior should be in this case, but the cause of it is this: https://github.com/rails/rails/blob/9f2c74eda07ea5a9e4e624d5575a717714088dbf/activerecord/lib/active_record/tasks/database_tasks.rb#L494 Because of each_local_configuration, there seems to be no way invoke these database rake on only the development environment to ensure DATABASE_URL is respected. The smallest scope of change I can think to make would be to conditionalize this behavior so it does not get applied when DATABASE_URL is present.
-
由 Eugene Kenny 提交于
Remove guide example for deprecated database switching
-
由 Eric Hayes 提交于
Using the `database` kwarg with `connected_to` was deprecated in https://github.com/rails/rails/pull/37874, so this removes the example from the guide to avoid confusion.
-
由 Ryuta Kamizono 提交于
-
由 Peter Zhu 提交于
-
由 Ryuta Kamizono 提交于
-
由 Rafael França 提交于
Make Rails::Configuration::Generators accessor consistent
-
由 Rafael França 提交于
Improve `ActiveSupport::Duration` performance about 25% ~ 50%
-
由 Rafael França 提交于
Use the 'What is FRAMEWORK?' title for all framework guides [ci skip]
-
由 Rafael França 提交于
Remove extra `the` in preloader docs
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Mariano Vallés 提交于
-
- 20 12月, 2019 3 次提交
-
-
由 Ryuta Kamizono 提交于
Remove week from iso8601 parts [continuation of 34683]
-
由 Abhishek Sarkar 提交于
It converts the week part into days and removes it from the final result. ``` duration = ActiveSupport::Duration.build(1000000) # 1 week, 4 days, 13 hours, 46 minutes, and 40.0 seconds duration_iso = duration.iso8601 # P11DT13H46M40S ActiveSupport::Duration.parse(duration_iso) # 11 days, 13 hours, 46 minutes, and 40 seconds ```
-
由 Ryuta Kamizono 提交于
Fix Ruby 2.7 warnings in Action Pack 6.0
-