- 16 8月, 2016 27 次提交
-
-
由 Maxime Lapointe 提交于
The current behaviour of checking if there is a LEFT OUTER JOIN arel node to detect if we are doing eager_loading is wrong. This problem wasn't frequent before as only some pretty specific cases would add a LEFT OUTER JOIN arel node. However, the recent new feature left_outer_joins also add this node and made this problem happen frequently. Since in the perform_calculation function, we don't have access to eager_loading information, I had to extract the logic for the distinct out to the calculate method. As I was in the file for left_outer_join tests, I fixed a few that had bugs and I replaced some that were really weak with something that will catch more issues. In relation tests, the first test I changed would have failed if it had validated the hash returned by count instead of just checking how many pairs were in it. This is because this merge of join currently transforms the join node into an outer join node, which then made count do a distinct. So before this change, the return was {1=>1, 4=>1, 5=>1}.
-
由 Rafael França 提交于
List names of error interpolation variables.
-
由 Rafael França 提交于
Clarify migration to ApplicationRecord in upgrade guides [ci skip]
-
由 Rafael França 提交于
Add array column documentation
-
由 Rafael França 提交于
Show unpermitted parameters as symbols in logs (so they could be copy…
-
由 oss92 提交于
-
由 Rafael Mendonça França 提交于
Make association queries to preparable: Step 1
-
由 Rafael França 提交于
`where` by `array|range` attribute with array or range value
-
由 Rafael França 提交于
When calling association.find RecordNotFound is now raised with the s…
-
由 Rafael França 提交于
Avoid to allow unused splat args for `t.timestamps` in `create_table`
-
由 Rafael Mendonça França 提交于
Refactor `quoted_columns_for_index` by extracted `add_options_for_index_columns`
-
由 Rafael França 提交于
fix Rails.application.routes.router.visualizer for router debugging
-
由 Rafael França 提交于
`CollectionProxy#take` should respect dirty target
-
由 Rafael França 提交于
Support multiple indexes on the same column when loading the schema
-
由 Rafael França 提交于
remove "test/mailers" directory when skipping action-mailer
-
由 Rafael França 提交于
Drop a temporary table before end of a test case
-
由 Rafael Mendonça França 提交于
Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
-
由 Matthew Draper 提交于
Fix ActionController::Live deadlock
-
由 Rafael França 提交于
Eager autoload ActiveRecord::TableMetadata
-
由 claudiob 提交于
Fixes a bug that can occur when ActiveJob tries to access ActiveRecord. Specifically, I had an Active Job process fail on Sidekiq with this error: ``` ActiveJob::DeserializationError: Error while trying to deserialize arguments: uninitialized constant ActiveRecord::Core::ClassMethods::TableMetadata Did you mean? ActiveRecord::TableMetadata ``` raised by these lines of code: ``` [GEM_ROOT]/gems/activerecord-5.0.0.1/lib/active_record/core.rb:300 :in `table_metadata` 298 299 def table_metadata # :nodoc: 300 TableMetadata.new(self, arel_table) 301 end 302 end [GEM_ROOT]/gems/activerecord-5.0.0.1/lib/active_record/core.rb:273 :in `predicate_builder` [GEM_ROOT]/gems/activerecord-5.0.0.1/lib/active_record/core.rb:290 :in `relation` ``` The problem seems to be that, inside ActiveRecord::Core, the `TableMetadata` class has not been loaded and, therefore, Rails tries to access the constant `ActiveRecord::Core::ClassMethods::TableMetadata` which does not exist. Eager loading `ActiveRecord::TableMetadata` should fix the issue. @rafaelfranca -- see our Campfire discussion
-
由 Alex Chinn 提交于
Fix deadlock that can occur when child live thread tries to load a constant after writing to the stream.
-
由 Vipul A M 提交于
Clarify use of update task on 4.2 and earlier [ci skip]
-
由 Marcus Stollsteimer 提交于
-
由 Kasper Timm Hansen 提交于
Remove `find_nth_with_limit_and_offset` private method
-
由 Marcus Stollsteimer 提交于
-
由 Kasper Timm Hansen 提交于
Remove odd ivar from ActiveRecord::LogSubscriber
-
由 Matthew Draper 提交于
AC::Metal is already defining default encoding as UTF 8, let's reuse it.
-
- 15 8月, 2016 13 次提交
-
-
由 Eileen M. Uchitelle 提交于
remove useless parameter
-
由 Jon Moss 提交于
fix usage of pluralized word [ci skip]
-
由 Eugene Kenny 提交于
This was used to switch the output colour between log lines, but now the output colour is based on the type of statement being logged instead.
-
由 chuckdishmon 提交于
-
由 Ryuta Kamizono 提交于
`find_nth` is protected method, therefore `offset` has not been passed anywhere. `find_nth_with_limit_and_offset` is unnecessary anymore because `offset` has not been passed.
-
由 Jon Moss 提交于
Fix `ActiveRecord::FixtureSet` docs [ci skip]
-
由 Ryuta Kamizono 提交于
`ActiveSupport::TestCase` was replaced `ActiveRecord::TestCase` in #26150. But this docs is for rails apps per se, it should be `ActiveSupport::TestCase`. See https://github.com/rails/rails/pull/26150#discussion_r74710989.
-
由 Xavier Noria 提交于
Reason: See https://github.com/rails/rails/pull/26163#issuecomment-239703322 This reverts commit 39effc85.
-
由 Sean Griffin 提交于
Consolidate `ActiveRecord::TestCase` and `ActiveSupport::TestCase` in AR test cases
-
由 Aaron Patterson 提交于
Fixes #26122
-
由 Sean Griffin 提交于
add more array methods to straight delegation to speed up calling them
-
由 Jon Moss 提交于
Clarify and fix typos in autoloading disabled section
-
由 Kasper Timm Hansen 提交于
It's tough for people without the knowledge of where the `get` and friends integration test helpers are defined to find documentation for them. Add a link to the main integration test documentation.
-