Ensure methods called on association proxies respect access control. [#1083 state:resolved] [Adam Milligan, Pratik]

There are several situations it doesn't cater for, and the inconsistency isn't worth blocking 2.2.

explicitly including child associations that are also included in the parent association definition should not result in double records in the collection/double loads (#1110)
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1110 state:committed]

Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1068 status:committed]

Model.sum delegates typecasting to the column being summed. If that's not feasible, returns a string.
Model.avg always returns big decimal.

Remove HasManyAssociationStrategy and move the logic to ActiveRecord::Reflection::ThroughReflection.

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

We have hit dramatic increase in tests time after upgrading rails.
Profiling revealed this particular place. After this fix our test times returned
back to norm.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1173 state:committed]

Signed-off-by: NMichael Koziarski <michael@koziarski.com>

[#1169 state:committed]

After releasing monitor some connection(s) may appear in pool before monitor is re-aquired.
When this happens we'll wait for connection which is already available.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>

Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1168 state:committed]

Make sure recreate MySQL test database with the proper encoding and collation [#1165 state:resolved]
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1165 state:committed]

Dynamic finders should use the ActiveRecord::Base::find method instead of ::find_initial, :find_last, and ::find_all.

This is so when people override ActiveRecord::Base::find, the new ::find method will also be invoked by the dynamic finders.
Associations for instance do go through ::find, so this makes it more consistent.
Also removed the unnecessary deprecation silence blocks.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>

[#1162 state:committed]

Signed-off-by: NMichael Koziarski <michael@koziarski.com>

wrote a test showing eager loading's misbehavior (sanitizing against the wrong table) when the association has a :conditions hash
Signed-off-by: NMichael Koziarski <michael@koziarski.com>

Ignore all exceptions for validates_acceptance_of columns fetch so it can run even without a database connection
Signed-off-by: NMichael Koziarski <michael@koziarski.com>

Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1084 state:committed]

Add an additional conditions option to make it slightly easier for certain plugins.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1087 state:committed]

Allowed passing arrays-of-strings to :join everywhere. Merge duplicate join strings to avoid table aliasing problems.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1077 state:committed]

AssociationCollection now starts transactions by calling
AssociationCollection#transaction instead of @owner.transaction or
@reflection.klass.transaction.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>

[#1081 state:committed]

This allows people tracking non-release gems or git submodules to use the constants.

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

I18n: Introduce I18n.load_path in favor of I18n.load_translations and change Simple backend to load translations lazily. [#1048 state:resolved]
Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Signed-off-by: NMichael Koziarski <michael@koziarski.com>

Without this change count_records will group for the count in the query and return erroneous results.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#937 state:committed]

[#1045 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

[#1043 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Base.skip_time_zone_conversion_for_attributes uses class_inheritable_accessor, so that subclasses don't overwrite Base [#346 state:resolved]